mbox series

[v1,net,00/15] sysctl: Fix data-races around ipv4_net_table (Round 5).

Message ID 20220720165026.59712-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series sysctl: Fix data-races around ipv4_net_table (Round 5). | expand

Message

Kuniyuki Iwashima July 20, 2022, 4:50 p.m. UTC 
This series fixes data-races around 15 knobs after tcp_dsack in
ipv4_net_table.

tcp_tso_win_divisor was skipped because it already uses READ_ONCE().

So, the final round for ipv4_net_table will start with tcp_pacing_ss_ratio.


Kuniyuki Iwashima (15):
  tcp: Fix data-races around sysctl_tcp_dsack.
  tcp: Fix a data-race around sysctl_tcp_app_win.
  tcp: Fix a data-race around sysctl_tcp_adv_win_scale.
  tcp: Fix a data-race around sysctl_tcp_frto.
  tcp: Fix a data-race around sysctl_tcp_nometrics_save.
  tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save.
  tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf.
  tcp: Fix data-races around sysctl_tcp_workaround_signed_windows.
  tcp: Fix a data-race around sysctl_tcp_limit_output_bytes.
  tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit.
  tcp: Fix a data-race around sysctl_tcp_min_tso_segs.
  tcp: Fix a data-race around sysctl_tcp_tso_rtt_log.
  tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen.
  tcp: Fix a data-race around sysctl_tcp_autocorking.
  tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit.

 include/net/tcp.h      |  2 +-
 net/ipv4/tcp.c         |  2 +-
 net/ipv4/tcp_input.c   | 17 +++++++++--------
 net/ipv4/tcp_metrics.c | 10 +++++-----
 net/ipv4/tcp_output.c  | 10 +++++-----
 net/mptcp/options.c    |  2 +-
 net/mptcp/protocol.c   |  2 +-
 7 files changed, 23 insertions(+), 22 deletions(-)

Comments

Eric Dumazet July 20, 2022, 5:17 p.m. UTC | #1 
On Wed, Jul 20, 2022 at 6:53 PM Kuniyuki Iwashima <kuniyu@amazon.com> wrote:
>
> This series fixes data-races around 15 knobs after tcp_dsack in
> ipv4_net_table.
>
> tcp_tso_win_divisor was skipped because it already uses READ_ONCE().
>
> So, the final round for ipv4_net_table will start with tcp_pacing_ss_ratio.
>
>

For the series:

Reviewed-by: Eric Dumazet <edumazet@google.com>
patchwork-bot+netdevbpf@kernel.org July 22, 2022, 11:10 a.m. UTC | #2 
Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 20 Jul 2022 09:50:11 -0700 you wrote:
> This series fixes data-races around 15 knobs after tcp_dsack in
> ipv4_net_table.
> 
> tcp_tso_win_divisor was skipped because it already uses READ_ONCE().
> 
> So, the final round for ipv4_net_table will start with tcp_pacing_ss_ratio.
> 
> [...]

Here is the summary with links:
  - [v1,net,01/15] tcp: Fix data-races around sysctl_tcp_dsack.
    https://git.kernel.org/netdev/net/c/58ebb1c8b35a
  - [v1,net,02/15] tcp: Fix a data-race around sysctl_tcp_app_win.
    https://git.kernel.org/netdev/net/c/02ca527ac558
  - [v1,net,03/15] tcp: Fix a data-race around sysctl_tcp_adv_win_scale.
    https://git.kernel.org/netdev/net/c/36eeee75ef01
  - [v1,net,04/15] tcp: Fix a data-race around sysctl_tcp_frto.
    https://git.kernel.org/netdev/net/c/706c6202a358
  - [v1,net,05/15] tcp: Fix a data-race around sysctl_tcp_nometrics_save.
    https://git.kernel.org/netdev/net/c/8499a2454d9e
  - [v1,net,06/15] tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save.
    https://git.kernel.org/netdev/net/c/ab1ba21b523a
  - [v1,net,07/15] tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf.
    https://git.kernel.org/netdev/net/c/780476488844
  - [v1,net,08/15] tcp: Fix data-races around sysctl_tcp_workaround_signed_windows.
    https://git.kernel.org/netdev/net/c/0f1e4d06591d
  - [v1,net,09/15] tcp: Fix a data-race around sysctl_tcp_limit_output_bytes.
    https://git.kernel.org/netdev/net/c/9fb90193fbd6
  - [v1,net,10/15] tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit.
    https://git.kernel.org/netdev/net/c/db3815a2fa69
  - [v1,net,11/15] tcp: Fix a data-race around sysctl_tcp_min_tso_segs.
    https://git.kernel.org/netdev/net/c/e0bb4ab9dfdd
  - [v1,net,12/15] tcp: Fix a data-race around sysctl_tcp_tso_rtt_log.
    https://git.kernel.org/netdev/net/c/2455e61b85e9
  - [v1,net,13/15] tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen.
    https://git.kernel.org/netdev/net/c/1330ffacd05f
  - [v1,net,14/15] tcp: Fix a data-race around sysctl_tcp_autocorking.
    https://git.kernel.org/netdev/net/c/85225e6f0a76
  - [v1,net,15/15] tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit.
    https://git.kernel.org/netdev/net/c/2afdbe7b8de8

You are awesome, thank you!