mbox series

[iproute2-next,0/2] devlink: remove dl_argv_parse_put

Message ID 20220818211521.169569-1-jacob.e.keller@intel.com (mailing list archive)
Headers show
Series devlink: remove dl_argv_parse_put | expand

Message

Jacob Keller Aug. 18, 2022, 9:15 p.m. UTC 
This series removes the dl_argv_parse_put function which both parses the
command line arguments and places them into the netlink header.

This was originally sent as an RFC at
https://lore.kernel.org/netdev/20220805234155.2878160-1-jacob.e.keller@intel.com/

Since there is some ongoing work around policy code being generated from
YAML, I thought it best to wait on the devlink policy portion of this series
for now.

Jiri mentioned he wanted to base some work on top of this, so I am sending
just the cleanup patches.

The primary motivation for this is due to the fact that dl_argv_parse_put
requires a netlink header, meaning a command must have already been
prepared. This prevents addition of a different netlink command to get the
policy data, and thus prevents us from using this variant while checking
netlink policy.

Cc: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Jiri Pirko <jiri@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: David Ahern <dsahern@kernel.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org

Jacob Keller (2):
  devlink: use dl_no_arg instead of checking dl_argc == 0
  devlink: remove dl_argv_parse_put

 devlink/devlink.c | 587 ++++++++++++++++++++++++++--------------------
 1 file changed, 329 insertions(+), 258 deletions(-)


base-commit: 700a8991f05e6e37889101196a531cf82777bdf7

Comments

Jiri Pirko Aug. 19, 2022, 8:27 a.m. UTC | #1 
Thu, Aug 18, 2022 at 11:15:19PM CEST, jacob.e.keller@intel.com wrote:
>This series removes the dl_argv_parse_put function which both parses the
>command line arguments and places them into the netlink header.
>
>This was originally sent as an RFC at
>https://lore.kernel.org/netdev/20220805234155.2878160-1-jacob.e.keller@intel.com/
>
>Since there is some ongoing work around policy code being generated from
>YAML, I thought it best to wait on the devlink policy portion of this series
>for now.
>
>Jiri mentioned he wanted to base some work on top of this, so I am sending
>just the cleanup patches.
>
>The primary motivation for this is due to the fact that dl_argv_parse_put
>requires a netlink header, meaning a command must have already been
>prepared. This prevents addition of a different netlink command to get the
>policy data, and thus prevents us from using this variant while checking
>netlink policy.

Thanks Jacob!
patchwork-bot+netdevbpf@kernel.org Aug. 24, 2022, 4 p.m. UTC | #2 
Hello:

This series was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Thu, 18 Aug 2022 14:15:19 -0700 you wrote:
> This series removes the dl_argv_parse_put function which both parses the
> command line arguments and places them into the netlink header.
> 
> This was originally sent as an RFC at
> https://lore.kernel.org/netdev/20220805234155.2878160-1-jacob.e.keller@intel.com/
> 
> Since there is some ongoing work around policy code being generated from
> YAML, I thought it best to wait on the devlink policy portion of this series
> for now.
> 
> [...]

Here is the summary with links:
  - [iproute2-next,1/2] devlink: use dl_no_arg instead of checking dl_argc == 0
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=0ce6ae80c380
  - [iproute2-next,2/2] devlink: remove dl_argv_parse_put
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=8ed3d1687dc1

You are awesome, thank you!