| Message ID | 20220912070143.98153-1-francesco.dolcini@toradex.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Revert fec PTP changes | expand |
On Mon, Sep 12, 2022 at 09:01:41AM +0200, Francesco Dolcini wrote: > Revert the last 2 FEC PTP changes from Csókás Bence, they are causing multiple > issues and we are at 6.0-rc5. Hello Csókás, the net maintainers will decide how to proceed on this, IMO now we should just revert both. In parallel you can work on a new patch to handle the PTP issue you were trying to address. BR, Francesco
On 12.09.2022 09:01:41, Francesco Dolcini wrote: > Revert the last 2 FEC PTP changes from Csókás Bence, they are causing multiple > issues and we are at 6.0-rc5. > > Francesco Dolcini (2): > Revert "fec: Restart PPS after link state change" > Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`" Nitpick: I would revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`" first, as it's the newer patch. > > drivers/net/ethernet/freescale/fec.h | 11 +---- > drivers/net/ethernet/freescale/fec_main.c | 59 +++++------------------ > drivers/net/ethernet/freescale/fec_ptp.c | 57 +++++++--------------- > 3 files changed, 31 insertions(+), 96 deletions(-) regards, Marc
On Mon, Sep 12, 2022 at 02:28:57PM +0200, Marc Kleine-Budde wrote: > On 12.09.2022 09:01:41, Francesco Dolcini wrote: > > Revert the last 2 FEC PTP changes from Csókás Bence, they are causing multiple > > issues and we are at 6.0-rc5. > > > > Francesco Dolcini (2): > > Revert "fec: Restart PPS after link state change" > > Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`" > > Nitpick: I would revert "net: fec: Use a spinlock to guard > `fep->ptp_clk_on`" first, as it's the newer patch. Shame on me, I do 100% agree, I inverted the 2 patches last second. Francesco
On 12.09.22 14:38, Francesco Dolcini wrote: > On Mon, Sep 12, 2022 at 02:28:57PM +0200, Marc Kleine-Budde wrote: >> On 12.09.2022 09:01:41, Francesco Dolcini wrote: >>> Revert the last 2 FEC PTP changes from Csókás Bence, they are causing multiple >>> issues and we are at 6.0-rc5. >>> >>> Francesco Dolcini (2): >>> Revert "fec: Restart PPS after link state change" >>> Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`" >> >> Nitpick: I would revert "net: fec: Use a spinlock to guard >> `fep->ptp_clk_on`" first, as it's the newer patch. > > Shame on me, I do 100% agree, I inverted the 2 patches last second. What's the status of this patchset? It seems it didn't make any progress in the past few days, or am I missing something? Just asking, because the thing is: I'm pretty sure that Linus will be somewhat unhappy if there isn't any attempt to get this fixed before rc7, as the the problems caused by these patches are known for a while now. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.
On Tue, 2022-09-20 at 09:45 +0200, Thorsten Leemhuis wrote: > On 12.09.22 14:38, Francesco Dolcini wrote: > > On Mon, Sep 12, 2022 at 02:28:57PM +0200, Marc Kleine-Budde wrote: > > > On 12.09.2022 09:01:41, Francesco Dolcini wrote: > > > > Revert the last 2 FEC PTP changes from Csókás Bence, they are causing multiple > > > > issues and we are at 6.0-rc5. > > > > > > > > Francesco Dolcini (2): > > > > Revert "fec: Restart PPS after link state change" > > > > Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`" > > > > > > Nitpick: I would revert "net: fec: Use a spinlock to guard > > > `fep->ptp_clk_on`" first, as it's the newer patch. > > > > Shame on me, I do 100% agree, I inverted the 2 patches last second. > > What's the status of this patchset? It seems it didn't make any progress > in the past few days, or am I missing something? Due to some unfortunate circumstances, we have quite a bit of backlog in the netdev patchwork. We are working to process it, and the above revert will be processed before the next rc. Cheers, Paolo
Hello: This series was applied to netdev/net.git (master) by Paolo Abeni <pabeni@redhat.com>: On Mon, 12 Sep 2022 09:01:41 +0200 you wrote: > Revert the last 2 FEC PTP changes from Csókás Bence, they are causing multiple > issues and we are at 6.0-rc5. > > Francesco Dolcini (2): > Revert "fec: Restart PPS after link state change" > Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`" > > [...] Here is the summary with links: - [net,1/2] Revert "fec: Restart PPS after link state change" https://git.kernel.org/netdev/net/c/7b15515fc1ca - [net,2/2] Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`" https://git.kernel.org/netdev/net/c/01b825f997ac You are awesome, thank you!