| Message ID | 20220921135118.968595-1-atenart@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: macsec: remove the preparation phase when offloading operations | expand |
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 21 Sep 2022 15:51:11 +0200 you wrote: > Hello, > > It was reported[1] the 2-step phase offloading of MACsec operations did > not fit well and device drivers were mostly ignoring the first phase > (preparation). In addition the s/w fallback in case h/w rejected an > operation, which could have taken advantage of this design, never was > implemented and it's probably not a good idea anyway (at least > unconditionnally). So let's remove this logic which only makes the code > more complex for no advantage, before there are too many drivers > providing MACsec offloading. > > [...] Here is the summary with links: - [net-next,1/7] net: phy: mscc: macsec: make the prepare phase a noop https://git.kernel.org/netdev/net-next/c/920d998e5322 - [net-next,2/7] net: atlantic: macsec: make the prepare phase a noop https://git.kernel.org/netdev/net-next/c/135435f90b94 - [net-next,3/7] net: macsec: remove the prepare phase when offloading https://git.kernel.org/netdev/net-next/c/854c9181738f - [net-next,4/7] net: phy: mscc: macsec: remove checks on the prepare phase https://git.kernel.org/netdev/net-next/c/6b701f4101e0 - [net-next,5/7] net: atlantic: macsec: remove checks on the prepare phase https://git.kernel.org/netdev/net-next/c/27418b55f094 - [net-next,6/7] net/mlx5e: macsec: remove checks on the prepare phase https://git.kernel.org/netdev/net-next/c/36c2ebced3a8 - [net-next,7/7] net: macsec: remove the prepare flag from the MACsec offloading context https://git.kernel.org/netdev/net-next/c/99383f1298ee You are awesome, thank you!
Hello, It was reported[1] the 2-step phase offloading of MACsec operations did not fit well and device drivers were mostly ignoring the first phase (preparation). In addition the s/w fallback in case h/w rejected an operation, which could have taken advantage of this design, never was implemented and it's probably not a good idea anyway (at least unconditionnally). So let's remove this logic which only makes the code more complex for no advantage, before there are too many drivers providing MACsec offloading. This series removes the first phase (preparation) of the MACsec h/w offloading. The modifications are split per-driver and in a way that makes bissection working with logical steps; but I can squash some patches if needed. This was tested on the MSCC PHY but not on the Altantic nor mlx5e NICs. Thanks, Antoine [1] https://lore.kernel.org/all/166322893264.61080.12133865599607623050@kwain/T/ Antoine Tenart (7): net: phy: mscc: macsec: make the prepare phase a noop net: atlantic: macsec: make the prepare phase a noop net: macsec: remove the prepare phase when offloading net: phy: mscc: macsec: remove checks on the prepare phase net: atlantic: macsec: remove checks on the prepare phase net/mlx5e: macsec: remove checks on the prepare phase net: macsec: remove the prepare flag from the MACsec offloading context .../ethernet/aquantia/atlantic/aq_macsec.c | 57 --------- .../mellanox/mlx5/core/en_accel/macsec.c | 36 ------ drivers/net/macsec.c | 14 --- drivers/net/phy/mscc/mscc_macsec.c | 113 ++++++------------ include/net/macsec.h | 2 - 5 files changed, 39 insertions(+), 183 deletions(-)