[net-next,v2,0/2] gve: Handle alternate miss-completions

Message

Jeroen de Borst Nov. 11, 2022, 4:35 p.m. UTC

Some versions of the virtual NIC present miss-completions in
an alternative way. This patchset lets the diver handle these
alternate completions and announce this capability to the device.

Changes in v2:
- Changed the subject to include 'gve:'

Jeroen de Borst (2):
  gve: Adding a new AdminQ command to verify driver
  gve: Handle alternate miss completions

 drivers/net/ethernet/google/gve/gve.h         |  1 +
 drivers/net/ethernet/google/gve/gve_adminq.c  | 19 +++++++
 drivers/net/ethernet/google/gve/gve_adminq.h  | 51 ++++++++++++++++++
 .../net/ethernet/google/gve/gve_desc_dqo.h    |  5 ++
 drivers/net/ethernet/google/gve/gve_main.c    | 52 +++++++++++++++++++
 drivers/net/ethernet/google/gve/gve_tx_dqo.c  | 18 ++++---
 6 files changed, 140 insertions(+), 6 deletions(-)

Comments

Jesse Brandeburg Nov. 14, 2022, 8:32 p.m. UTC | #1

On 11/11/2022 8:35 AM, Jeroen de Borst wrote:
> Some versions of the virtual NIC present miss-completions in
> an alternative way. This patchset lets the diver handle these
nit:                                         ^^^^^
                                              driver

nit: use imperative voice. replace "This patchset lets" with "Let"

> alternate completions and announce this capability to the device.
> 
> Changes in v2:
> - Changed the subject to include 'gve:'
> 
> Jeroen de Borst (2):
>    gve: Adding a new AdminQ command to verify driver
>    gve: Handle alternate miss completions
> 
>   drivers/net/ethernet/google/gve/gve.h         |  1 +
>   drivers/net/ethernet/google/gve/gve_adminq.c  | 19 +++++++
>   drivers/net/ethernet/google/gve/gve_adminq.h  | 51 ++++++++++++++++++
>   .../net/ethernet/google/gve/gve_desc_dqo.h    |  5 ++
>   drivers/net/ethernet/google/gve/gve_main.c    | 52 +++++++++++++++++++
>   drivers/net/ethernet/google/gve/gve_tx_dqo.c  | 18 ++++---
>   6 files changed, 140 insertions(+), 6 deletions(-)
> 

I looked over this series for things that didn't make sense and I didn't 
find any, so, esp if you fix the cover letter stuff above.

For the series:
Reviewed-by: Jesse Brandeburg <[e-mail]>