mbox series

[net-next,v4,0/2] Handle alternate miss-completions

Message ID 20221116181725.2207544-1-jeroendb@google.com (mailing list archive)
Headers show
Series Handle alternate miss-completions | expand

Message

Jeroen de Borst Nov. 16, 2022, 6:17 p.m. UTC 
Some versions of the virtual NIC present miss-completions in
an alternative way. Let the diver handle these alternate completions
and announce this capability to the device.

The capability is announced uing a new AdminQ command that sends
driver information to the device. The device can refuse a driver
if it is lacking support for a capability, or it can adopt it's
behavior to work around it.

Changed in v4:
- Clarified new AdminQ command in cover letter
- Changed EOPNOTSUPP to ENOTSUPP to match device's response
Changed in v3:
- Rewording cover letter
- Added 'Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>'
Changes in v2:
- Changed the subject to include 'gve:'

Jeroen de Borst (2):
  gve: Adding a new AdminQ command to verify driver
  gve: Handle alternate miss completions

 drivers/net/ethernet/google/gve/gve.h         |  1 +
 drivers/net/ethernet/google/gve/gve_adminq.c  | 19 +++++++
 drivers/net/ethernet/google/gve/gve_adminq.h  | 51 ++++++++++++++++++
 .../net/ethernet/google/gve/gve_desc_dqo.h    |  5 ++
 drivers/net/ethernet/google/gve/gve_main.c    | 52 +++++++++++++++++++
 drivers/net/ethernet/google/gve/gve_tx_dqo.c  | 18 ++++---
 6 files changed, 140 insertions(+), 6 deletions(-)

Comments

Leon Romanovsky Nov. 17, 2022, 11:10 a.m. UTC | #1 
On Wed, Nov 16, 2022 at 10:17:23AM -0800, Jeroen de Borst wrote:
> Some versions of the virtual NIC present miss-completions in
> an alternative way. Let the diver handle these alternate completions
> and announce this capability to the device.
> 
> The capability is announced uing a new AdminQ command that sends
> driver information to the device. The device can refuse a driver
> if it is lacking support for a capability, or it can adopt it's
> behavior to work around it.
> 
> Changed in v4:
> - Clarified new AdminQ command in cover letter
> - Changed EOPNOTSUPP to ENOTSUPP to match device's response

If you rely on the error code, please use the correct one and
fix the driver to use EOPNOTSUPP and not ENOTSUPP.

Thanks