[v5,0/6] TUN/VirtioNet USO features support.

Message

Andrew Melnichenko Dec. 7, 2022, 11:35 a.m. UTC

Added new offloads for TUN devices TUN_F_USO4 and TUN_F_USO6.
Technically they enable NETIF_F_GSO_UDP_L4
(and only if USO4 & USO6 are set simultaneously).
It allows the transmission of large UDP packets.

UDP Segmentation Offload (USO/GSO_UDP_L4) - ability to split UDP packets
into several segments. It's similar to UFO, except it doesn't use IP
fragmentation. The drivers may push big packets and the NIC will split
them(or assemble them in case of receive), but in the case of VirtioNet
we just pass big UDP to the host. So we are freeing the driver from doing
the unnecessary job of splitting. The same thing for several guests
on one host, we can pass big packets between guests.

Different features USO4 and USO6 are required for qemu where Windows
guests can enable disable USO receives for IPv4 and IPv6 separately.
On the other side, Linux can't really differentiate USO4 and USO6, for now.
For now, to enable USO for TUN it requires enabling USO4 and USO6 together.
In the future, there would be a mechanism to control UDP_L4 GSO separately.

New types for virtio-net already in virtio-net specification:
https://github.com/oasis-tcs/virtio-spec/issues/120

Test it WIP Qemu https://github.com/daynix/qemu/tree/USOv3

Changes since v4 & RFC:
 * Fixed typo and refactored.
 * Tun USO offload refactored.
 * Add support for guest-to-guest segmentation offload (thx Jason).

Andrew Melnychenko (6):
  udp: allow header check for dodgy GSO_UDP_L4 packets.
  uapi/linux/if_tun.h: Added new offload types for USO4/6.
  driver/net/tun: Added features for USO.
  uapi/linux/virtio_net.h: Added USO types.
  linux/virtio_net.h: Support USO offload in vnet header.
  drivers/net/virtio_net.c: Added USO support.

 drivers/net/tap.c               | 10 ++++++++--
 drivers/net/tun.c               |  8 +++++++-
 drivers/net/virtio_net.c        | 19 +++++++++++++++----
 include/linux/virtio_net.h      |  9 +++++++++
 include/uapi/linux/if_tun.h     |  2 ++
 include/uapi/linux/virtio_net.h |  4 ++++
 net/ipv4/udp_offload.c          |  3 ++-
 net/ipv6/udp_offload.c          |  3 ++-
 8 files changed, 49 insertions(+), 9 deletions(-)

Comments

[e-mail] Dec. 12, 2022, 9:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Wed,  7 Dec 2022 13:35:52 +0200 you wrote:
> Added new offloads for TUN devices TUN_F_USO4 and TUN_F_USO6.
> Technically they enable NETIF_F_GSO_UDP_L4
> (and only if USO4 & USO6 are set simultaneously).
> It allows the transmission of large UDP packets.
> 
> UDP Segmentation Offload (USO/GSO_UDP_L4) - ability to split UDP packets
> into several segments. It's similar to UFO, except it doesn't use IP
> fragmentation. The drivers may push big packets and the NIC will split
> them(or assemble them in case of receive), but in the case of VirtioNet
> we just pass big UDP to the host. So we are freeing the driver from doing
> the unnecessary job of splitting. The same thing for several guests
> on one host, we can pass big packets between guests.
> 
> [...]

Here is the summary with links:
  - [v5,1/6] udp: allow header check for dodgy GSO_UDP_L4 packets.
    https://git.kernel.org/netdev/net-next/c/1fd54773c267
  - [v5,2/6] uapi/linux/if_tun.h: Added new offload types for USO4/6.
    https://git.kernel.org/netdev/net-next/c/b22bbdd17a5a
  - [v5,3/6] driver/net/tun: Added features for USO.
    https://git.kernel.org/netdev/net-next/c/399e0827642f
  - [v5,4/6] uapi/linux/virtio_net.h: Added USO types.
    https://git.kernel.org/netdev/net-next/c/34061b348ae9
  - [v5,5/6] linux/virtio_net.h: Support USO offload in vnet header.
    https://git.kernel.org/netdev/net-next/c/860b7f27b8f7
  - [v5,6/6] drivers/net/virtio_net.c: Added USO support.
    https://git.kernel.org/netdev/net-next/c/418044e1de30

You are awesome, thank you!