mbox series

[net,v2,0/5] net: wangxun: Adjust code structure

Message ID 20221214064133.2424570-1-jiawenwu@trustnetic.com (mailing list archive)
Headers show
Series net: wangxun: Adjust code structure | expand

Message

Jiawen Wu Dec. 14, 2022, 6:41 a.m. UTC
Remove useless structs 'txgbe_hw' and 'ngbe_hw' make the codes clear.
And move the same codes which sets MAC address between txgbe and ngbe
to libwx.

Changelog:
v2:
  - Split patch v1 into separate patches
  - Fix unreasonable code logic in MAC address operations

Jiawen Wu (5):
  net: txgbe: Remove structure txgbe_hw
  net: ngbe: Remove structure ngbe_hw
  net: txgbe: Move defines into unified file
  net: ngbe: Move defines into unified file
  net: wangxun: Move MAC address handling to libwx

 drivers/net/ethernet/wangxun/libwx/wx_hw.c    | 116 +++++++++++-
 drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   5 +-
 drivers/net/ethernet/wangxun/libwx/wx_type.h  |  12 ++
 drivers/net/ethernet/wangxun/ngbe/ngbe.h      |  79 --------
 drivers/net/ethernet/wangxun/ngbe/ngbe_hw.c   |  21 +--
 drivers/net/ethernet/wangxun/ngbe/ngbe_hw.h   |   4 +-
 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 125 ++++---------
 drivers/net/ethernet/wangxun/ngbe/ngbe_type.h |  58 +++++-
 drivers/net/ethernet/wangxun/txgbe/txgbe.h    |  43 -----
 drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c |  36 ++--
 drivers/net/ethernet/wangxun/txgbe/txgbe_hw.h |   6 +-
 .../net/ethernet/wangxun/txgbe/txgbe_main.c   | 174 +++---------------
 .../net/ethernet/wangxun/txgbe/txgbe_type.h   |  22 ++-
 13 files changed, 296 insertions(+), 405 deletions(-)
 delete mode 100644 drivers/net/ethernet/wangxun/ngbe/ngbe.h
 delete mode 100644 drivers/net/ethernet/wangxun/txgbe/txgbe.h

Comments

Leon Romanovsky Dec. 14, 2022, 7:58 a.m. UTC | #1
On Wed, Dec 14, 2022 at 02:41:28PM +0800, Jiawen Wu wrote:
> Remove useless structs 'txgbe_hw' and 'ngbe_hw' make the codes clear.
> And move the same codes which sets MAC address between txgbe and ngbe
> to libwx.
> 
> Changelog:
> v2:
>   - Split patch v1 into separate patches
>   - Fix unreasonable code logic in MAC address operations
> 
> Jiawen Wu (5):
>   net: txgbe: Remove structure txgbe_hw
>   net: ngbe: Remove structure ngbe_hw
>   net: txgbe: Move defines into unified file
>   net: ngbe: Move defines into unified file
>   net: wangxun: Move MAC address handling to libwx
> 

From Jakub (copy/paste):
# Form letter - net-next is closed

We have already submitted the networking pull request to Linus
for v6.2 and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.

Please repost when net-next reopens after 6.2-rc1 is cut.

Thanks
Alexander Duyck Dec. 14, 2022, 4:44 p.m. UTC | #2
On Wed, 2022-12-14 at 14:41 +0800, Jiawen Wu wrote:
> Remove useless structs 'txgbe_hw' and 'ngbe_hw' make the codes clear.
> And move the same codes which sets MAC address between txgbe and ngbe
> to libwx.
> 
> 

I am assuming this is for "net-next", not net since this doesn't look
like fixes but more like a signficant refactoring change.

So you may want to change this to "PATCH net-next".

> Changelog:
> v2:
>   - Split patch v1 into separate patches
>   - Fix unreasonable code logic in MAC address operations
> 
> Jiawen Wu (5):
>   net: txgbe: Remove structure txgbe_hw
>   net: ngbe: Remove structure ngbe_hw
>   net: txgbe: Move defines into unified file
>   net: ngbe: Move defines into unified file
>   net: wangxun: Move MAC address handling to libwx
> 
>  drivers/net/ethernet/wangxun/libwx/wx_hw.c    | 116 +++++++++++-
>  drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   5 +-
>  drivers/net/ethernet/wangxun/libwx/wx_type.h  |  12 ++
>  drivers/net/ethernet/wangxun/ngbe/ngbe.h      |  79 --------
>  drivers/net/ethernet/wangxun/ngbe/ngbe_hw.c   |  21 +--
>  drivers/net/ethernet/wangxun/ngbe/ngbe_hw.h   |   4 +-
>  drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 125 ++++---------
>  drivers/net/ethernet/wangxun/ngbe/ngbe_type.h |  58 +++++-
>  drivers/net/ethernet/wangxun/txgbe/txgbe.h    |  43 -----
>  drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c |  36 ++--
>  drivers/net/ethernet/wangxun/txgbe/txgbe_hw.h |   6 +-
>  .../net/ethernet/wangxun/txgbe/txgbe_main.c   | 174 +++---------------
>  .../net/ethernet/wangxun/txgbe/txgbe_type.h   |  22 ++-
>  13 files changed, 296 insertions(+), 405 deletions(-)
>  delete mode 100644 drivers/net/ethernet/wangxun/ngbe/ngbe.h
>  delete mode 100644 drivers/net/ethernet/wangxun/txgbe/txgbe.h
>