mbox series

[ethtool,v2,0/3] Build fixes for older kernel headers and musl

Message ID 20230114163411.3290201-1-f.fainelli@gmail.com (mailing list archive)
Headers show
Series Build fixes for older kernel headers and musl | expand

Message

Florian Fainelli Jan. 14, 2023, 4:34 p.m. UTC 
Hi Michal,

These 3 patches fix build issues encountered in the 6.1 release with
either older kernel headers (pre v4.11) or with musl-libc.

In case you want to add a prebuilt toolchain with your release procedure
you can use those binaries:

https://github.com/Broadcom/stbgcc-8.3/releases/tag/stbgcc-8.3-0.4

Changes in v2:

- reworked the first commit to bring in if.h, this is a more invasive
  change but it allows us to drop the ALTIFNAMSIZ override and it might
  be easier to maintain moving forward

- reworked the third commit to avoid using non standard integer types

Florian Fainelli (3):
  uapi: Bring in if.h
  netlink: Fix maybe uninitialized 'meters' variable
  marvell.c: Fix build with musl-libc

 Makefile.am             |   6 +-
 internal.h              |   7 +-
 marvell.c               |  34 ++---
 netlink/parser.c        |   2 +-
 uapi/linux/hdlc/ioctl.h |  94 +++++++++++++
 uapi/linux/if.h         | 296 ++++++++++++++++++++++++++++++++++++++++
 6 files changed, 415 insertions(+), 24 deletions(-)
 create mode 100644 uapi/linux/hdlc/ioctl.h
 create mode 100644 uapi/linux/if.h

Comments

Florian Fainelli Jan. 23, 2023, 10:01 p.m. UTC | #1 
Hi Michal,

On 1/14/23 08:34, Florian Fainelli wrote:
> Hi Michal,
> 
> These 3 patches fix build issues encountered in the 6.1 release with
> either older kernel headers (pre v4.11) or with musl-libc.
> 
> In case you want to add a prebuilt toolchain with your release procedure
> you can use those binaries:
> 
> https://github.com/Broadcom/stbgcc-8.3/releases/tag/stbgcc-8.3-0.4
> 
> Changes in v2:
> 
> - reworked the first commit to bring in if.h, this is a more invasive
>    change but it allows us to drop the ALTIFNAMSIZ override and it might
>    be easier to maintain moving forward
> 
> - reworked the third commit to avoid using non standard integer types

Any feedback on whether you prefer this version versus the v1?
Michal Kubecek Jan. 24, 2023, 8:39 a.m. UTC | #2 
On Mon, Jan 23, 2023 at 02:01:16PM -0800, Florian Fainelli wrote:
> Hi Michal,
> 
> On 1/14/23 08:34, Florian Fainelli wrote:
> > Hi Michal,
> > 
> > These 3 patches fix build issues encountered in the 6.1 release with
> > either older kernel headers (pre v4.11) or with musl-libc.
> > 
> > In case you want to add a prebuilt toolchain with your release procedure
> > you can use those binaries:
> > 
> > https://github.com/Broadcom/stbgcc-8.3/releases/tag/stbgcc-8.3-0.4
> > 
> > Changes in v2:
> > 
> > - reworked the first commit to bring in if.h, this is a more invasive
> >    change but it allows us to drop the ALTIFNAMSIZ override and it might
> >    be easier to maintain moving forward
> > 
> > - reworked the third commit to avoid using non standard integer types
> 
> Any feedback on whether you prefer this version versus the v1?

I like v2 more and unless I run into some trouble with it, I'm going to
merge it this week with the rest of the backlog.

Michal