mbox series

[net-next,0/2] Add additional phydev locks

Message ID 20230217030714.1249009-1-andrew@lunn.ch (mailing list archive)
Headers show
Series Add additional phydev locks | expand

Message

Andrew Lunn Feb. 17, 2023, 3:07 a.m. UTC 
The phydev lock should be held when accessing members of phydev, or
calling into the driver. Some of the phy_ethtool_ functions are
missing locks. Add them. To avoid deadlock the marvell driver is
modified since it calls one of the functions which gain locks, which
would result in a deadlock.

The missing locks have not caused noticeable issues, so these patches
are for net-next.

Andrew Lunn (2):
  net: phy: marvell: Use the unlocked genphy_c45_ethtool_get_eee()
  net: phy: Add locks to ethtool functions

 drivers/net/phy/marvell.c |  2 +-
 drivers/net/phy/phy.c     | 84 ++++++++++++++++++++++++++++++---------
 drivers/net/usb/lan78xx.c |  2 -
 3 files changed, 67 insertions(+), 21 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 20, 2023, 10:10 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 17 Feb 2023 04:07:12 +0100 you wrote:
> The phydev lock should be held when accessing members of phydev, or
> calling into the driver. Some of the phy_ethtool_ functions are
> missing locks. Add them. To avoid deadlock the marvell driver is
> modified since it calls one of the functions which gain locks, which
> would result in a deadlock.
> 
> The missing locks have not caused noticeable issues, so these patches
> are for net-next.
> 
> [...]

Here is the summary with links:
  - [=PATCH,net-next,1/2] net: phy: marvell: Use the unlocked genphy_c45_ethtool_get_eee()
    https://git.kernel.org/netdev/net-next/c/3365777a6a22
  - [=PATCH,net-next,2/2] net: phy: Add locks to ethtool functions
    https://git.kernel.org/netdev/net-next/c/2f987d486610

You are awesome, thank you!