mbox series

[net,v2,0/3] net/sched: fix action bind logic

Message ID 20230227182256.275816-1-pctammela@mojatatu.com (mailing list archive)
Headers show
Series net/sched: fix action bind logic | expand

Message

Pedro Tammela Feb. 27, 2023, 6:22 p.m. UTC
Some actions are not handling the case where an action can be created and bound to a
filter independently. These actions are checking for parameters only passed
in the netlink message for create/change/replace, which then errors out
for valid uses like:
tc filter ... action pedit index 1

In the iproute2 side, we saw a couple of actions with their parsers
broken when passing "index 1" as the only action argument, while the kernel
side accepted it correctly. We fixed those as well.

v1->v2:
- Missed clean up pointed out by Simon

Pedro Tammela (3):
  net/sched: act_pedit: fix action bind logic
  net/sched: act_mpls: fix action bind logic
  net/sched: act_sample: fix action bind logic

 net/sched/act_mpls.c   | 66 +++++++++++++++++++++++-------------------
 net/sched/act_pedit.c  | 58 ++++++++++++++++++++-----------------
 net/sched/act_sample.c | 11 +++++--
 3 files changed, 77 insertions(+), 58 deletions(-)