[v5,net-next,0/9] Add kernel tc-mqprio and tc-taprio support for preemptible traffic classes

Message

Vladimir Oltean April 11, 2023, 6:01 p.m. UTC

The last RFC in August 2022 contained a proposal for the UAPI of both
TSN standards which together form Frame Preemption (802.1Q and 802.3):
https://lore.kernel.org/netdev/[e-mail]/

It wasn't clear at the time whether the 802.1Q portion of Frame Preemption
should be exposed via the tc qdisc (mqprio, taprio) or via some other
layer (perhaps also ethtool like the 802.3 portion, or dcbnl), even
though the options were discussed extensively, with pros and cons:
https://lore.kernel.org/netdev/[e-mail]/

So the 802.3 portion got submitted separately and finally was accepted:
https://lore.kernel.org/netdev/[e-mail]/

leaving the only remaining question: how do we expose the 802.1Q bits?

This series proposes that we use the Qdisc layer, through separate
(albeit very similar) UAPI in mqprio and taprio, and that both these
Qdiscs pass the information down to the offloading device driver through
the common mqprio offload structure (which taprio also passes).

An implementation is provided for the NXP LS1028A on-board Ethernet
endpoint (enetc). Previous versions also contained support for its
embedded switch (felix), but this needs more work and will be submitted
separately.

Changes in v5:
- don't initialize tb twice, nla_parse_nested() does it
- use NL_REQ_ATTR_CHECK() and NL_SET_ERR_MSG_ATTR() for
  TCA_MQPRIO_TC_ENTRY_INDEX

v4 at:
https://lore.kernel.org/netdev/[e-mail]/

Changes in v4:
- removed felix driver support

Changes in v3:
- fixed build error caused by "default" switch case with no code
- reordered patches: bug fix first, driver changes all at the end
- changed links from patchwork to lore
- passed extack down to ndo_setup_tc() for mqprio and taprio, and made
  use of it in ocelot

v2 at:
https://lore.kernel.org/netdev/[e-mail]/

Changes in v2:
- add missing EXPORT_SYMBOL_GPL(ethtool_dev_mm_supported)
- slightly reword some commit messages
- move #include <linux/ethtool_netlink.h> to the respective patch in
  mqprio
- remove self-evident comment "only for dump and offloading" in mqprio

v1 at:
https://lore.kernel.org/netdev/[e-mail]/

Vladimir Oltean (9):
  net: ethtool: create and export ethtool_dev_mm_supported()
  net/sched: mqprio: simplify handling of nlattr portion of TCA_OPTIONS
  net/sched: mqprio: add extack to mqprio_parse_nlattr()
  net/sched: mqprio: add an extack message to mqprio_parse_opt()
  net/sched: pass netlink extack to mqprio and taprio offload
  net/sched: mqprio: allow per-TC user input of FP adminStatus
  net/sched: taprio: allow per-TC user input of FP adminStatus
  net: enetc: rename "mqprio" to "qopt"
  net: enetc: add support for preemptible traffic classes

 drivers/net/ethernet/freescale/enetc/enetc.c  |  31 ++-
 drivers/net/ethernet/freescale/enetc/enetc.h  |   1 +
 .../net/ethernet/freescale/enetc/enetc_hw.h   |   4 +
 include/linux/ethtool_netlink.h               |   6 +
 include/net/pkt_sched.h                       |   3 +
 include/uapi/linux/pkt_sched.h                |  17 ++
 net/ethtool/mm.c                              |  23 +++
 net/sched/sch_mqprio.c                        | 188 +++++++++++++++---
 net/sched/sch_mqprio_lib.c                    |  14 ++
 net/sched/sch_mqprio_lib.h                    |   2 +
 net/sched/sch_taprio.c                        |  77 +++++--
 11 files changed, 324 insertions(+), 42 deletions(-)

Comments

[e-mail] April 14, 2023, 5:30 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Tue, 11 Apr 2023 21:01:48 +0300 you wrote:
> The last RFC in August 2022 contained a proposal for the UAPI of both
> TSN standards which together form Frame Preemption (802.1Q and 802.3):
> https://lore.kernel.org/netdev/[e-mail]/
> 
> It wasn't clear at the time whether the 802.1Q portion of Frame Preemption
> should be exposed via the tc qdisc (mqprio, taprio) or via some other
> layer (perhaps also ethtool like the 802.3 portion, or dcbnl), even
> though the options were discussed extensively, with pros and cons:
> https://lore.kernel.org/netdev/[e-mail]/
> 
> [...]

Here is the summary with links:
  - [v5,net-next,1/9] net: ethtool: create and export ethtool_dev_mm_supported()
    https://git.kernel.org/netdev/net-next/c/d54151aa0f4b
  - [v5,net-next,2/9] net/sched: mqprio: simplify handling of nlattr portion of TCA_OPTIONS
    https://git.kernel.org/netdev/net-next/c/3dd0c16ec93e
  - [v5,net-next,3/9] net/sched: mqprio: add extack to mqprio_parse_nlattr()
    https://git.kernel.org/netdev/net-next/c/57f21bf85400
  - [v5,net-next,4/9] net/sched: mqprio: add an extack message to mqprio_parse_opt()
    https://git.kernel.org/netdev/net-next/c/ab277d2084ba
  - [v5,net-next,5/9] net/sched: pass netlink extack to mqprio and taprio offload
    https://git.kernel.org/netdev/net-next/c/c54876cd5961
  - [v5,net-next,6/9] net/sched: mqprio: allow per-TC user input of FP adminStatus
    https://git.kernel.org/netdev/net-next/c/f62af20bed2d
  - [v5,net-next,7/9] net/sched: taprio: allow per-TC user input of FP adminStatus
    https://git.kernel.org/netdev/net-next/c/a721c3e54b80
  - [v5,net-next,8/9] net: enetc: rename "mqprio" to "qopt"
    https://git.kernel.org/netdev/net-next/c/50764da37cbe
  - [v5,net-next,9/9] net: enetc: add support for preemptible traffic classes
    https://git.kernel.org/netdev/net-next/c/01e23b2b3bad

You are awesome, thank you!