mbox series

[net-next,v5,0/5] net/sched: act_pedit: minor improvements

Message ID 20230421212516.406726-1-pctammela@mojatatu.com (mailing list archive)
Headers show
Series net/sched: act_pedit: minor improvements | expand

Message

Pedro Tammela April 21, 2023, 9:25 p.m. UTC 
This series aims to improve the code and usability of act_pedit for
netlink users.

Patches 1-2 improves error reporting for extended keys parsing with extack.

Patch 3 checks the static offsets a priori on create/update. Currently,
this is done at the datapath for both static and runtime offsets.

Patch 4 removes a check from the datapath which is redundant since the
netlink parsing validates the key types.

Patch 5 changes the 'pr_info()' calls in the datapath to rate limited
versions.

v4->v5: Address suggestions by Jakub.
v3->v4: Break the old patch 1 into two patches.
v2->v3: Propagate nl_parse errors in patch 1 like the original version.
v1->v2: Added patch 3 to the series as discussed with Simon.

Pedro Tammela (5):
  net/sched: act_pedit: use NLA_POLICY for parsing 'ex' keys
  net/sched: act_pedit: use extack in 'ex' parsing errors
  net/sched: act_pedit: check static offsets a priori
  net/sched: act_pedit: remove extra check for key type
  net/sched: act_pedit: rate limit datapath messages

 net/sched/act_pedit.c | 85 ++++++++++++++++++++-----------------------
 1 file changed, 40 insertions(+), 45 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org April 23, 2023, 5:40 p.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 21 Apr 2023 18:25:12 -0300 you wrote:
> This series aims to improve the code and usability of act_pedit for
> netlink users.
> 
> Patches 1-2 improves error reporting for extended keys parsing with extack.
> 
> Patch 3 checks the static offsets a priori on create/update. Currently,
> this is done at the datapath for both static and runtime offsets.
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/5] net/sched: act_pedit: use NLA_POLICY for parsing 'ex' keys
    https://git.kernel.org/netdev/net-next/c/5036034572b7
  - [net-next,v5,2/5] net/sched: act_pedit: use extack in 'ex' parsing errors
    https://git.kernel.org/netdev/net-next/c/0c83c5210e18
  - [net-next,v5,3/5] net/sched: act_pedit: check static offsets a priori
    https://git.kernel.org/netdev/net-next/c/e1201bc781c2
  - [net-next,v5,4/5] net/sched: act_pedit: remove extra check for key type
    https://git.kernel.org/netdev/net-next/c/577140180ba2
  - [net-next,v5,5/5] net/sched: act_pedit: rate limit datapath messages
    https://git.kernel.org/netdev/net-next/c/e3c9673e2f6e

You are awesome, thank you!