[net-next,v5,0/4] net/sched: cleanup parsing prints in htb and qfq

Message

Pedro Tammela April 22, 2023, 3:56 p.m. UTC

These two qdiscs are still using prints on dmesg to report parsing
errors. Since the parsing code has access to extack, convert these error
messages to extack.

QFQ also had the opportunity to remove some redundant code in the
parameters parsing by transforming some attributes into parsing
policies.

v4->v5: Rebased
v3->v4: Drop 'BITification' as suggested by Eric
v2->v3: Address suggestions by Jakub and Simon
v1->v2: Address suggestions by Jakub

Pedro Tammela (4):
  net/sched: sch_htb: use extack on errors messages
  net/sched: sch_qfq: use extack on errors messages
  net/sched: sch_qfq: refactor parsing of netlink parameters
  selftests: tc-testing: add more tests for sch_qfq

 net/sched/sch_htb.c                           | 17 ++---
 net/sched/sch_qfq.c                           | 34 +++++----
 .../tc-testing/tc-tests/qdiscs/qfq.json       | 72 +++++++++++++++++++
 3 files changed, 97 insertions(+), 26 deletions(-)

Comments

[e-mail] April 24, 2023, 10:10 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <[e-mail]>:

On Sat, 22 Apr 2023 12:56:08 -0300 you wrote:
> These two qdiscs are still using prints on dmesg to report parsing
> errors. Since the parsing code has access to extack, convert these error
> messages to extack.
> 
> QFQ also had the opportunity to remove some redundant code in the
> parameters parsing by transforming some attributes into parsing
> policies.
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/4] net/sched: sch_htb: use extack on errors messages
    https://git.kernel.org/netdev/net/c/807cfded92b0
  - [net-next,v5,2/4] net/sched: sch_qfq: use extack on errors messages
    https://git.kernel.org/netdev/net/c/c69a9b023f65
  - [net-next,v5,3/4] net/sched: sch_qfq: refactor parsing of netlink parameters
    https://git.kernel.org/netdev/net/c/25369891fcef
  - [net-next,v5,4/4] selftests: tc-testing: add more tests for sch_qfq
    https://git.kernel.org/netdev/net/c/7eb060a51a3b

You are awesome, thank you!