| Message ID | 20230502043150.17097-1-glipus@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | New NDO methods ndo_hwtstamp_get/set | expand |
On Mon, 1 May 2023 22:31:45 -0600 Maxim Georgiev wrote: > This stack of patches introduces a couple of new NDO methods, > ndo_hwtstamp_get and ndo_hwtstamp_set. These new methods can be > implemented by NIC drivers to allow setting and querying HW > timestamp settings. Drivers implementing these methods will > not need to handle SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTLs. > The new NDO methods will handle copying request parameters > between user address space and kernel space. Maxim, any ETA on the next version? Should we let someone take over? It's been over a month since v6 posting.
On Tue, Jun 20, 2023 at 07:23:13PM -0700, Jakub Kicinski wrote: > On Mon, 1 May 2023 22:31:45 -0600 Maxim Georgiev wrote: > > This stack of patches introduces a couple of new NDO methods, > > ndo_hwtstamp_get and ndo_hwtstamp_set. These new methods can be > > implemented by NIC drivers to allow setting and querying HW > > timestamp settings. Drivers implementing these methods will > > not need to handle SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTLs. > > The new NDO methods will handle copying request parameters > > between user address space and kernel space. > > Maxim, any ETA on the next version? Should we let someone take over? > It's been over a month since v6 posting. Assuming Maxim does not respond, can I try to take over? I may have some time this weekend to play with some PTP related stuff.
On Sat, Jul 1, 2023 at 4:03 AM Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > On Tue, Jun 20, 2023 at 07:23:13PM -0700, Jakub Kicinski wrote: > > On Mon, 1 May 2023 22:31:45 -0600 Maxim Georgiev wrote: > > > This stack of patches introduces a couple of new NDO methods, > > > ndo_hwtstamp_get and ndo_hwtstamp_set. These new methods can be > > > implemented by NIC drivers to allow setting and querying HW > > > timestamp settings. Drivers implementing these methods will > > > not need to handle SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTLs. > > > The new NDO methods will handle copying request parameters > > > between user address space and kernel space. > > > > Maxim, any ETA on the next version? Should we let someone take over? > > It's been over a month since v6 posting. > > Assuming Maxim does not respond, can I try to take over? I may have some > time this weekend to play with some PTP related stuff. Yes, it looks like I hold back everyone. Vladimir, you are welcome to take over this patch stack.
This stack of patches introduces a couple of new NDO methods, ndo_hwtstamp_get and ndo_hwtstamp_set. These new methods can be implemented by NIC drivers to allow setting and querying HW timestamp settings. Drivers implementing these methods will not need to handle SIOCGHWTSTAMP/SIOCSHWTSTAMP IOCTLs. The new NDO methods will handle copying request parameters between user address space and kernel space. Maxim Georgiev (5): net: Add NDOs for hardware timestamp get/set net: Add ifreq pointer field to kernel_hwtstamp_config structure vlan/macvlan: Add ndo_hwtstamp_get/set support to vlan/macvlan code path bond: Add ndo_hwtstamp_get/set support to bond driver netdevsim: Implement ndo_hwtstamp_get/set methods in netdevsim driver drivers/net/bonding/bond_main.c | 106 +++++++++++++++++----------- drivers/net/macvlan.c | 35 ++++------ drivers/net/netdevsim/ethtool.c | 11 +++ drivers/net/netdevsim/netdev.c | 24 +++++++ drivers/net/netdevsim/netdevsim.h | 1 + include/linux/net_tstamp.h | 17 +++++ include/linux/netdevice.h | 22 ++++++ net/8021q/vlan_dev.c | 28 ++++++-- net/core/dev_ioctl.c | 110 +++++++++++++++++++++++++++++- 9 files changed, 286 insertions(+), 68 deletions(-)