| Message ID | 20230526152348.70781-1-Parthiban.Veerasooran@microchip.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | microchip_t1s: Update on Microchip 10BASE-T1S PHY driver | expand |
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 26 May 2023 20:53:42 +0530 you wrote: > This patch series contain the below updates, > - Fixes on the Microchip LAN8670/1/2 10BASE-T1S PHYs support in the > net/phy/microchip_t1s.c driver. > - Adds support for the Microchip LAN8650/1 Rev.B0 10BASE-T1S Internal > PHYs in the net/phy/microchip_t1s.c driver. > > Changes: > v2: > - Updated cover letter contents. > - Modified driver description is more generic as it is common for all the > Microchip 10BASE-T1S PHYs. > - Replaced read-modify-write code with phy_modify_mmd function. > - Moved */ to the same line for the single line comments. > - Changed the type int to u16 for LAN865X Rev.B0 fixup registers > declaration. > - Changed all the comments starting letter to upper case for the > consistency. > - Removed return value check of phy_read_mmd and returned directly in the > last line of the function lan865x_revb0_indirect_read. > - Used reverse christmas notation wherever is possible. > - Used FIELD_PREP instead of << in all the places. > - Used 4 byte representation for all the register addresses and values > for consistency. > - Comment for indirect read is modified. > - Implemented "Reset Complete" status polling in config_init. > - Function lan865x_setup_cfgparam is split into multiple functions for > readability. > - Reference to AN1760 document is added in the comment. > - Removed interrupt disabling code as it is not needed. > - Provided meaningful macros for the LAN865X Rev.B0 indirect read > registers and control. > - Replaced 0x10 with BIT(4). > - Removed collision detection disable/enable code as it can be done with > a separate patch later. > > [...] Here is the summary with links: - [net-next,v4,1/6] net: phy: microchip_t1s: modify driver description to be more generic https://git.kernel.org/netdev/net-next/c/ca33db4a8602 - [net-next,v4,2/6] net: phy: microchip_t1s: replace read-modify-write code with phy_modify_mmd https://git.kernel.org/netdev/net-next/c/221a5344806c - [net-next,v4,3/6] net: phy: microchip_t1s: update LAN867x PHY supported revision number https://git.kernel.org/netdev/net-next/c/6f12765ecad3 - [net-next,v4,4/6] net: phy: microchip_t1s: fix reset complete status handling https://git.kernel.org/netdev/net-next/c/1d7650b8ce60 - [net-next,v4,5/6] net: phy: microchip_t1s: remove unnecessary interrupts disabling code https://git.kernel.org/netdev/net-next/c/b4010beb347d - [net-next,v4,6/6] net: phy: microchip_t1s: add support for Microchip LAN865x Rev.B0 PHYs https://git.kernel.org/netdev/net-next/c/972c6d834633 You are awesome, thank you!
This patch series contain the below updates, - Fixes on the Microchip LAN8670/1/2 10BASE-T1S PHYs support in the net/phy/microchip_t1s.c driver. - Adds support for the Microchip LAN8650/1 Rev.B0 10BASE-T1S Internal PHYs in the net/phy/microchip_t1s.c driver. Changes: v2: - Updated cover letter contents. - Modified driver description is more generic as it is common for all the Microchip 10BASE-T1S PHYs. - Replaced read-modify-write code with phy_modify_mmd function. - Moved */ to the same line for the single line comments. - Changed the type int to u16 for LAN865X Rev.B0 fixup registers declaration. - Changed all the comments starting letter to upper case for the consistency. - Removed return value check of phy_read_mmd and returned directly in the last line of the function lan865x_revb0_indirect_read. - Used reverse christmas notation wherever is possible. - Used FIELD_PREP instead of << in all the places. - Used 4 byte representation for all the register addresses and values for consistency. - Comment for indirect read is modified. - Implemented "Reset Complete" status polling in config_init. - Function lan865x_setup_cfgparam is split into multiple functions for readability. - Reference to AN1760 document is added in the comment. - Removed interrupt disabling code as it is not needed. - Provided meaningful macros for the LAN865X Rev.B0 indirect read registers and control. - Replaced 0x10 with BIT(4). - Removed collision detection disable/enable code as it can be done with a separate patch later. v3: - Comment for phy_modify_mmd() is extended to indicate that the write is not required if the register already has the required value. - Commit message is updated for the not supported hardware revisions 0x0007C160 (Rev.A0) and 0x0007C161 (Rev.B0) since they are never released to production. - Commit message is updated to indicate that the Reset Complete interrupt will be cleared when the STS2 register read is done. - Corrected the typo in the offset calculation comment. - Used reverse christmas notation for the local variable declarations. v4: - Reset complete block comment updated to describe the 5us sleep. - read-modify-write block comment modified and added reference to AN1699. - LAN8670/1/2 Rev.B1 and LAN8650/1 Rev.B0 details updated in Kconfig file. - Removed return value check of lan865x_setup_cfgparam() and returned directly in the last line of the function lan865x_revb0_config_init. Parthiban Veerasooran (6): net: phy: microchip_t1s: modify driver description to be more generic net: phy: microchip_t1s: replace read-modify-write code with phy_modify_mmd net: phy: microchip_t1s: update LAN867x PHY supported revision number net: phy: microchip_t1s: fix reset complete status handling net: phy: microchip_t1s: remove unnecessary interrupts disabling code net: phy: microchip_t1s: add support for Microchip LAN865x Rev.B0 PHYs drivers/net/phy/Kconfig | 5 +- drivers/net/phy/microchip_t1s.c | 274 ++++++++++++++++++++++++++------ 2 files changed, 224 insertions(+), 55 deletions(-)