| Message ID | 20230530091948.1408477-1-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | xstats for tc-taprio | expand |
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 30 May 2023 12:19:43 +0300 you wrote: > As a result of this discussion: > https://lore.kernel.org/intel-wired-lan/20230411055543.24177-1-muhammad.husaini.zulkifli@intel.com/ > > it became apparent that tc-taprio should make an effort to standardize > statistics counters related to the 802.1Qbv scheduling as implemented > by the NIC. I'm presenting here one counter suggested by the standard, > and one counter defined by the NXP ENETC controller from LS1028A. Both > counters are reported globally and per traffic class - drivers get > different callbacks for reporting both of these, and get to choose what > to report in both cases. > > [...] Here is the summary with links: - [net-next,1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats() https://git.kernel.org/netdev/net-next/c/dced11ef84fb - [net-next,2/5] net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum https://git.kernel.org/netdev/net-next/c/2d800bc500fb - [net-next,3/5] net/sched: taprio: add netlink reporting for offload statistics counters https://git.kernel.org/netdev/net-next/c/6c1adb650c8d - [net-next,4/5] net: enetc: refactor enetc_setup_tc_taprio() to have a switch/case for cmd https://git.kernel.org/netdev/net-next/c/5353599aa745 - [net-next,5/5] net: enetc: report statistics counters for taprio https://git.kernel.org/netdev/net-next/c/4802fca8d1af You are awesome, thank you!
As a result of this discussion: https://lore.kernel.org/intel-wired-lan/20230411055543.24177-1-muhammad.husaini.zulkifli@intel.com/ it became apparent that tc-taprio should make an effort to standardize statistics counters related to the 802.1Qbv scheduling as implemented by the NIC. I'm presenting here one counter suggested by the standard, and one counter defined by the NXP ENETC controller from LS1028A. Both counters are reported globally and per traffic class - drivers get different callbacks for reporting both of these, and get to choose what to report in both cases. The iproute2 counterpart is available here for testing: https://github.com/vladimiroltean/iproute2/commits/taprio-xstats Vladimir Oltean (5): net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats() net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum net/sched: taprio: add netlink reporting for offload statistics counters net: enetc: refactor enetc_setup_tc_taprio() to have a switch/case for cmd net: enetc: report statistics counters for taprio drivers/net/dsa/hirschmann/hellcreek.c | 14 ++- drivers/net/dsa/ocelot/felix_vsc9959.c | 4 +- drivers/net/dsa/sja1105/sja1105_tas.c | 7 +- .../net/ethernet/engleder/tsnep_selftests.c | 12 +- drivers/net/ethernet/engleder/tsnep_tc.c | 4 +- drivers/net/ethernet/freescale/enetc/enetc.c | 3 +- drivers/net/ethernet/freescale/enetc/enetc.h | 1 + .../net/ethernet/freescale/enetc/enetc_qos.c | 110 ++++++++++++++---- drivers/net/ethernet/intel/igc/igc_main.c | 13 ++- .../ethernet/microchip/lan966x/lan966x_tc.c | 10 +- .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 7 +- drivers/net/ethernet/ti/am65-cpsw-qos.c | 11 +- include/net/pkt_sched.h | 56 +++++++-- include/uapi/linux/pkt_sched.h | 10 ++ net/sched/sch_taprio.c | 90 ++++++++++++-- 15 files changed, 286 insertions(+), 66 deletions(-)