mbox series

[iwl-next,v2,0/2] iavf: make some functions static

Message ID 20230615110309.14698-1-przemyslaw.kitszel@intel.com (mailing list archive)
Headers show
Series iavf: make some functions static | expand

Message

Przemek Kitszel June 15, 2023, 11:03 a.m. UTC 
Turn functions that are used in just one translation unit to be static.
Remove all unused functions (but keep exported ones for now).

This series depends on three patches that are in Tony's queue, see [1],
[2], [3] - dependencies are just about avoiding trivial git conflicts.

[1] https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20230502152908.701880-1-ahmed.zaki@intel.com/
("iavf: remove mask from iavf_irq_enable_queues()")

[2] https://lore.kernel.org/intel-wired-lan/20230509111148.4608-3-dinghui@sangfor.com.cn/
("iavf: Fix out-of-bounds when setting channels on remove")

[3] https://lore.kernel.org/intel-wired-lan/20230605145226.1222225-2-mateusz.palczewski@intel.com/
("iavf: Wait for reset in callbacks which trigger it")

For third of those patches, I'm suspicious of git-format-patch generating
"bad" prerequisite-patch-id, it's stable across the runs and rebases,
but it's different than the one reported by git-patch-id
(= ea8d85f15350eff7a2aa4fdb0e2653d856b42184).
I don't know if anybody cares about those anyway.

v2 - typo fixed, links to prereqs for second patch.

Przemek Kitszel (2):
  iavf: remove some unused functions and pointless wrappers
  iavf: make functions static where possible

 drivers/net/ethernet/intel/iavf/iavf.h        | 10 -----
 drivers/net/ethernet/intel/iavf/iavf_alloc.h  |  3 +-
 drivers/net/ethernet/intel/iavf/iavf_common.c | 45 -------------------
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 34 ++++++--------
 drivers/net/ethernet/intel/iavf/iavf_osdep.h  |  9 ----
 .../net/ethernet/intel/iavf/iavf_prototype.h  |  5 ---
 drivers/net/ethernet/intel/iavf/iavf_txrx.c   | 43 +++++++++---------
 drivers/net/ethernet/intel/iavf/iavf_txrx.h   |  4 --
 8 files changed, 35 insertions(+), 118 deletions(-)


base-commit: fa0e21fa44438a0e856d42224bfa24641d37b979
prerequisite-patch-id: 141de8c9f97d59aa7df2481120f1d666f90420cb
prerequisite-patch-id: 6eb49686279d9b2046d6fe5c78a882025c87f3ff
prerequisite-patch-id: 2b1499c46b646b5402867deee8d40b73d752599a