mbox series

[v2,net,0/2] Fix PTP received on wrong port with bridged SJA1105 DSA

Message ID 20230627094207.3385231-1-vladimir.oltean@nxp.com (mailing list archive)
Headers show
Series Fix PTP received on wrong port with bridged SJA1105 DSA | expand

Message

Vladimir Oltean June 27, 2023, 9:42 a.m. UTC 
Since the changes were made to tag_8021q to support imprecise RX for
bridged ports, the tag_sja1105 driver still prefers the source port
information deduced from the VLAN headers for link-local traffic, even
though the switch can theoretically do better and report the precise
source port.

The problem is that the tagger doesn't know when to trust one source of
information over another, because the INCL_SRCPT option (to "tag" link
local frames) is sometimes enabled and sometimes it isn't.

The first patch makes the switch provide the hardware tag for link local
traffic under all circumstances, and the second patch makes the tagger
always use that hardware tag as primary source of information for link
local packets.

Vladimir Oltean (2):
  net: dsa: sja1105: always enable the INCL_SRCPT option
  net: dsa: tag_sja1105: always prefer source port information from
    INCL_SRCPT

 drivers/net/dsa/sja1105/sja1105_main.c |  9 ++----
 net/dsa/tag_sja1105.c                  | 38 ++++++++++++++++++++------
 2 files changed, 31 insertions(+), 16 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org June 29, 2023, 12:50 p.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 27 Jun 2023 12:42:05 +0300 you wrote:
> Since the changes were made to tag_8021q to support imprecise RX for
> bridged ports, the tag_sja1105 driver still prefers the source port
> information deduced from the VLAN headers for link-local traffic, even
> though the switch can theoretically do better and report the precise
> source port.
> 
> The problem is that the tagger doesn't know when to trust one source of
> information over another, because the INCL_SRCPT option (to "tag" link
> local frames) is sometimes enabled and sometimes it isn't.
> 
> [...]

Here is the summary with links:
  - [v2,net,1/2] net: dsa: sja1105: always enable the INCL_SRCPT option
    https://git.kernel.org/netdev/net/c/b4638af8885a
  - [v2,net,2/2] net: dsa: tag_sja1105: always prefer source port information from INCL_SRCPT
    https://git.kernel.org/netdev/net/c/c1ae02d87689

You are awesome, thank you!