mbox series

[net-next,00/10] mptcp: Prepare MPTCP packet scheduler for BPF extension

Message ID 20230821-upstream-net-next-20230818-v1-0-0c860fb256a8@kernel.org (mailing list archive)
Headers show
Series mptcp: Prepare MPTCP packet scheduler for BPF extension | expand

Message

Mat Martineau Aug. 21, 2023, 10:25 p.m. UTC
The kernel's MPTCP packet scheduler has, to date, been a one-size-fits
all algorithm that is hard-coded. It attempts to balance latency and
throughput when transmitting data across multiple TCP subflows, and has
some limited tunability through sysctls. It has been a long-term goal of
the Linux MPTCP community to support customizable packet schedulers for
use cases that need to make different trade-offs regarding latency,
throughput, redundancy, and other metrics. BPF is well-suited for
configuring customized, per-packet scheduling decisions without having
to modify the kernel or manage out-of-tree kernel modules.

The first steps toward implementing BPF packet schedulers are to update
the existing MPTCP transmit loops to allow more flexible scheduling
decisions, and to add infrastructure for swappable packet schedulers.
The existing scheduling algorithm remains the default. BPF-related
changes will be in a future patch series.

This code has been in the MPTCP development tree for quite a while,
undergoing testing in our CI and community.

Patches 1 and 2 refactor the transmit code and do some related cleanup.

Patches 3-9 add infrastructure for registering and calling multiple
schedulers.

Patch 10 connects the in-kernel default scheduler to the new
infrastructure.

Signed-off-by: Mat Martineau <martineau@kernel.org>
---
Geliang Tang (10):
      mptcp: refactor push_pending logic
      mptcp: drop last_snd and MPTCP_RESET_SCHEDULER
      mptcp: add struct mptcp_sched_ops
      mptcp: add a new sysctl scheduler
      mptcp: add sched in mptcp_sock
      mptcp: add scheduled in mptcp_subflow_context
      mptcp: add scheduler wrappers
      mptcp: use get_send wrapper
      mptcp: use get_retrans wrapper
      mptcp: register default scheduler

 Documentation/networking/mptcp-sysctl.rst |   8 +
 include/net/mptcp.h                       |  21 +++
 net/mptcp/Makefile                        |   2 +-
 net/mptcp/ctrl.c                          |  14 ++
 net/mptcp/pm.c                            |   9 +-
 net/mptcp/pm_netlink.c                    |   3 -
 net/mptcp/protocol.c                      | 277 +++++++++++++++++-------------
 net/mptcp/protocol.h                      |  18 +-
 net/mptcp/sched.c                         | 173 +++++++++++++++++++
 9 files changed, 393 insertions(+), 132 deletions(-)
---
base-commit: 7eb6deb3f55678216a6a0e956846c04958093ea5
change-id: 20230818-upstream-net-next-20230818-2d1199315465

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 23, 2023, 1:40 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 21 Aug 2023 15:25:11 -0700 you wrote:
> The kernel's MPTCP packet scheduler has, to date, been a one-size-fits
> all algorithm that is hard-coded. It attempts to balance latency and
> throughput when transmitting data across multiple TCP subflows, and has
> some limited tunability through sysctls. It has been a long-term goal of
> the Linux MPTCP community to support customizable packet schedulers for
> use cases that need to make different trade-offs regarding latency,
> throughput, redundancy, and other metrics. BPF is well-suited for
> configuring customized, per-packet scheduling decisions without having
> to modify the kernel or manage out-of-tree kernel modules.
> 
> [...]

Here is the summary with links:
  - [net-next,01/10] mptcp: refactor push_pending logic
    https://git.kernel.org/netdev/net-next/c/c5b4297dee91
  - [net-next,02/10] mptcp: drop last_snd and MPTCP_RESET_SCHEDULER
    https://git.kernel.org/netdev/net-next/c/ebc1e08f01eb
  - [net-next,03/10] mptcp: add struct mptcp_sched_ops
    https://git.kernel.org/netdev/net-next/c/740ebe35bd3f
  - [net-next,04/10] mptcp: add a new sysctl scheduler
    https://git.kernel.org/netdev/net-next/c/e3b2870b6d22
  - [net-next,05/10] mptcp: add sched in mptcp_sock
    https://git.kernel.org/netdev/net-next/c/1730b2b2c5a5
  - [net-next,06/10] mptcp: add scheduled in mptcp_subflow_context
    https://git.kernel.org/netdev/net-next/c/fce68b03086f
  - [net-next,07/10] mptcp: add scheduler wrappers
    https://git.kernel.org/netdev/net-next/c/07336a87fe87
  - [net-next,08/10] mptcp: use get_send wrapper
    https://git.kernel.org/netdev/net-next/c/0fa1b3783a17
  - [net-next,09/10] mptcp: use get_retrans wrapper
    https://git.kernel.org/netdev/net-next/c/ee2708aedad0
  - [net-next,10/10] mptcp: register default scheduler
    https://git.kernel.org/netdev/net-next/c/ed1ad86b8527

You are awesome, thank you!