| Message ID | 20231017063419.925266-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: fec: Fix device_get_match_data usage | expand |
On Tue, Oct 17, 2023 at 1:34 AM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > Hi, > > this is v2 adressing the regression introduced by commit b0377116decd > ("net: ethernet: Use device_get_match_data()"). > > Changes in v2: > * Update the OF device data pointers to the actual device specific struct > fec_devinfo. > * Add Patch 2 (unrelated to regression) to remove platform IDs for > non-Coldfire > > You could also remove the (!dev_info) case for Coldfire as this platform > has no quirks. But IMHO this should be kept as long as Coldfire platform > data is supported. > > Best regards, > Alexander > > Alexander Stein (2): > net: fec: Fix device_get_match_data usage > net: fec: Remove non-Coldfire platform IDs > > drivers/net/ethernet/freescale/fec_main.c | 63 ++++------------------- > 1 file changed, 10 insertions(+), 53 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org> Thanks for fixing this. Rob
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 17 Oct 2023 08:34:17 +0200 you wrote: > Hi, > > this is v2 adressing the regression introduced by commit b0377116decd > ("net: ethernet: Use device_get_match_data()"). > > Changes in v2: > * Update the OF device data pointers to the actual device specific struct > fec_devinfo. > * Add Patch 2 (unrelated to regression) to remove platform IDs for > non-Coldfire > > [...] Here is the summary with links: - [v2,1/2] net: fec: Fix device_get_match_data usage https://git.kernel.org/netdev/net-next/c/e6809dba5ec3 - [v2,2/2] net: fec: Remove non-Coldfire platform IDs https://git.kernel.org/netdev/net-next/c/50254bfe1438 You are awesome, thank you!
Hi, this is v2 adressing the regression introduced by commit b0377116decd ("net: ethernet: Use device_get_match_data()"). Changes in v2: * Update the OF device data pointers to the actual device specific struct fec_devinfo. * Add Patch 2 (unrelated to regression) to remove platform IDs for non-Coldfire You could also remove the (!dev_info) case for Coldfire as this platform has no quirks. But IMHO this should be kept as long as Coldfire platform data is supported. Best regards, Alexander Alexander Stein (2): net: fec: Fix device_get_match_data usage net: fec: Remove non-Coldfire platform IDs drivers/net/ethernet/freescale/fec_main.c | 63 ++++------------------- 1 file changed, 10 insertions(+), 53 deletions(-)