mbox series

[net-next,0/2] net/sched: cls_u32: use proper refcounts

Message ID 20231114141856.974326-1-pctammela@mojatatu.com (mailing list archive)
Headers show
Series net/sched: cls_u32: use proper refcounts | expand

Message

Pedro Tammela Nov. 14, 2023, 2:18 p.m. UTC 
In u32 we are open coding refcounts of hashtables with integers which is
far from ideal. Update those with proper refcount and add a couple of
tests to tdc that exercise the refcounts explicitly.

Pedro Tammela (2):
  net/sched: cls_u32: replace int refcounts with proper refcounts
  selftests/tc-testing: add hashtable tests for u32

 net/sched/cls_u32.c                           | 36 ++++++------
 .../tc-testing/tc-tests/filters/u32.json      | 57 +++++++++++++++++++
 2 files changed, 75 insertions(+), 18 deletions(-)

Comments

Jamal Hadi Salim Nov. 14, 2023, 2:50 p.m. UTC | #1 
On Tue, Nov 14, 2023 at 9:20 AM Pedro Tammela <pctammela@mojatatu.com> wrote:
>
> In u32 we are open coding refcounts of hashtables with integers which is
> far from ideal. Update those with proper refcount and add a couple of
> tests to tdc that exercise the refcounts explicitly.
>

To the series...
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

> Pedro Tammela (2):
>   net/sched: cls_u32: replace int refcounts with proper refcounts
>   selftests/tc-testing: add hashtable tests for u32
>
>  net/sched/cls_u32.c                           | 36 ++++++------
>  .../tc-testing/tc-tests/filters/u32.json      | 57 +++++++++++++++++++
>  2 files changed, 75 insertions(+), 18 deletions(-)
>
> --
> 2.40.1
>
patchwork-bot+netdevbpf@kernel.org Nov. 19, 2023, 3:40 a.m. UTC | #2 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 14 Nov 2023 11:18:54 -0300 you wrote:
> In u32 we are open coding refcounts of hashtables with integers which is
> far from ideal. Update those with proper refcount and add a couple of
> tests to tdc that exercise the refcounts explicitly.
> 
> Pedro Tammela (2):
>   net/sched: cls_u32: replace int refcounts with proper refcounts
>   selftests/tc-testing: add hashtable tests for u32
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net/sched: cls_u32: replace int refcounts with proper refcounts
    https://git.kernel.org/netdev/net-next/c/6b78debe1c07
  - [net-next,2/2] selftests/tc-testing: add hashtable tests for u32
    https://git.kernel.org/netdev/net-next/c/54293e4d6a62

You are awesome, thank you!