From patchwork Tue Nov 28 17:38:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13471467 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E54CADC for ; Tue, 28 Nov 2023 09:38:54 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r822j-00064O-V5; Tue, 28 Nov 2023 18:38:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r822f-00CECZ-R0; Tue, 28 Nov 2023 18:38:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r822f-00AIhW-H2; Tue, 28 Nov 2023 18:38:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Roger Quadros Cc: Siddharth Vadapalli , Dan Carpenter , netdev@vger.kernel.org, kernel@pengutronix.de, Ravi Gunasekaran , Jesse Brandeburg , Rob Herring , Yunsheng Lin , Marek Majtyka , linux-omap@vger.kernel.org, Kumar Kartikeya Dwivedi , Stanislav Fomichev , Simon Horman , Jeff Johnson , Wei Fang , Nick Child , Christian Marangi Subject: [PATCH net-next v2 0/4] net: ethernet: Convert to platform remove callback returning void Date: Tue, 28 Nov 2023 18:38:24 +0100 Message-ID: <20231128173823.867512-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1652; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=qcEdChFt8Lt8VDlYj26EFx9vmoZ6FKJwGC9mdw0KmLc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlZiWQd365uxpTW7I8bQ7foyRVSPmc1LIReTize +O0ViiGM/OJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZWYlkAAKCRCPgPtYfRL+ Tj0sB/9sJ19oqpZ1ThW/3kLfDa9kujMph5iXATKcA8NUC1ygaV/wDzLIULcPuskxesUejZKHa9Z sTe6UukWQv+ZPdkAUyzaRyz1v4EsXIez2NHHClTfz3KiKDDMdgNMHos9gbAXd11vfuakI63xkoL oJqSr2MxIErTTgF5iezSRiSM/BIKFUSU1ooztcVyb3N3wodQOlSHjN4dIiWNdiW2GAOPF5jp/Z5 ai0Yppj+rUjQiO6NgPKBvaOOMhj/5t1it3qaLLZuQq/VQHOvyUHB/RTOTCjizPQxUket0dcjTDV HgdBJ7a7QovCNqWJ6wiChx2UEMurR8ht0vDots7Pn6bxrenK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Hello, in (implicit) v1 of this series (https://lore.kernel.org/netdev/20231117091655.872426-1-u.kleine-koenig@pengutronix.de) I tried to address the resource leaks in the three cpsw drivers. However this is hard to get right without being able to test the changes. So here comes a series that just converts all drivers below drivers/net/ethernet to use .remove_new() and adds a comment about the potential leaks for someone else to fix the problem. See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. The TL;DR; is to prevent bugs like the three noticed here. Note this series results in no change of behaviour apart from improving the error message for the three cpsw drivers from remove callback returned a non-zero value. This will be ignored. to Failed to resume device (-ESOMETHING) . Best regards Uwe Uwe Kleine-König (4): net: ethernet: ti: am65-cpsw: Convert to platform remove callback returning void net: ethernet: ti: cpsw: Convert to platform remove callback returning void net: ethernet: ti: cpsw-new: Convert to platform remove callback returning void net: ethernet: ezchip: Convert to platform remove callback returning void drivers/net/ethernet/ezchip/nps_enet.c | 6 ++---- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 15 ++++++++++----- drivers/net/ethernet/ti/cpsw.c | 15 ++++++++++----- drivers/net/ethernet/ti/cpsw_new.c | 15 ++++++++++----- 4 files changed, 32 insertions(+), 19 deletions(-) base-commit: 8c87404c76c1911a7ec5b61bf3b2c3858cb95de1