mbox series

[net-next,v5,0/3] net: sched: Make tc-related drop reason more flexible for remaining qdiscs

Message ID 20231216204436.3712716-1-victor@mojatatu.com (mailing list archive)
Headers show
Series net: sched: Make tc-related drop reason more flexible for remaining qdiscs | expand

Message

Victor Nogueira Dec. 16, 2023, 8:44 p.m. UTC
This patch builds on Daniel's patch[1] to add initial support of tc drop
reason. The main goal is to distinguish between policy and error drops for
the remainder of the egress qdiscs (other than clsact).
The drop reason is set by cls_api and act_api in the tc skb cb in case
any error occurred in the data path.

Also add new skb drop reasons that are idiosyncratic to TC.

[1] https://lore.kernel.org/all/20231009092655.22025-1-daniel@iogearbox.net

Changes in V5:
- Drop "EXT_" from cookie error's drop reason name in doc

Changes in V4:
- Condense all the cookie drop reasons into one

Changes in V3:
- Removed duplicate assignment
- Rename function tc_skb_cb_drop_reason to tcf_get_drop_reason
- Move zone field upwards in struct tc_skb_cb to move hole to the end of 
  the struct

Changes in V2:
- Dropped RFC tag
- Removed check for drop reason being overwritten by filter in cls_api.c
- Simplified logic and removed function tcf_init_drop_reason

Victor Nogueira (3):
  net: sched: Move drop_reason to struct tc_skb_cb
  net: sched: Make tc-related drop reason more flexible for remaining
    qdiscs
  net: sched: Add initial TC error skb drop reasons

 include/net/dropreason-core.h | 18 +++++++++++++++---
 include/net/pkt_cls.h         |  6 ------
 include/net/pkt_sched.h       | 18 ------------------
 include/net/sch_generic.h     | 32 +++++++++++++++++++++++++++++++-
 net/core/dev.c                | 11 +++++++----
 net/sched/act_api.c           |  3 ++-
 net/sched/cls_api.c           | 31 +++++++++++++++----------------
 7 files changed, 70 insertions(+), 49 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Dec. 20, 2023, noon UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sat, 16 Dec 2023 17:44:33 -0300 you wrote:
> This patch builds on Daniel's patch[1] to add initial support of tc drop
> reason. The main goal is to distinguish between policy and error drops for
> the remainder of the egress qdiscs (other than clsact).
> The drop reason is set by cls_api and act_api in the tc skb cb in case
> any error occurred in the data path.
> 
> Also add new skb drop reasons that are idiosyncratic to TC.
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/3] net: sched: Move drop_reason to struct tc_skb_cb
    https://git.kernel.org/netdev/net-next/c/fb2780721ca5
  - [net-next,v5,2/3] net: sched: Make tc-related drop reason more flexible for remaining qdiscs
    https://git.kernel.org/netdev/net-next/c/b6a3c6066afc
  - [net-next,v5,3/3] net: sched: Add initial TC error skb drop reasons
    https://git.kernel.org/netdev/net-next/c/4cf24dc89340

You are awesome, thank you!