[v2,iproute2,0/6] rdma: print related patches

Message

Stephen Hemminger Jan. 4, 2024, 1:13 a.m. UTC

This set of patches makes rdma comman behave more like the
other commands in iproute2 around printing flags.
There are some other things found while looking at that code.

This version keeps similar function names to original

Stephen Hemminger (6):
  rdma: shorten print_ lines
  rdma: use standard flag for json
  rdma: make pretty behave like other commands
  rdma: make supress_errors a bit
  rdma: add oneline flag
  rdma: do not mix newline and json object

 man/man8/rdma.8 | 12 ++++++--
 rdma/dev.c      | 42 +++++++++++++++-------------
 rdma/link.c     | 52 +++++++++++++++++-----------------
 rdma/rdma.c     | 21 +++++++++-----
 rdma/rdma.h     | 11 ++++----
 rdma/res-cmid.c | 37 ++++++++++++-------------
 rdma/res-cq.c   | 34 +++++++++++------------
 rdma/res-ctx.c  | 11 ++++----
 rdma/res-mr.c   | 26 +++++++++--------
 rdma/res-pd.c   | 21 +++++++-------
 rdma/res-qp.c   | 50 ++++++++++++++++-----------------
 rdma/res-srq.c  | 27 +++++++++---------
 rdma/res.c      | 39 +++++++++++---------------
 rdma/res.h      | 18 +++++-------
 rdma/stat-mr.c  | 10 +++----
 rdma/stat.c     | 70 +++++++++++++++++++++-------------------------
 rdma/stat.h     |  4 +--
 rdma/sys.c      | 11 +++-----
 rdma/utils.c    | 74 +++++++++++++++++++++++--------------------------
 19 files changed, 277 insertions(+), 293 deletions(-)

Comments

Chengchang Tang Jan. 4, 2024, 5:58 a.m. UTC | #1

On 2024/1/4 9:13, Stephen Hemminger wrote:
> This set of patches makes rdma comman behave more like the
> other commands in iproute2 around printing flags.
> There are some other things found while looking at that code.
>
> This version keeps similar function names to original
>
> Stephen Hemminger (6):
>    rdma: shorten print_ lines
>    rdma: use standard flag for json
>    rdma: make pretty behave like other commands
>    rdma: make supress_errors a bit
>    rdma: add oneline flag
>    rdma: do not mix newline and json object
>
>

Both pretty and oneline are working well.

Tested-by: Chengchang Tang <[e-mail]>

Leon Romanovsky Jan. 7, 2024, 8:20 a.m. UTC | #2

On Wed, Jan 03, 2024 at 05:13:38PM -0800, Stephen Hemminger wrote:
> This set of patches makes rdma comman behave more like the
> other commands in iproute2 around printing flags.
> There are some other things found while looking at that code.
> 
> This version keeps similar function names to original
> 
> Stephen Hemminger (6):
>   rdma: shorten print_ lines
>   rdma: use standard flag for json
>   rdma: make pretty behave like other commands
>   rdma: make supress_errors a bit
>   rdma: add oneline flag
>   rdma: do not mix newline and json object

Hi Stephen,

We tested this series and it works correctly for us.

Thanks,
Tested-by: Leon Romanovsky <[e-mail]>

[e-mail] Jan. 7, 2024, 5:30 p.m. UTC | #3

Hello:

This series was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <[e-mail]>:

On Wed,  3 Jan 2024 17:13:38 -0800 you wrote:
> This set of patches makes rdma comman behave more like the
> other commands in iproute2 around printing flags.
> There are some other things found while looking at that code.
> 
> This version keeps similar function names to original
> 
> Stephen Hemminger (6):
>   rdma: shorten print_ lines
>   rdma: use standard flag for json
>   rdma: make pretty behave like other commands
>   rdma: make supress_errors a bit
>   rdma: add oneline flag
>   rdma: do not mix newline and json object
> 
> [...]

Here is the summary with links:
  - [v2,iproute2,1/6] rdma: shorten print_ lines
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=674e00aeaba7
  - [v2,iproute2,2/6] rdma: use standard flag for json
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=22edc0cf37cd
  - [v2,iproute2,3/6] rdma: make pretty behave like other commands
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=f962b24a5a33
  - [v2,iproute2,4/6] rdma: make supress_errors a bit
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=6e0d4e91a554
  - [v2,iproute2,5/6] rdma: add oneline flag
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=27a477ba80da
  - [v2,iproute2,6/6] rdma: do not mix newline and json object
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=a903854bad1c

You are awesome, thank you!