| Message ID | 20240129085531.15608-1-darinzon@amazon.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ENA driver changes | expand |
On 1/29/2024 12:55 AM, darinzon@amazon.com wrote: > > From: David Arinzon <darinzon@amazon.com> > > This patchset contains a set of minor and cosmetic > changes to the ENA driver. A couple of nits noted, but otherwise looks reasonable. Reviewed-by: Shannon Nelson <shannon.nelson@amd.com> > > David Arinzon (11): > net: ena: Remove an unused field > net: ena: Add more documentation for RX copybreak > net: ena: Minor cosmetic changes > net: ena: Enable DIM by default > net: ena: Remove CQ tail pointer update > net: ena: Change error print during ena_device_init() > net: ena: Add more information on TX timeouts > net: ena: Relocate skb_tx_timestamp() to improve time stamping > accuracy > net: ena: Change default print level for netif_ prints > net: ena: handle ena_calc_io_queue_size() possible errors > net: ena: Reduce lines with longer column width boundary > > .../device_drivers/ethernet/amazon/ena.rst | 6 + > drivers/net/ethernet/amazon/ena/ena_com.c | 323 ++++++------------ > drivers/net/ethernet/amazon/ena/ena_com.h | 6 +- > drivers/net/ethernet/amazon/ena/ena_eth_com.c | 49 ++- > drivers/net/ethernet/amazon/ena/ena_eth_com.h | 39 +-- > drivers/net/ethernet/amazon/ena/ena_netdev.c | 161 ++++++--- > .../net/ethernet/amazon/ena/ena_regs_defs.h | 1 + > drivers/net/ethernet/amazon/ena/ena_xdp.c | 1 - > 8 files changed, 258 insertions(+), 328 deletions(-) > > -- > 2.40.1 > >
> On 1/29/2024 12:55 AM, darinzon@amazon.com wrote: > > > > From: David Arinzon <darinzon@amazon.com> > > > > This patchset contains a set of minor and cosmetic changes to the ENA > > driver. > > A couple of nits noted, but otherwise looks reasonable. > > Reviewed-by: Shannon Nelson <shannon.nelson@amd.com> > > Thanks for taking the time and reviewing the patchset. I've addressed some of the comments, while the rest will be fixed in the next patchset version. David > > > > David Arinzon (11): > > net: ena: Remove an unused field > > net: ena: Add more documentation for RX copybreak > > net: ena: Minor cosmetic changes > > net: ena: Enable DIM by default > > net: ena: Remove CQ tail pointer update > > net: ena: Change error print during ena_device_init() > > net: ena: Add more information on TX timeouts > > net: ena: Relocate skb_tx_timestamp() to improve time stamping > > accuracy > > net: ena: Change default print level for netif_ prints > > net: ena: handle ena_calc_io_queue_size() possible errors > > net: ena: Reduce lines with longer column width boundary > > > > .../device_drivers/ethernet/amazon/ena.rst | 6 + > > drivers/net/ethernet/amazon/ena/ena_com.c | 323 ++++++------------ > > drivers/net/ethernet/amazon/ena/ena_com.h | 6 +- > > drivers/net/ethernet/amazon/ena/ena_eth_com.c | 49 ++- > > drivers/net/ethernet/amazon/ena/ena_eth_com.h | 39 +-- > > drivers/net/ethernet/amazon/ena/ena_netdev.c | 161 ++++++--- > > .../net/ethernet/amazon/ena/ena_regs_defs.h | 1 + > > drivers/net/ethernet/amazon/ena/ena_xdp.c | 1 - > > 8 files changed, 258 insertions(+), 328 deletions(-) > > > > -- > > 2.40.1 > > > >
On 1/30/2024 1:39 AM, Arinzon, David wrote: > >> On 1/29/2024 12:55 AM, darinzon@amazon.com wrote: >>> >>> From: David Arinzon <darinzon@amazon.com> >>> >>> This patchset contains a set of minor and cosmetic changes to the ENA >>> driver. >> >> A couple of nits noted, but otherwise looks reasonable. >> >> Reviewed-by: Shannon Nelson <shannon.nelson@amd.com> >> >> > > Thanks for taking the time and reviewing the patchset. > I've addressed some of the comments, while the rest will > be fixed in the next patchset version. Yep, I'm fine with your notes. Cheers, sln > > David > >>> >>> David Arinzon (11): >>> net: ena: Remove an unused field >>> net: ena: Add more documentation for RX copybreak >>> net: ena: Minor cosmetic changes >>> net: ena: Enable DIM by default >>> net: ena: Remove CQ tail pointer update >>> net: ena: Change error print during ena_device_init() >>> net: ena: Add more information on TX timeouts >>> net: ena: Relocate skb_tx_timestamp() to improve time stamping >>> accuracy >>> net: ena: Change default print level for netif_ prints >>> net: ena: handle ena_calc_io_queue_size() possible errors >>> net: ena: Reduce lines with longer column width boundary >>> >>> .../device_drivers/ethernet/amazon/ena.rst | 6 + >>> drivers/net/ethernet/amazon/ena/ena_com.c | 323 ++++++------------ >>> drivers/net/ethernet/amazon/ena/ena_com.h | 6 +- >>> drivers/net/ethernet/amazon/ena/ena_eth_com.c | 49 ++- >>> drivers/net/ethernet/amazon/ena/ena_eth_com.h | 39 +-- >>> drivers/net/ethernet/amazon/ena/ena_netdev.c | 161 ++++++--- >>> .../net/ethernet/amazon/ena/ena_regs_defs.h | 1 + >>> drivers/net/ethernet/amazon/ena/ena_xdp.c | 1 - >>> 8 files changed, 258 insertions(+), 328 deletions(-) >>> >>> -- >>> 2.40.1 >>> >>> >
From: David Arinzon <darinzon@amazon.com> This patchset contains a set of minor and cosmetic changes to the ENA driver. David Arinzon (11): net: ena: Remove an unused field net: ena: Add more documentation for RX copybreak net: ena: Minor cosmetic changes net: ena: Enable DIM by default net: ena: Remove CQ tail pointer update net: ena: Change error print during ena_device_init() net: ena: Add more information on TX timeouts net: ena: Relocate skb_tx_timestamp() to improve time stamping accuracy net: ena: Change default print level for netif_ prints net: ena: handle ena_calc_io_queue_size() possible errors net: ena: Reduce lines with longer column width boundary .../device_drivers/ethernet/amazon/ena.rst | 6 + drivers/net/ethernet/amazon/ena/ena_com.c | 323 ++++++------------ drivers/net/ethernet/amazon/ena/ena_com.h | 6 +- drivers/net/ethernet/amazon/ena/ena_eth_com.c | 49 ++- drivers/net/ethernet/amazon/ena/ena_eth_com.h | 39 +-- drivers/net/ethernet/amazon/ena/ena_netdev.c | 161 ++++++--- .../net/ethernet/amazon/ena/ena_regs_defs.h | 1 + drivers/net/ethernet/amazon/ena/ena_xdp.c | 1 - 8 files changed, 258 insertions(+), 328 deletions(-)