| Message ID | 20240131-upstream-net-20240131-mptcp-ci-issues-v1-0-4c1c11e571ff@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: fixes for recent issues reported by CI's | expand |
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 31 Jan 2024 22:49:45 +0100 you wrote: > This series of 9 patches fixes issues mostly identified by CI's not > managed by the MPTCP maintainers. Thank you Linero (LKFT) and Netdev > maintainers (NIPA) for running our kunit and selftests tests! > > For the first patch, it took a bit of time to identify the root cause. > Some MPTCP Join selftest subtests have been "flaky", mostly in slow > environments. It appears to be due to the use of a TCP-specific helper > on an MPTCP socket. A fix for kernels >= v5.15. > > [...] Here is the summary with links: - [net,1/9] mptcp: fix data re-injection from stale subflow https://git.kernel.org/netdev/net/c/b6c620dc43cc - [net,2/9] selftests: mptcp: add missing kconfig for NF Filter https://git.kernel.org/netdev/net/c/3645c844902b - [net,3/9] selftests: mptcp: add missing kconfig for NF Filter in v6 https://git.kernel.org/netdev/net/c/8c86fad2cecd - [net,4/9] selftests: mptcp: add missing kconfig for NF Mangle https://git.kernel.org/netdev/net/c/2d41f10fa497 - [net,5/9] selftests: mptcp: increase timeout to 30 min https://git.kernel.org/netdev/net/c/4d4dfb2019d7 - [net,6/9] selftests: mptcp: decrease BW in simult flows https://git.kernel.org/netdev/net/c/5e2f3c65af47 - [net,7/9] selftests: mptcp: allow changing subtests prefix https://git.kernel.org/netdev/net/c/de46d138e773 - [net,8/9] selftests: mptcp: join: stop transfer when check is done (part 1) https://git.kernel.org/netdev/net/c/31ee4ad86afd - [net,9/9] selftests: mptcp: join: stop transfer when check is done (part 2) https://git.kernel.org/netdev/net/c/04b57c9e096a You are awesome, thank you!
This series of 9 patches fixes issues mostly identified by CI's not managed by the MPTCP maintainers. Thank you Linero (LKFT) and Netdev maintainers (NIPA) for running our kunit and selftests tests! For the first patch, it took a bit of time to identify the root cause. Some MPTCP Join selftest subtests have been "flaky", mostly in slow environments. It appears to be due to the use of a TCP-specific helper on an MPTCP socket. A fix for kernels >= v5.15. Patches 2 to 4 add missing kernel config to support NetFilter tables needed for IPTables commands. These kconfigs are usually enabled in default configurations, but apparently not for all architectures. Patches 2 and 3 can be backported up to v5.11 and the 4th one up to v5.19. Patch 5 increases the time limit for MPTCP selftests. It appears that many CI's execute tests in a VM without acceleration supports, e.g. QEmu without KVM. As a result, the tests take longer. Plus, there are more and more tests. This patch modifies the timeout added in v5.18. Patch 6 reduces the maximum rate and delay of the different links in some Simult Flows selftest subtests. The goal is to let slow VMs reach the maximum speed. The original rate was introduced in v5.11. Patch 7 lets CI changing the prefix of the subtests titles, to be able to run the same selftest multiple times with different parameters. With different titles, tests will be considered as different and not override previous results as it is the case with some CI envs. Subtests have been introduced in v6.6. Patch 8 and 9 make some MPTCP Join selftest subtests quicker by stopping the transfer when the expected events have been seen. Patch 8 can be backported up to v6.5. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Matthieu Baerts (NGI0) (8): selftests: mptcp: add missing kconfig for NF Filter selftests: mptcp: add missing kconfig for NF Filter in v6 selftests: mptcp: add missing kconfig for NF Mangle selftests: mptcp: increase timeout to 30 min selftests: mptcp: decrease BW in simult flows selftests: mptcp: allow changing subtests prefix selftests: mptcp: join: stop transfer when check is done (part 1) selftests: mptcp: join: stop transfer when check is done (part 2) Paolo Abeni (1): mptcp: fix data re-injection from stale subflow net/mptcp/protocol.c | 3 --- tools/testing/selftests/net/mptcp/config | 3 +++ tools/testing/selftests/net/mptcp/mptcp_join.sh | 27 +++++++++-------------- tools/testing/selftests/net/mptcp/mptcp_lib.sh | 2 +- tools/testing/selftests/net/mptcp/settings | 2 +- tools/testing/selftests/net/mptcp/simult_flows.sh | 8 +++---- 6 files changed, 20 insertions(+), 25 deletions(-) --- base-commit: c9ec85153fea6873c52ed4f5055c87263f1b54f9 change-id: 20240131-upstream-net-20240131-mptcp-ci-issues-9d68b5601e74 Best regards,