mbox series

[iproute2,0/5] tc: more JSON fixes

Message ID 20240312225456.87937-1-stephen@networkplumber.org (mailing list archive)
Headers show
Series tc: more JSON fixes | expand

Message

Stephen Hemminger March 12, 2024, 10:53 p.m. UTC
Some more places in TC where JSON output is missing or could
be corrupted. And some things found while reviewing tc-simple
man page.

Stephen Hemminger (5):
  tc: support JSON for legacy stats
  pedit: log errors to stderr
  skbmod: support json in print
  simple: support json output
  tc-simple.8: take Jamal's prompt off examples

 man/man8/tc-simple.8 | 12 ++++++------
 tc/m_pedit.c         |  6 +++---
 tc/m_simple.c        |  8 +++++---
 tc/m_skbmod.c        | 37 +++++++++++++++++++++----------------
 tc/tc_util.c         | 28 +++++++++++++++-------------
 5 files changed, 50 insertions(+), 41 deletions(-)

Comments

Denis Kirjanov March 13, 2024, 11:08 a.m. UTC | #1
On 3/13/24 01:53, Stephen Hemminger wrote:
> Some more places in TC where JSON output is missing or could
> be corrupted. And some things found while reviewing tc-simple
> man page.

The series mixes the fixes with new features like json support.
It makes sense to split fixes and new features  

> 
> Stephen Hemminger (5):
>   tc: support JSON for legacy stats
>   pedit: log errors to stderr
>   skbmod: support json in print
>   simple: support json output
>   tc-simple.8: take Jamal's prompt off examples
> 
>  man/man8/tc-simple.8 | 12 ++++++------
>  tc/m_pedit.c         |  6 +++---
>  tc/m_simple.c        |  8 +++++---
>  tc/m_skbmod.c        | 37 +++++++++++++++++++++----------------
>  tc/tc_util.c         | 28 +++++++++++++++-------------
>  5 files changed, 50 insertions(+), 41 deletions(-)
>
Stephen Hemminger March 13, 2024, 5 p.m. UTC | #2
On Wed, 13 Mar 2024 14:08:27 +0300
Denis Kirjanov <dkirjanov@suse.de> wrote:

> On 3/13/24 01:53, Stephen Hemminger wrote:
> > Some more places in TC where JSON output is missing or could
> > be corrupted. And some things found while reviewing tc-simple
> > man page.  
> 
> The series mixes the fixes with new features like json support.
> It makes sense to split fixes and new features  
> 
> > 
> > Stephen Hemminger (5):
> >   tc: support JSON for legacy stats
> >   pedit: log errors to stderr
> >   skbmod: support json in print
> >   simple: support json output
> >   tc-simple.8: take Jamal's prompt off examples
> > 
> >  man/man8/tc-simple.8 | 12 ++++++------
> >  tc/m_pedit.c         |  6 +++---
> >  tc/m_simple.c        |  8 +++++---
> >  tc/m_skbmod.c        | 37 +++++++++++++++++++++----------------
> >  tc/tc_util.c         | 28 +++++++++++++++-------------
> >  5 files changed, 50 insertions(+), 41 deletions(-)
> >   

Not supporting JSON is a bug at this point
patchwork-bot+netdevbpf@kernel.org March 14, 2024, 12:50 a.m. UTC | #3
Hello:

This series was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Tue, 12 Mar 2024 15:53:27 -0700 you wrote:
> Some more places in TC where JSON output is missing or could
> be corrupted. And some things found while reviewing tc-simple
> man page.
> 
> Stephen Hemminger (5):
>   tc: support JSON for legacy stats
>   pedit: log errors to stderr
>   skbmod: support json in print
>   simple: support json output
>   tc-simple.8: take Jamal's prompt off examples
> 
> [...]

Here is the summary with links:
  - [iproute2,1/5] tc: support JSON for legacy stats
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=fc4226d2475a
  - [iproute2,2/5] pedit: log errors to stderr
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=ba52b3d4dd4f
  - [iproute2,3/5] skbmod: support json in print
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=af0ddbfa51f9
  - [iproute2,4/5] simple: support json output
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=69d55c213da8
  - [iproute2,5/5] tc-simple.8: take Jamal's prompt off examples
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=11740815bfe6

You are awesome, thank you!