mbox series

[net-next,0/8] mlx5e misc patches

Message ID 20240326222022.27926-1-tariqt@nvidia.com (mailing list archive)
Headers show
Series mlx5e misc patches | expand

Message

Tariq Toukan March 26, 2024, 10:20 p.m. UTC
Hi,

This patchset includes small features and misc code enhancements for the
mlx5e driver.

Patches 1-4 by Gal improves the mlx5e ethtool stats implementation, for
example by using standard helpers ethtool_sprintf/puts.

Patch 5 by Carolina adds exposure of RX packet drop counters of VFs/SFs
on their representor.

Patch 6 by me adds a reset option for the FW command interface debugfs
stats entries. This allows explicit FW command interface stats reset
between different runs of a test case.

Patches 7 and 8 are simple cleanups.

Series generated against:
commit 537c2e91d354 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net")

Thanks,
Tariq.

Carolina Jubran (2):
  net/mlx5e: Expose the VF/SF RX drop counter on the representor
  net/mlx5e: XDP, Fix an inconsistent comment

Gal Pressman (5):
  net/mlx5e: Use ethtool_sprintf/puts() to fill priv flags strings
  net/mlx5e: Use ethtool_sprintf/puts() to fill selftests strings
  net/mlx5e: Use ethtool_sprintf/puts() to fill stats strings
  net/mlx5e: Make stats group fill_stats callbacks consistent with the
    API
  net/mlx5: Convert uintX_t to uX

Tariq Toukan (1):
  net/mlx5e: debugfs, Add reset option for command interface stats

 .../ethernet/mellanox/mlx5/counters.rst       |   5 +
 .../net/ethernet/mellanox/mlx5/core/debugfs.c |  22 +-
 drivers/net/ethernet/mellanox/mlx5/core/en.h  |   2 +-
 .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |   2 +-
 .../mellanox/mlx5/core/en_accel/fs_tcp.c      |   2 +-
 .../mellanox/mlx5/core/en_accel/fs_tcp.h      |   4 +-
 .../mellanox/mlx5/core/en_accel/ipsec_stats.c |  28 +-
 .../mellanox/mlx5/core/en_accel/ktls.h        |  14 +-
 .../mellanox/mlx5/core/en_accel/ktls_stats.c  |  26 +-
 .../mlx5/core/en_accel/macsec_stats.c         |  22 +-
 .../ethernet/mellanox/mlx5/core/en_ethtool.c  |   3 +-
 .../net/ethernet/mellanox/mlx5/core/en_rep.c  |  98 +++-
 .../ethernet/mellanox/mlx5/core/en_selftest.c |   2 +-
 .../ethernet/mellanox/mlx5/core/en_stats.c    | 491 +++++++++---------
 .../ethernet/mellanox/mlx5/core/en_stats.h    |  11 +-
 drivers/net/ethernet/mellanox/mlx5/core/fw.c  |   2 +-
 .../ethernet/mellanox/mlx5/core/mlx5_core.h   |   2 +-
 .../mellanox/mlx5/core/steering/dr_ste_v0.c   |   2 +-
 .../mellanox/mlx5/core/steering/dr_ste_v1.c   |   4 +-
 include/linux/mlx5/device.h                   |   2 +-
 20 files changed, 405 insertions(+), 339 deletions(-)

Comments

Jakub Kicinski March 28, 2024, 4:25 p.m. UTC | #1
On Wed, 27 Mar 2024 00:20:14 +0200 Tariq Toukan wrote:
> This patchset includes small features and misc code enhancements for the
> mlx5e driver.
> 
> Patches 1-4 by Gal improves the mlx5e ethtool stats implementation, for
> example by using standard helpers ethtool_sprintf/puts.
> 
> Patch 5 by Carolina adds exposure of RX packet drop counters of VFs/SFs
> on their representor.
> 
> Patch 6 by me adds a reset option for the FW command interface debugfs
> stats entries. This allows explicit FW command interface stats reset
> between different runs of a test case.
> 
> Patches 7 and 8 are simple cleanups.

This is purely mlx5 changes, since you're not listed as the maintainer
it'd be good to add an note to the cover letter explaining your
expectations. Otherwise you may have just typo'ed the subject and
have actually meant it for mlx5-next.
Tariq Toukan March 28, 2024, 10:28 p.m. UTC | #2
On 28/03/2024 18:25, Jakub Kicinski wrote:
> On Wed, 27 Mar 2024 00:20:14 +0200 Tariq Toukan wrote:
>> This patchset includes small features and misc code enhancements for the
>> mlx5e driver.
>>
>> Patches 1-4 by Gal improves the mlx5e ethtool stats implementation, for
>> example by using standard helpers ethtool_sprintf/puts.
>>
>> Patch 5 by Carolina adds exposure of RX packet drop counters of VFs/SFs
>> on their representor.
>>
>> Patch 6 by me adds a reset option for the FW command interface debugfs
>> stats entries. This allows explicit FW command interface stats reset
>> between different runs of a test case.
>>
>> Patches 7 and 8 are simple cleanups.
> 
> This is purely mlx5 changes, since you're not listed as the maintainer
> it'd be good to add an note to the cover letter explaining your
> expectations. 

This is targeted for net-next. I should add myself in the proper mlx5 
maintainers section. We'll submit a patch for that.

> Otherwise you may have just typo'ed the subject and
> have actually meant it for mlx5-next.
>