[net-next,00/12] selftests: netfilter: move to lib.sh infra

Message

Florian Westphal April 14, 2024, 10:57 p.m. UTC

This is the second batch of the netfilter selftest move.

scripts are moved to lib.sh infra. This allows to use busywait helper
and ditch various 'sleep 2' all over the place.

Last patch updates the makefile with the missing bits to make
'kselftest-install' target work as intended again and adds more required
config settings.

Missing/work in progress:
1. nft_concat_range.sh: it runs for a very long time and also has
a few remaining issues.
2. some scripts still generate lots of warnings when fed to shellcheck.

Both issues work-in-progress, no point in waiting because its not
essential and series should not grow too large.

Florian Westphal (12):
  selftests: netfilter: conntrack_icmp_related.sh: move to lib.sh infra
  selftests: netfilter: conntrack_tcp_unreplied.sh: move to lib.sh infra
  selftests: netfilter: nft_queue.sh: move to lib.sh infra
  selftests: netfilter: nft_synproxy.sh: move to lib.sh infra
  selftests: netfilter: nft_zones_many.sh: move to lib.sh infra
  selftests: netfilter: xt_string.sh: move to lib.sh infra
  selftests: netfilter: nft_nat_zones.sh: shellcheck cleanups
  selftests: netfilter: nft_queue.sh: shellcheck cleanups
  selftests: netfilter: conntrack_ipip_mtu.sh: shellcheck cleanups
  selftests: netfilter: nft_fib.sh: shellcheck cleanups
  selftests: netfilter: nft_audit.sh: skip if auditd is running
  selftests: netfilter: update makefiles and kernel config

 tools/testing/selftests/Makefile              |   2 +-
 .../testing/selftests/net/netfilter/Makefile  |   5 +
 tools/testing/selftests/net/netfilter/config  |  42 ++-
 .../net/netfilter/conntrack_ipip_mtu.sh       |  74 ++---
 .../selftests/net/netfilter/nft_audit.sh      |  18 +-
 .../selftests/net/netfilter/nft_fib.sh        | 128 ++++----
 .../selftests/net/netfilter/nft_nat_zones.sh  | 193 +++++--------
 .../selftests/net/netfilter/nft_queue.sh      | 273 ++++++++----------
 .../selftests/net/netfilter/nft_synproxy.sh   |  77 ++---
 .../selftests/net/netfilter/nft_zones_many.sh |  93 +++---
 .../selftests/net/netfilter/xt_string.sh      |  55 ++--
 11 files changed, 458 insertions(+), 502 deletions(-)

Comments

Pablo Neira Ayuso April 15, 2024, 8:48 a.m. UTC | #1

On Mon, Apr 15, 2024 at 12:57:12AM +0200, Florian Westphal wrote:
> This is the second batch of the netfilter selftest move.
> 
> scripts are moved to lib.sh infra. This allows to use busywait helper
> and ditch various 'sleep 2' all over the place.
> 
> Last patch updates the makefile with the missing bits to make
> 'kselftest-install' target work as intended again and adds more required
> config settings.
> 
> Missing/work in progress:
> 1. nft_concat_range.sh: it runs for a very long time and also has
> a few remaining issues.
> 2. some scripts still generate lots of warnings when fed to shellcheck.
> 
> Both issues work-in-progress, no point in waiting because its not
> essential and series should not grow too large.

Acked-by: Pablo Neira Ayuso <[e-mail]>

Thanks Florian