[dwarves,0/2] replace --btf_features="all" with "default"

Message

Alan Maguire April 23, 2024, 4:01 p.m. UTC

Use of "all" in --btf_features is confusing; use the "default" keyword
to request default set of BTF features for encoding instead.  Then
non-standard features can be added in a more natural way; i.e.

--btf_features=default,reproducible_build

Patch 1 makes this change in pahole.c and documentation.
Patch 2 adjusts the reproducible build selftest to use "default"
instead of "all".

This series is applicable on the "next" branch.

Alan Maguire (2):
  pahole: replace use of "all" with "default" for --btf_features
  tests: update reproducible_build test to use "default"

 man-pages/pahole.1          |  4 +-
 pahole.c                    | 75 +++++++++++++++++++------------------
 tests/reproducible_build.sh |  4 +-
 3 files changed, 43 insertions(+), 40 deletions(-)

Comments

Arnaldo Carvalho de Melo April 23, 2024, 5:54 p.m. UTC | #1

On Tue, Apr 23, 2024 at 05:01:58PM +0100, Alan Maguire wrote:
> Use of "all" in --btf_features is confusing; use the "default" keyword
> to request default set of BTF features for encoding instead.  Then
> non-standard features can be added in a more natural way; i.e.
> 
> --btf_features=default,reproducible_build
> 
> Patch 1 makes this change in pahole.c and documentation.
> Patch 2 adjusts the reproducible build selftest to use "default"
> instead of "all".
> 
> This series is applicable on the "next" branch.

Applied to the next branch, I also refreshed the patches adding the
alternative + syntax, its basically a one liner :-)

I'll leave it there for a day for the libbpf CI to test with it and then
will move all to 'master'.

The first patch of Daniel's series got merged as well, it would be good
to refresh the other two patches on top of what we have in 'next' now,
Daniel?

Thanks!

- Arnaldo
 
> Alan Maguire (2):
>   pahole: replace use of "all" with "default" for --btf_features
>   tests: update reproducible_build test to use "default"
> 
>  man-pages/pahole.1          |  4 +-
>  pahole.c                    | 75 +++++++++++++++++++------------------
>  tests/reproducible_build.sh |  4 +-
>  3 files changed, 43 insertions(+), 40 deletions(-)
> 
> -- 
> 2.39.3

Daniel Xu April 24, 2024, 3:32 a.m. UTC | #2

On Tue, Apr 23, 2024 at 02:54:18PM -0300, Arnaldo Carvalho de Melo wrote:
> On Tue, Apr 23, 2024 at 05:01:58PM +0100, Alan Maguire wrote:
> > Use of "all" in --btf_features is confusing; use the "default" keyword
> > to request default set of BTF features for encoding instead.  Then
> > non-standard features can be added in a more natural way; i.e.
> > 
> > --btf_features=default,reproducible_build
> > 
> > Patch 1 makes this change in pahole.c and documentation.
> > Patch 2 adjusts the reproducible build selftest to use "default"
> > instead of "all".
> > 
> > This series is applicable on the "next" branch.
> 
> Applied to the next branch, I also refreshed the patches adding the
> alternative + syntax, its basically a one liner :-)
> 
> I'll leave it there for a day for the libbpf CI to test with it and then
> will move all to 'master'.
> 
> The first patch of Daniel's series got merged as well, it would be good
> to refresh the other two patches on top of what we have in 'next' now,
> Daniel?

Apologies for the delay - it's top of my todo list now. I will rebase
with changes in the morning.

Thanks,
Daniel