From patchwork Mon May 13 08:37:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Swiatkowski X-Patchwork-Id: 13663191 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57840146A6A for ; Mon, 13 May 2024 08:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715589157; cv=none; b=PapKgd/zor3Q+9Nq8mFiYTAWVuSwZ3TdLYOohM7rJs2HxpsHtgqRcJAvG4xSXcniqKbckn1B6I+EiIoFVtbuZXB8C/V4BxwMogIYI7d7/mWEmNmqqJjbHLKpwbxFHvYCBlY8ZVl5b5WIMGB8I/Q2KFhYE3VXE6p9R4+Z+Vr0ce8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715589157; c=relaxed/simple; bh=xacP+gPZ4dCFnFiABIUOuB3571+sWynTPW/PMc38bA4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fCY7zKnGgWmmbZhmHP9mRehkqnQV/m7+JuHgMn7cselUb3WYm3q/m1FnkM9vjn3ZF4ZFryr/GWAIX6q8M6TSmhRQOR0X+LEiglEDtNqVxajgkLBTFZCvvT9eU267Nelp45dtvVyKD/mQAnq9akqjxc+UP4yM1I+7a9eM4N/h4Po= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=g37dxmDj; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="g37dxmDj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715589156; x=1747125156; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=xacP+gPZ4dCFnFiABIUOuB3571+sWynTPW/PMc38bA4=; b=g37dxmDjhRE6Vpz7f5lps08CUHfCw/z2EWLXh/36JO1Phhk7Dt9qRMfw jJrBriXoch10hCv2r09sa9nnDxuNF0gXO2iKDmiYEh7T8s8u9S+7Xx0Vz ONdTAWcSxHgbUYl3Pxxjdva0tbHmKeuGVAVvbLZYv1pZkBDctA5LejFb5 RveyJCP3tuXzT/9/crowtWScePVQw2zudfNx5RBEeT3zsLeklz0NikoU2 aGnWIwv0kNUXAup6UEtGtYBXPQKlkR6/ZedPLnr/jxXPzZ03rulhg9zXS wqBKaYNTdA1bOq3aDLBAMuhpzvrjw/S9XUdGSzoAJB9qJEig+27EFWnUQ Q==; X-CSE-ConnectionGUID: FnW9BCJgRGujT1CUOtdhBw== X-CSE-MsgGUID: GUAjvE3wSq2ODdzU+b1thw== X-IronPort-AV: E=McAfee;i="6600,9927,11071"; a="22914792" X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208";a="22914792" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2024 01:32:35 -0700 X-CSE-ConnectionGUID: 36yU4qmySyqhAJNGjYpFsA== X-CSE-MsgGUID: +Q6PRXTcTWifioBB48Kj8A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208";a="30303243" Received: from wasp.igk.intel.com (HELO GK3153-DR2-R750-36946.localdomain.com) ([10.102.20.192]) by fmviesa006.fm.intel.com with ESMTP; 13 May 2024 01:32:32 -0700 From: Michal Swiatkowski To: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, jacob.e.keller@intel.com, michal.kubiak@intel.com, maciej.fijalkowski@intel.com, sridhar.samudrala@intel.com, przemyslaw.kitszel@intel.com, wojciech.drewek@intel.com, pio.raczynski@gmail.com, jiri@nvidia.com, mateusz.polchlopek@intel.com, shayd@nvidia.com Subject: [iwl-next v2 00/15] ice: support devlink subfunction Date: Mon, 13 May 2024 10:37:20 +0200 Message-ID: <20240513083735.54791-1-michal.swiatkowski@linux.intel.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, Currently ice driver does not allow creating more than one networking device per physical function. The only way to have more hardware backed netdev is to use SR-IOV. Following patchset adds support for devlink port API. For each new pcisf type port, driver allocates new VSI, configures all resources needed, including dynamically MSIX vectors, program rules and registers new netdev. This series supports only one Tx/Rx queue pair per subfunction. Example commands: devlink port add pci/0000:31:00.1 flavour pcisf pfnum 1 sfnum 1000 devlink port function set pci/0000:31:00.1/1 hw_addr 00:00:00:00:03:14 devlink port function set pci/0000:31:00.1/1 state active devlink port function del pci/0000:31:00.1/1 Make the port representor and eswitch code generic to support subfunction representor type. VSI configuration is slightly different between VF and SF. It needs to be reflected in the code. v1 --> v2: [1] * allow changing SF MAC address only when port isn't attached * split patch with port representor creation into two (first making code generic and than adding support for SF representor) * fix warning massege in case of SF device creation * remove double space * add verb in commit message Changelog for previous patchset version (not containing port representor for SF support). v3 --> v4: [4] * get rid of unnecessary checks * fix cosmetic issues (whitespaces, wording) * move unrelated chunks to separate patch * move implementing activation/deactivation to last patch v2 --> v3: [3] * fix building issue between the patches; allocating devlink for subfunction need to include base subfunction header * fix kdoc issues v1 --> v2: [2] * use correct parameters in ice_devlink_alloc() thanks to Mateusz [1] https://lore.kernel.org/netdev/20240507114516.9765-1-michal.swiatkowski@linux.intel.com/ [2] https://lore.kernel.org/netdev/20240408103049.19445-1-michal.swiatkowski@linux.intel.com/ [3] https://lore.kernel.org/netdev/20240410050809.125043-1-michal.swiatkowski@linux.intel.com/ [4] https://lore.kernel.org/netdev/20240412063053.339795-1-michal.swiatkowski@linux.intel.com/ Michal Swiatkowski (8): ice: treat subfunction VSI the same as PF VSI ice: make reprresentor code generic ice: create port representor for SF ice: don't set target VSI for subfunction ice: check if SF is ready in ethtool ops ice: implement netdevice ops for SF representor ice: support subfunction devlink Tx topology ice: basic support for VLAN in subfunctions Piotr Raczynski (7): ice: add new VSI type for subfunctions ice: export ice ndo_ops functions ice: add basic devlink subfunctions support ice: allocate devlink for subfunction ice: base subfunction aux driver ice: implement netdev for subfunction ice: allow to activate and deactivate subfunction drivers/net/ethernet/intel/ice/Makefile | 2 + .../net/ethernet/intel/ice/devlink/devlink.c | 48 ++ .../net/ethernet/intel/ice/devlink/devlink.h | 1 + .../ethernet/intel/ice/devlink/devlink_port.c | 522 ++++++++++++++++++ .../ethernet/intel/ice/devlink/devlink_port.h | 43 ++ drivers/net/ethernet/intel/ice/ice.h | 19 +- drivers/net/ethernet/intel/ice/ice_base.c | 5 +- drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 1 + drivers/net/ethernet/intel/ice/ice_eswitch.c | 113 +++- drivers/net/ethernet/intel/ice/ice_eswitch.h | 22 +- drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 +- drivers/net/ethernet/intel/ice/ice_lib.c | 52 +- drivers/net/ethernet/intel/ice/ice_lib.h | 3 + drivers/net/ethernet/intel/ice/ice_main.c | 66 ++- drivers/net/ethernet/intel/ice/ice_repr.c | 211 +++++-- drivers/net/ethernet/intel/ice/ice_repr.h | 22 +- drivers/net/ethernet/intel/ice/ice_sf_eth.c | 329 +++++++++++ drivers/net/ethernet/intel/ice/ice_sf_eth.h | 33 ++ .../ethernet/intel/ice/ice_sf_vsi_vlan_ops.c | 21 + .../ethernet/intel/ice/ice_sf_vsi_vlan_ops.h | 13 + drivers/net/ethernet/intel/ice/ice_sriov.c | 4 +- drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- drivers/net/ethernet/intel/ice/ice_type.h | 1 + drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 +- .../net/ethernet/intel/ice/ice_vsi_vlan_ops.c | 4 + drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +- 26 files changed, 1412 insertions(+), 138 deletions(-) create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_eth.c create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_eth.h create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_vsi_vlan_ops.c create mode 100644 drivers/net/ethernet/intel/ice/ice_sf_vsi_vlan_ops.h