| Message ID | 20240603-next-2024-06-03-intel-next-batch-v1-0-e0523b28f325@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Intel Wired LAN Driver Updates 2024-06-03 | expand |
On 6/3/2024 3:38 PM, Jacob Keller wrote: > > This series includes miscellaneous improvements for the ice and igc, as > well as a cleanup to the Makefiles for all Intel net drivers. > > Andy fixes all of the Intel net driver Makefiles to use the documented > '*-y' syntax for specifying object files to link into kernel driver > modules, rather than the '*-objs' syntax which works but is documented as > reserved for user-space host programs. > > Michal Swiatkowski has four patches to prepare the ice driver for > supporting subfunctions. This includes some cleanups to the locking around > devlink port creation as well as improvements to the driver's handling of > port representor VSIs. > > Jacob has a cleanup to refactor rounding logic in the ice driver into a > common roundup_u64 helper function. > > Michal Schmidt replaces irq_set_affinity_hint() to use > irq_update_affinity_hint() which behaves better with user-applied affinity > settings. > > Eric improves checks to the ice_vsi_rebuild() function, checking and > reporting failures when the function is called during a reset. > > Vitaly adds support for ethtool .set_phys_id, used for blinking the device > LEDs to identify the physical port for which a device is connected to. > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Aside from a couple of minor questions on 9/9, these all look reasonable. For the set: Reviewed-by: Shannon Nelson <shannon.nelson@amd.com> > --- > Andy Shevchenko (1): > net: intel: Use *-y instead of *-objs in Makefile > > Eric Joyner (1): > ice: Check all ice_vsi_rebuild() errors in function > > Jacob Keller (1): > ice: add and use roundup_u64 instead of open coding equivalent > > Michal Schmidt (1): > ice: use irq_update_affinity_hint() > > Michal Swiatkowski (4): > ice: store representor ID in bridge port > ice: move devlink locking outside the port creation > ice: move VSI configuration outside repr setup > ice: update representor when VSI is ready > > Vitaly Lifshits (1): > igc: add support for ethtool.set_phys_id > > drivers/net/ethernet/intel/e1000/Makefile | 2 +- > drivers/net/ethernet/intel/e1000e/Makefile | 7 +- > drivers/net/ethernet/intel/i40e/Makefile | 2 +- > drivers/net/ethernet/intel/iavf/Makefile | 5 +- > drivers/net/ethernet/intel/ice/devlink/devlink.c | 2 - > .../net/ethernet/intel/ice/devlink/devlink_port.c | 4 +- > drivers/net/ethernet/intel/ice/ice_eswitch.c | 85 ++++++++++++++++------ > drivers/net/ethernet/intel/ice/ice_eswitch.h | 14 +++- > drivers/net/ethernet/intel/ice/ice_eswitch_br.c | 4 +- > drivers/net/ethernet/intel/ice/ice_eswitch_br.h | 1 + > drivers/net/ethernet/intel/ice/ice_lib.c | 4 +- > drivers/net/ethernet/intel/ice/ice_main.c | 17 ++++- > drivers/net/ethernet/intel/ice/ice_ptp.c | 3 +- > drivers/net/ethernet/intel/ice/ice_repr.c | 16 ++-- > drivers/net/ethernet/intel/ice/ice_repr.h | 1 + > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +- > drivers/net/ethernet/intel/igb/Makefile | 6 +- > drivers/net/ethernet/intel/igbvf/Makefile | 6 +- > drivers/net/ethernet/intel/igc/Makefile | 6 +- > drivers/net/ethernet/intel/igc/igc_defines.h | 22 ++++++ > drivers/net/ethernet/intel/igc/igc_ethtool.c | 32 ++++++++ > drivers/net/ethernet/intel/igc/igc_hw.h | 2 + > drivers/net/ethernet/intel/igc/igc_leds.c | 21 +----- > drivers/net/ethernet/intel/igc/igc_main.c | 2 + > drivers/net/ethernet/intel/ixgbe/Makefile | 8 +- > drivers/net/ethernet/intel/ixgbevf/Makefile | 6 +- > drivers/net/ethernet/intel/libeth/Makefile | 2 +- > drivers/net/ethernet/intel/libie/Makefile | 2 +- > include/linux/math64.h | 28 +++++++ > 29 files changed, 214 insertions(+), 98 deletions(-) > --- > base-commit: 83042ce9b7c39b0e64094d86a70d62392ac21a06 > change-id: 20240603-next-2024-06-03-intel-next-batch-4537be19dc21 > > Best regards, > -- > Jacob Keller <jacob.e.keller@intel.com> > >
On 6/3/2024 5:14 PM, Nelson, Shannon wrote: > On 6/3/2024 3:38 PM, Jacob Keller wrote: >> >> This series includes miscellaneous improvements for the ice and igc, as >> well as a cleanup to the Makefiles for all Intel net drivers. >> >> Andy fixes all of the Intel net driver Makefiles to use the documented >> '*-y' syntax for specifying object files to link into kernel driver >> modules, rather than the '*-objs' syntax which works but is documented as >> reserved for user-space host programs. >> >> Michal Swiatkowski has four patches to prepare the ice driver for >> supporting subfunctions. This includes some cleanups to the locking around >> devlink port creation as well as improvements to the driver's handling of >> port representor VSIs. >> >> Jacob has a cleanup to refactor rounding logic in the ice driver into a >> common roundup_u64 helper function. >> >> Michal Schmidt replaces irq_set_affinity_hint() to use >> irq_update_affinity_hint() which behaves better with user-applied affinity >> settings. >> >> Eric improves checks to the ice_vsi_rebuild() function, checking and >> reporting failures when the function is called during a reset. >> >> Vitaly adds support for ethtool .set_phys_id, used for blinking the device >> LEDs to identify the physical port for which a device is connected to. >> >> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> > > Aside from a couple of minor questions on 9/9, these all look reasonable. > > For the set: > Reviewed-by: Shannon Nelson <shannon.nelson@amd.com> > > Thanks. I'm fine if we also want to just grab 1-8 and send the igc patch back to drawing board to sort out the ledctl_default behavior.
On 6/3/2024 3:38 PM, Jacob Keller wrote: > This series includes miscellaneous improvements for the ice and igc, as > well as a cleanup to the Makefiles for all Intel net drivers. > > Andy fixes all of the Intel net driver Makefiles to use the documented > '*-y' syntax for specifying object files to link into kernel driver > modules, rather than the '*-objs' syntax which works but is documented as > reserved for user-space host programs. > > Michal Swiatkowski has four patches to prepare the ice driver for > supporting subfunctions. This includes some cleanups to the locking around > devlink port creation as well as improvements to the driver's handling of > port representor VSIs. > > Jacob has a cleanup to refactor rounding logic in the ice driver into a > common roundup_u64 helper function. > > Michal Schmidt replaces irq_set_affinity_hint() to use > irq_update_affinity_hint() which behaves better with user-applied affinity > settings. > > Eric improves checks to the ice_vsi_rebuild() function, checking and > reporting failures when the function is called during a reset. > > Vitaly adds support for ethtool .set_phys_id, used for blinking the device > LEDs to identify the physical port for which a device is connected to. > > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> The igc patch needs to be completely removed and reworked. I think I also saw some comments about Eric's ice_vsi_rebuild() that we missed on Intel Wired LAN. > https://lore.kernel.org/intel-wired-lan/20240604144712.GR491852@kernel.org/ I'm going to send a v2 which drops those two patches so that they can be reworked. Thanks, Jake
This series includes miscellaneous improvements for the ice and igc, as well as a cleanup to the Makefiles for all Intel net drivers. Andy fixes all of the Intel net driver Makefiles to use the documented '*-y' syntax for specifying object files to link into kernel driver modules, rather than the '*-objs' syntax which works but is documented as reserved for user-space host programs. Michal Swiatkowski has four patches to prepare the ice driver for supporting subfunctions. This includes some cleanups to the locking around devlink port creation as well as improvements to the driver's handling of port representor VSIs. Jacob has a cleanup to refactor rounding logic in the ice driver into a common roundup_u64 helper function. Michal Schmidt replaces irq_set_affinity_hint() to use irq_update_affinity_hint() which behaves better with user-applied affinity settings. Eric improves checks to the ice_vsi_rebuild() function, checking and reporting failures when the function is called during a reset. Vitaly adds support for ethtool .set_phys_id, used for blinking the device LEDs to identify the physical port for which a device is connected to. Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> --- Andy Shevchenko (1): net: intel: Use *-y instead of *-objs in Makefile Eric Joyner (1): ice: Check all ice_vsi_rebuild() errors in function Jacob Keller (1): ice: add and use roundup_u64 instead of open coding equivalent Michal Schmidt (1): ice: use irq_update_affinity_hint() Michal Swiatkowski (4): ice: store representor ID in bridge port ice: move devlink locking outside the port creation ice: move VSI configuration outside repr setup ice: update representor when VSI is ready Vitaly Lifshits (1): igc: add support for ethtool.set_phys_id drivers/net/ethernet/intel/e1000/Makefile | 2 +- drivers/net/ethernet/intel/e1000e/Makefile | 7 +- drivers/net/ethernet/intel/i40e/Makefile | 2 +- drivers/net/ethernet/intel/iavf/Makefile | 5 +- drivers/net/ethernet/intel/ice/devlink/devlink.c | 2 - .../net/ethernet/intel/ice/devlink/devlink_port.c | 4 +- drivers/net/ethernet/intel/ice/ice_eswitch.c | 85 ++++++++++++++++------ drivers/net/ethernet/intel/ice/ice_eswitch.h | 14 +++- drivers/net/ethernet/intel/ice/ice_eswitch_br.c | 4 +- drivers/net/ethernet/intel/ice/ice_eswitch_br.h | 1 + drivers/net/ethernet/intel/ice/ice_lib.c | 4 +- drivers/net/ethernet/intel/ice/ice_main.c | 17 ++++- drivers/net/ethernet/intel/ice/ice_ptp.c | 3 +- drivers/net/ethernet/intel/ice/ice_repr.c | 16 ++-- drivers/net/ethernet/intel/ice/ice_repr.h | 1 + drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +- drivers/net/ethernet/intel/igb/Makefile | 6 +- drivers/net/ethernet/intel/igbvf/Makefile | 6 +- drivers/net/ethernet/intel/igc/Makefile | 6 +- drivers/net/ethernet/intel/igc/igc_defines.h | 22 ++++++ drivers/net/ethernet/intel/igc/igc_ethtool.c | 32 ++++++++ drivers/net/ethernet/intel/igc/igc_hw.h | 2 + drivers/net/ethernet/intel/igc/igc_leds.c | 21 +----- drivers/net/ethernet/intel/igc/igc_main.c | 2 + drivers/net/ethernet/intel/ixgbe/Makefile | 8 +- drivers/net/ethernet/intel/ixgbevf/Makefile | 6 +- drivers/net/ethernet/intel/libeth/Makefile | 2 +- drivers/net/ethernet/intel/libie/Makefile | 2 +- include/linux/math64.h | 28 +++++++ 29 files changed, 214 insertions(+), 98 deletions(-) --- base-commit: 83042ce9b7c39b0e64094d86a70d62392ac21a06 change-id: 20240603-next-2024-06-03-intel-next-batch-4537be19dc21 Best regards,