[net-next,v7,0/3] net: tcp: un-pin tw timer

Message

Florian Westphal June 4, 2024, 2:08 p.m. UTC

This is v7 of the series where the tw_timer is un-pinned to get rid of
interferences in isolated CPUs setups.

First patch makes necessary preparations, existing code relies on
TIMER_PINNED to avoid races.

Second patch un-pins the TW timer. Could be folded into the first one,
but it might help wrt. bisection.

Third patch is a minor cleanup to move a helper from .h to the only
remaining compilation unit.

Tested with iperf3 and stress-ng socket mode.

Changes since previous iteration:
 - use timer_shutdown_sync, ehash lock can be released before
 - fix 'ddcp' typo in patch subject

Florian Westphal (2):
  net: tcp: un-pin the tw_timer
  tcp: move inet_twsk_schedule helper out of header

Valentin Schneider (1):
  net: tcp/dccp: prepare for tw_timer un-pinning

 include/net/inet_timewait_sock.h | 11 +++---
 net/dccp/minisocks.c             |  3 +-
 net/ipv4/inet_timewait_sock.c    | 59 +++++++++++++++++++++++++++-----
 net/ipv4/tcp_minisocks.c         |  3 +-
 4 files changed, 57 insertions(+), 19 deletions(-)

Comments

Sebastian Andrzej Siewior June 5, 2024, 9:21 a.m. UTC | #1

On 2024-06-04 16:08:46 [+0200], Florian Westphal wrote:
> This is v7 of the series where the tw_timer is un-pinned to get rid of
> interferences in isolated CPUs setups.
> 
> First patch makes necessary preparations, existing code relies on
> TIMER_PINNED to avoid races.

And BH-disabled.
Thank you.

Reviewed-by: Sebastian Andrzej Siewior <[e-mail]>

Sebastian

Valentin Schneider June 6, 2024, 10:01 a.m. UTC | #2

On 04/06/24 16:08, Florian Westphal wrote:
> This is v7 of the series where the tw_timer is un-pinned to get rid of
> interferences in isolated CPUs setups.
>
> First patch makes necessary preparations, existing code relies on
> TIMER_PINNED to avoid races.
>
> Second patch un-pins the TW timer. Could be folded into the first one,
> but it might help wrt. bisection.
>
> Third patch is a minor cleanup to move a helper from .h to the only
> remaining compilation unit.
>
> Tested with iperf3 and stress-ng socket mode.
>
> Changes since previous iteration:
>  - use timer_shutdown_sync, ehash lock can be released before
>  - fix 'ddcp' typo in patch subject
>

With Sebastian's suggested changes:
Reviewed-by: Valentin Schneider <[e-mail]>