[net-next,v8,0/3] net: tcp: un-pin tw timer

Message

Florian Westphal June 6, 2024, 3:11 p.m. UTC

Changes since previous iteration:
 - Patch 1: update a comment, I copied Erics v7 RvB tag.
 - Patch 2: move bh off/on into hashdance_schedule and get rid of
   comment mentioning pinned tw timer.
   I did not copy Erics RvB tag over from v7 because of the change.
 - Patch 3 is unchanged, so I kept Erics RvB tag.

This is v8 of the series where the tw_timer is un-pinned to get rid of
interferences in isolated CPUs setups.

First patch makes necessary preparations, existing code relies on
TIMER_PINNED to avoid races.

Second patch un-pins the TW timer. Could be folded into the first one,
but it might help wrt. bisection.

Third patch is a minor cleanup to move a helper from .h to the only
remaining compilation unit.

Tested with iperf3 and stress-ng socket mode.

Florian Westphal (2):
  net: tcp: un-pin the tw_timer
  tcp: move inet_twsk_schedule helper out of header

Valentin Schneider (1):
  net: tcp/dccp: prepare for tw_timer un-pinning

 include/net/inet_timewait_sock.h | 11 ++----
 net/dccp/minisocks.c             |  9 +----
 net/ipv4/inet_timewait_sock.c    | 63 +++++++++++++++++++++++++++-----
 net/ipv4/tcp_ipv4.c              |  2 +-
 net/ipv4/tcp_minisocks.c         |  9 +----
 5 files changed, 61 insertions(+), 33 deletions(-)

Comments

Sebastian Andrzej Siewior June 6, 2024, 3:23 p.m. UTC | #1

On 2024-06-06 17:11:36 [+0200], Florian Westphal wrote:
> Changes since previous iteration:

Reviewed-by: Sebastian Andrzej Siewior <[e-mail]>

Sebastian

[e-mail] June 10, 2024, 11 a.m. UTC | #2

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <[e-mail]>:

On Thu,  6 Jun 2024 17:11:36 +0200 you wrote:
> Changes since previous iteration:
>  - Patch 1: update a comment, I copied Erics v7 RvB tag.
>  - Patch 2: move bh off/on into hashdance_schedule and get rid of
>    comment mentioning pinned tw timer.
>    I did not copy Erics RvB tag over from v7 because of the change.
>  - Patch 3 is unchanged, so I kept Erics RvB tag.
> 
> [...]

Here is the summary with links:
  - [net-next,v8,1/3] net: tcp/dccp: prepare for tw_timer un-pinning
    https://git.kernel.org/netdev/net-next/c/b334b924c9b7
  - [net-next,v8,2/3] net: tcp: un-pin the tw_timer
    https://git.kernel.org/netdev/net-next/c/c75ad7c759cc
  - [net-next,v8,3/3] tcp: move inet_twsk_schedule helper out of header
    https://git.kernel.org/netdev/net-next/c/f81d0dd2fde3

You are awesome, thank you!