mbox series

[iwl-next,v2,0/5] ice: add standard stats

Message ID 20240606224701.359706-1-jesse.brandeburg@intel.com (mailing list archive)
Headers show
Series ice: add standard stats | expand

Message

Jesse Brandeburg June 6, 2024, 10:46 p.m. UTC
The main point of this series is to implement the standard stats for the
ice driver, but also add a related documentation fix and finish the
series off with a cleanup that removes a bunch of code.

Changelog:
v2: address review comments on 1/5 (Jakub) regarding backticks,
    fix email address for one reviewer in commit message
    pick up some reviewed-bys from the list
v1: https://lore.kernel.org/netdev/20240604221327.299184-1-jesse.brandeburg@intel.com/

Jesse Brandeburg (5):
  net: docs: add missing features that can have stats
  ice: implement ethtool standard stats
  ice: add tracking of good transmit timestamps
  ice: implement transmit hardware timestamp statistics
  ice: refactor to use helpers

 Documentation/networking/statistics.rst       |   4 +-
 drivers/net/ethernet/intel/ice/ice_ethtool.c  | 138 ++++++++++++++----
 .../net/ethernet/intel/ice/ice_flex_pipe.c    |   8 +-
 drivers/net/ethernet/intel/ice/ice_lag.c      |   5 +-
 drivers/net/ethernet/intel/ice/ice_main.c     |  10 +-
 drivers/net/ethernet/intel/ice/ice_ptp.c      |   9 ++
 drivers/net/ethernet/intel/ice/ice_ptp.h      |   1 +
 drivers/net/ethernet/intel/ice/ice_sriov.c    |   3 +-
 drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
 9 files changed, 132 insertions(+), 47 deletions(-)


base-commit: 95cd03f32a1680f693b291da920ab5d3f9d8c5c1

Comments

Pucha, HimasekharX Reddy July 23, 2024, 3:03 a.m. UTC | #1
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Jesse Brandeburg
> Sent: Friday, June 7, 2024 4:17 AM
> To: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Cc: linux-doc@vger.kernel.org; corbet@lwn.net
> Subject: [Intel-wired-lan] [PATCH iwl-next v2 0/5] ice: add standard stats
>
> The main point of this series is to implement the standard stats for the ice driver, but also add a related documentation fix and finish the series off with a cleanup that removes a bunch of code.
>
> Changelog:
> v2: address review comments on 1/5 (Jakub) regarding backticks,
>     fix email address for one reviewer in commit message
>     pick up some reviewed-bys from the list
> v1: https://lore.kernel.org/netdev/20240604221327.299184-1-jesse.brandeburg@intel.com/
>
> Jesse Brandeburg (5):
>   net: docs: add missing features that can have stats
>   ice: implement ethtool standard stats
>   ice: add tracking of good transmit timestamps
>   ice: implement transmit hardware timestamp statistics
>   ice: refactor to use helpers
>
>  Documentation/networking/statistics.rst       |   4 +-
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  | 138 ++++++++++++++----
>  .../net/ethernet/intel/ice/ice_flex_pipe.c    |   8 +-
>  drivers/net/ethernet/intel/ice/ice_lag.c      |   5 +-
>  drivers/net/ethernet/intel/ice/ice_main.c     |  10 +-
>  drivers/net/ethernet/intel/ice/ice_ptp.c      |   9 ++
>  drivers/net/ethernet/intel/ice/ice_ptp.h      |   1 +
>  drivers/net/ethernet/intel/ice/ice_sriov.c    |   3 +-
>  drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
>  9 files changed, 132 insertions(+), 47 deletions(-)
>
>
> base-commit: 95cd03f32a1680f693b291da920ab5d3f9d8c5c1
> --
> 2.43.0
>

Not able to see stats with this series of patches.

$ sudo ethtool -I -T eth0
Time stamping parameters for eth0:
Capabilities:
        hardware-transmit
        software-transmit
        hardware-receive
        software-receive
        software-system-clock
        hardware-raw-clock
PTP Hardware Clock: 0
Hardware Transmit Timestamp Modes:
        off
        on
Hardware Receive Filter Modes:
        none
        all