[net-next,v13,00/13] Introduce PHY listing and link_topology tracking

Message

Maxime Chevallier July 1, 2024, 1:17 p.m. UTC

Hello everyone,

This is V14 on the phy_link_topology series, aiming at supporting
ethernet devices where multiple PHYs sit between the MAC and the
front-facing port. I've addressed comments, reviews and bug reports in
that series (thanks Jakub, Andrew, Russell and Marc for stepping-in for
V13 review, tests and discussions).

The notable changes in V14 are :

 - Fixed some typos reported by Jakub
 - Don't copy the phy_device_node in the dump iterations (patch 7)
 - Don't call ethnl_parse_header_dev_put() inconditionally for dumps
   (Thanks Marc for the report) (patch 7)
 - Don't store the phy_device pointer in the ethnl_req_info, instead
   only store the index (patch 5)
 - Add dedicated helper to get the phy from the req_info, enforcing
   rtnl_lock() to be held (patch 5)
 - Make use of that header in commands that rely on it (patches 9 to 12)

Due to the rework of the way we get the phy_device from the ethnl
request, I dropped the reviewed-by on patches 9 to 12 as well as on
patches 5 and 7 that were heavily reworked.

As a remainder, here's what the PHY listings would look like :
 - eth0 has a 88x3310 acting as media converter, and an SFP module with
   an embedded 88e1111 PHY
 - eth2 has a 88e1510 PHY

# ethtool --show-phys *

PHY for eth0:
PHY index: 1
Driver name: mv88x3310
PHY device name: f212a600.mdio-mii:00
Downstream SFP bus name: sfp-eth0
PHY id: 0
Upstream type: MAC

PHY for eth0:
PHY index: 2
Driver name: Marvell 88E1111
PHY device name: i2c:sfp-eth0:16
PHY id: 21040322
Upstream type: PHY
Upstream PHY index: 1
Upstream SFP name: sfp-eth0

PHY for eth2:
PHY index: 1
Driver name: Marvell 88E1510
PHY device name: f212a200.mdio-mii:00
PHY id: 21040593
Upstream type: MAC

Ethtool patches : https://github.com/minimaxwell/ethtool/tree/mc/topo-v14

Link to V13: https://lore.kernel.org/netdev/[e-mail]/
Link to v12: https://lore.kernel.org/netdev/[e-mail]/
Link to v11: https://lore.kernel.org/netdev/[e-mail]/
Link to V10: https://lore.kernel.org/netdev/[e-mail]/
Link to V9: https://lore.kernel.org/netdev/[e-mail]/
Link to V8: https://lore.kernel.org/netdev/[e-mail]/
Link to V7: https://lore.kernel.org/netdev/[e-mail]/
Link to V6: https://lore.kernel.org/netdev/[e-mail]/
Link to V5: https://lore.kernel.org/netdev/[e-mail]/
Link to V4: https://lore.kernel.org/netdev/[e-mail]/
Link to V3: https://lore.kernel.org/netdev/[e-mail]/
Link to V2: https://lore.kernel.org/netdev/[e-mail]/
Link to V1: https://lore.kernel.org/netdev/[e-mail]/

More discussions on specific issues that happened in 6.9-rc:

https://lore.kernel.org/netdev/[e-mail]/
https://lore.kernel.org/netdev/[e-mail]/
https://lore.kernel.org/netdev/[e-mail]/

Maxime Chevallier (13):
  net: phy: Introduce ethernet link topology representation
  net: sfp: pass the phy_device when disconnecting an sfp module's PHY
  net: phy: add helpers to handle sfp phy connect/disconnect
  net: sfp: Add helper to return the SFP bus name
  net: ethtool: Allow passing a phy index for some commands
  netlink: specs: add phy-index as a header parameter
  net: ethtool: Introduce a command to list PHYs on an interface
  netlink: specs: add ethnl PHY_GET command set
  net: ethtool: plca: Target the command to the requested PHY
  net: ethtool: pse-pd: Target the command to the requested PHY
  net: ethtool: cable-test: Target the command to the requested PHY
  net: ethtool: strset: Allow querying phy stats by index
  Documentation: networking: document phy_link_topology

 Documentation/netlink/specs/ethtool.yaml      |  62 ++++
 Documentation/networking/ethtool-netlink.rst  |  52 +++
 Documentation/networking/index.rst            |   1 +
 .../networking/phy-link-topology.rst          | 121 +++++++
 MAINTAINERS                                   |   1 +
 drivers/net/phy/Makefile                      |   2 +-
 drivers/net/phy/marvell-88x2222.c             |   2 +
 drivers/net/phy/marvell.c                     |   2 +
 drivers/net/phy/marvell10g.c                  |   2 +
 drivers/net/phy/phy_device.c                  |  48 +++
 drivers/net/phy/phy_link_topology.c           | 105 ++++++
 drivers/net/phy/phylink.c                     |   3 +-
 drivers/net/phy/qcom/at803x.c                 |   2 +
 drivers/net/phy/qcom/qca807x.c                |   2 +
 drivers/net/phy/sfp-bus.c                     |  15 +-
 include/linux/netdevice.h                     |   4 +-
 include/linux/phy.h                           |   6 +
 include/linux/phy_link_topology.h             |  82 +++++
 include/linux/sfp.h                           |   8 +-
 include/uapi/linux/ethtool.h                  |  16 +
 include/uapi/linux/ethtool_netlink.h          |  21 ++
 net/core/dev.c                                |  15 +
 net/ethtool/Makefile                          |   3 +-
 net/ethtool/cabletest.c                       |  35 +-
 net/ethtool/netlink.c                         |  66 +++-
 net/ethtool/netlink.h                         |  33 ++
 net/ethtool/phy.c                             | 312 ++++++++++++++++++
 net/ethtool/plca.c                            |  30 +-
 net/ethtool/pse-pd.c                          |  30 +-
 net/ethtool/strset.c                          |  24 +-
 30 files changed, 1055 insertions(+), 50 deletions(-)
 create mode 100644 Documentation/networking/phy-link-topology.rst
 create mode 100644 drivers/net/phy/phy_link_topology.c
 create mode 100644 include/linux/phy_link_topology.h
 create mode 100644 net/ethtool/phy.c

Comments

Maxime Chevallier July 1, 2024, 1:23 p.m. UTC | #1

Hi everyone,

On Mon,  1 Jul 2024 15:17:46 +0200
Maxime Chevallier <[e-mail]> wrote:

> Hello everyone,
> 
> This is V14 on the phy_link_topology series

	[PATCH net-next v13 00/13] Introduce PHY listing and link_topology tracking

(small typo in the cover-letter subject, this is indeed V14)

Maxime