mbox series

[RESEND,net-next,v3,0/4] net: phy: aquantia: enable support for aqr115c

Message ID 20240708075023.14893-1-brgl@bgdev.pl (mailing list archive)
Headers show
Series net: phy: aquantia: enable support for aqr115c | expand

Message

Bartosz Golaszewski July 8, 2024, 7:50 a.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Resending rebased on top of current net-next.

This series addesses two issues with the aqr115c PHY on Qualcomm
sa8775p-ride-r3 board and adds support for this PHY to the aquantia driver.

While the manufacturer calls the 2.5G PHY mode OCSGMII, we reuse the existing
2500BASEX mode in the kernel to avoid extending the uAPI.

It took me a while to resend because I noticed an issue with the PHY coming
out of suspend with no possible interfaces listed and tracked it to the
GLOBAL_CFG registers for different modes returning 0. A workaround has been
added to the series. Unfortunately the HPG doesn't mention a proper way of
doing it or even mention any such issue at all.

Changes since v2:
- add a patch that addresses an issue with GLOBAL_CFG registers returning 0
- reuse aqr113c_config_init() for aqr115c
- improve commit messages, give more details on the 2500BASEX mode reuse
Link to v2: https://lore.kernel.org/lkml/Zn4Nq1QvhjAUaogb@makrotopia.org/T/

Changes since v1:
- split out the PHY patches into their own series
- don't introduce new mode (OCSGMII) but use existing 2500BASEX instead
- split the wait-for-FW patch into two: one renaming and exporting the
  relevant function and the second using it before checking the FW ID
Link to v1: https://lore.kernel.org/linux-arm-kernel/20240619184550.34524-1-brgl@bgdev.pl/T/

Bartosz Golaszewski (4):
  net: phy: aquantia: rename and export aqr107_wait_reset_complete()
  net: phy: aquantia: wait for FW reset before checking the vendor ID
  net: phy: aquantia: wait for the GLOBAL_CFG to start returning real
    values
  net: phy: aquantia: add support for aqr115c

 drivers/net/phy/aquantia/aquantia.h          |  2 +
 drivers/net/phy/aquantia/aquantia_firmware.c |  4 ++
 drivers/net/phy/aquantia/aquantia_main.c     | 40 ++++++++++++++++++--
 3 files changed, 42 insertions(+), 4 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org July 10, 2024, 10:20 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon,  8 Jul 2024 09:50:19 +0200 you wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Resending rebased on top of current net-next.
> 
> This series addesses two issues with the aqr115c PHY on Qualcomm
> sa8775p-ride-r3 board and adds support for this PHY to the aquantia driver.
> 
> [...]

Here is the summary with links:
  - [RESEND,net-next,v3,1/4] net: phy: aquantia: rename and export aqr107_wait_reset_complete()
    https://git.kernel.org/netdev/net-next/c/663117327a39
  - [RESEND,net-next,v3,2/4] net: phy: aquantia: wait for FW reset before checking the vendor ID
    https://git.kernel.org/netdev/net-next/c/ad649a1fac37
  - [RESEND,net-next,v3,3/4] net: phy: aquantia: wait for the GLOBAL_CFG to start returning real values
    https://git.kernel.org/netdev/net-next/c/708405f3e56e
  - [RESEND,net-next,v3,4/4] net: phy: aquantia: add support for aqr115c
    https://git.kernel.org/netdev/net-next/c/0ebc581f8a4b

You are awesome, thank you!