From patchwork Tue Jul 30 11:59:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alexis_Lothor=C3=A9_=28eBPF_Foundation=29?= X-Patchwork-Id: 13747301 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC7871991D2; Tue, 30 Jul 2024 11:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722340776; cv=none; b=Lk492fqt5eqiHkkBGpI6opnPnT5TpHFLvFvSdQma8x2X/IFB2qdY9ZKw10IvH5CXoA6tgq/gplwwA736sSTxfsXZ2/b58d1lQNumeFaHseY6V/G/+YcoUTjNXjhenJd2DXe8mbmi0lgJc/FvyOBmDYCuRkoEAo5nXX3imgasEgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722340776; c=relaxed/simple; bh=ImsVvn95a7wmI+VgxyjxxMmcJ46XUfj/a4OGo0FVYUs=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=HSh2kkkM/5OOxnV4oLlUyk7aN0hDRVORV7r3fKMk6A6wRQQh3fZ0p9kzxlu9FBpRV78WJyjxr20MET1gAw1kJkeCCIKTNRYz2l8FPdk3yBSEyk12bKbKJ6CAcD2ohYoypcKi4D5GF4jzJMQCirxYwNtrSeEWs7rmSFsrycm79dg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=PLHJWka/; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="PLHJWka/" Received: by mail.gandi.net (Postfix) with ESMTPSA id E9B7E60007; Tue, 30 Jul 2024 11:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1722340765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NCa5IvwCZ/R5PxPuaVMF6j6v8F/8/2nc8Pm1hBqQc/Q=; b=PLHJWka/Jkyt4G7EsbQ3YCBQblxovDTzPPfv0XjWHksTeXPxKI7vCI+SATa0/xIbYjthj7 +yW4NBdPJWcKLYMhOKWnRWmQt+Wg+51AsmGcbnFSSbYujauJstUSSQCpO9SY9vNqH/yroG wX5EHly3M28/O8iwkLcLFRwHNcMU3bxNalLPpEP8sQMGymt+aeZs/3AdfYl2pJKI7w9JrS j2muesjzFWY6PKC5+RtBLLdwdRuG0xKM+Ujy18VxuDdtKWezqaw5cPUUXYy5m7mbOt7zwt x+O3yPq/vcw+Ft98NbfcMWjwAUZva0+VvdXfr7Q2M6zQ+ar3724xIzkkDYqtQA== From: =?utf-8?q?Alexis_Lothor=C3=A9_=28eBPF_Foundation=29?= Subject: [PATCH bpf-next v3 0/3] selftests/bpf: convert test_dev_cgroup to test_progs Date: Tue, 30 Jul 2024 13:59:10 +0200 Message-Id: <20240730-convert_dev_cgroup-v3-0-93e573b74357@bootlin.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAI7VqGYC/23N0QrCIBgF4FcJrzOc02111XtEjPmrm1A61GQx9 u6JdFGwy8PhfGdFQXmjArocVuRVMsE4m0N9PCCYBjsqbGTOiBLKSEtrDM4m5WMvVeph9O4144Y 1TBBZt7oaUB7OXmmzFPSGxKyxVUtE99xMJkTn3+UtVaX/wnwPThUmmEIHQrKuBcauwrn4MPYE7 lnARH+R8y5CM8Kg0kA4JZzxf2Tbtg+0uTovBQEAAA== To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan Cc: ebpf@linuxfoundation.org, Thomas Petazzoni , Alan Maguire , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?A?= =?utf-8?q?lexis_Lothor=C3=A9_=28eBPF_Foundation=29?= X-Mailer: b4 0.14.1 X-GND-Sasl: alexis.lothore@bootlin.com X-Patchwork-Delegate: bpf@iogearbox.net Hello, this small series aims to integrate test_dev_cgroup in test_progs so it could be run automatically in CI. The new version brings a few differences with the current one: - test now uses directly syscalls instead of wrapping commandline tools into system() calls - test_progs manipulates /dev/null (eg: redirecting test logs into it), so disabling access to it in the bpf program confuses the tests. To fix this, the first commit modifies the bpf program to allow access to char devices 1:3 (/dev/null), and disable access to char devices 1:5 (/dev/zero) - once test is converted, add a small subtest to also check for device type interpretation (char or block) - paths used in mknod tests are now in /dev instead of /tmp: due to the CI runner organisation and mountpoints manipulations, trying to create nodes in /tmp leads to errors unrelated to the test (ie, mknod calls refused by kernel, not the bpf program). I don't understand exactly the root cause at the deepest point (all I see in CI is an -ENXIO error on mknod when trying to create the node in tmp, and I can not make sense out of it neither replicate it locally), so I would gladly take inputs from anyone more educated than me about this. The new test_progs part has been tested in a local qemu environment as well as in upstream CI: ./test_progs -a cgroup_dev 47/1 cgroup_dev/allow-mknod:OK 47/2 cgroup_dev/allow-read:OK 47/3 cgroup_dev/allow-write:OK 47/4 cgroup_dev/deny-mknod:OK 47/5 cgroup_dev/deny-read:OK 47/6 cgroup_dev/deny-write:OK 47/7 cgroup_dev/deny-mknod-wrong-type:OK 47 cgroup_dev:OK Summary: 1/7 PASSED, 0 SKIPPED, 0 FAILED --- Changes in v3: - delete mknod file only if it has been created - use bpf_program__attach_cgroup() instead of bpf_prog_attach - reorganize subtests order - collect review/ack tags from Alan and Stanislas - Link to v2: https://lore.kernel.org/r/20240729-convert_dev_cgroup-v2-0-4c1fc0520545@bootlin.com Changes in v2: - directly pass expected ret code to subtests instead of boolean pass/not pass - fix faulty fd check in subtest expected to fail on open - fix wrong subtest name - pass test buffer and corresponding size to read/write subtests - use correct series prefix - Link to v1: https://lore.kernel.org/r/20240725-convert_dev_cgroup-v1-0-2c8cbd487c44@bootlin.com --- Alexis Lothoré (eBPF Foundation) (3): selftests/bpf: do not disable /dev/null device access in cgroup dev test selftests/bpf: convert test_dev_cgroup to test_progs selftests/bpf: add wrong type test to cgroup dev tools/testing/selftests/bpf/.gitignore | 1 - tools/testing/selftests/bpf/Makefile | 2 - .../testing/selftests/bpf/prog_tests/cgroup_dev.c | 118 +++++++++++++++++++++ tools/testing/selftests/bpf/progs/dev_cgroup.c | 4 +- tools/testing/selftests/bpf/test_dev_cgroup.c | 85 --------------- 5 files changed, 120 insertions(+), 90 deletions(-) --- base-commit: 2107cb4bff1c21110ebf7a17458a918282c1a8c9 change-id: 20240723-convert_dev_cgroup-6464b0d37f1a Best regards,