| Message ID | 20240808-udp-gso-egress-from-tunnel-v4-0-f5c5b4149ab9@cloudflare.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Don't take HW USO path when packets can't be checksummed by device | expand |
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 08 Aug 2024 11:56:20 +0200 you wrote: > This series addresses a recent regression report from syzbot [1]. > > After enabling UDP_SEGMENT for egress devices which don't support checksum > offload [2], we need to tighten down the checks which let packets take the > HW USO path. > > The fix consists of two parts: > > [...] Here is the summary with links: - [net,v4,1/3] net: Make USO depend on CSUM offload https://git.kernel.org/netdev/net/c/2b2bc3bab158 - [net,v4,2/3] udp: Fall back to software USO if IPv6 extension headers are present https://git.kernel.org/netdev/net/c/30b03f2a0592 - [net,v4,3/3] selftests/net: Add coverage for UDP GSO with IPv6 extension headers https://git.kernel.org/netdev/net/c/1d2c46c1bc56 You are awesome, thank you!
This series addresses a recent regression report from syzbot [1]. After enabling UDP_SEGMENT for egress devices which don't support checksum offload [2], we need to tighten down the checks which let packets take the HW USO path. The fix consists of two parts: 1. don't let devices offer USO without checksum offload, and 2. force software USO fallback in presence of IPv6 extension headers. [1] https://lore.kernel.org/all/000000000000e1609a061d5330ce@google.com/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=10154dbded6d6a2fecaebdfda206609de0f121a9 Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com> --- Changes in v4: - Change Fixes tag in patch 1 (Willem) - Turn IP_CSUM_MASK define into a local (Willem) - has_ip_or_hw_csum -> netdev_has_ip_or_hw_csum (Willem) - Link to v3: https://lore.kernel.org/r/20240807-udp-gso-egress-from-tunnel-v3-0-8828d93c5b45@cloudflare.com Changes in v3: - Make USO depend on checksum offload (Willem) - Contain the bad offload warning fix within the USO callback (Willem) - Link to v2: https://lore.kernel.org/r/20240801-udp-gso-egress-from-tunnel-v2-0-9a2af2f15d8d@cloudflare.com Changes in v2: - Contain the fix inside the GSO stack after discussing with Willem - Rework tests after realizing the regression has nothing to do with tunnels - Link to v1: https://lore.kernel.org/r/20240725-udp-gso-egress-from-tunnel-v1-0-5e5530ead524@cloudflare.com --- Jakub Sitnicki (3): net: Make USO depend on CSUM offload udp: Fall back to software USO if IPv6 extension headers are present selftests/net: Add coverage for UDP GSO with IPv6 extension headers net/core/dev.c | 26 +++++++++++++++++--------- net/ipv4/udp_offload.c | 6 ++++++ tools/testing/selftests/net/udpgso.c | 25 ++++++++++++++++++++++++- 3 files changed, 47 insertions(+), 10 deletions(-)