| Message ID | 20240820140154.137876-1-shaojijie@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support of HIBMCGE Ethernet Driver | expand |
On Tue, 20 Aug 2024 22:01:43 +0800 Jijie Shao wrote: > This patch set adds the support of Hisilicon BMC Gigabit Ethernet Driver. > > This patch set includes basic Rx/Tx functionality. It also includes > the registration and interrupt codes. > > This work provides the initial support to the HIBMCGE and > would incrementally add features or enhancements. Does not build ERROR: modpost: "phy_attached_info" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "phy_ethtool_set_link_ksettings" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "phy_connect_direct" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "phy_ethtool_get_link_ksettings" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "phy_start" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "phy_remove_link_mode" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "phy_print_status" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "devm_mdiobus_alloc_size" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "mdiobus_get_phy" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! ERROR: modpost: "__devm_mdiobus_register" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! WARNING: modpost: suppressed 2 unresolved symbol warnings because there were too many)
on 2024/8/21 9:55, Jakub Kicinski wrote: > On Tue, 20 Aug 2024 22:01:43 +0800 Jijie Shao wrote: >> This patch set adds the support of Hisilicon BMC Gigabit Ethernet Driver. >> >> This patch set includes basic Rx/Tx functionality. It also includes >> the registration and interrupt codes. >> >> This work provides the initial support to the HIBMCGE and >> would incrementally add features or enhancements. > > Does not build > > ERROR: modpost: "phy_attached_info" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "phy_ethtool_set_link_ksettings" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "phy_connect_direct" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "phy_ethtool_get_link_ksettings" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "phy_start" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "phy_remove_link_mode" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "phy_print_status" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "devm_mdiobus_alloc_size" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "mdiobus_get_phy" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > ERROR: modpost: "__devm_mdiobus_register" [drivers/net/ethernet/hisilicon/hibmcge/hibmcge.ko] undefined! > WARNING: modpost: suppressed 2 unresolved symbol warnings because there were too many)Hi Hi Jakub: I can build successfully. Can you tell me your build command? I think the cause of this problem is that the PHYLIB is not selected in Kconfig. So I will add "select PHYLIB" in v3 Thanks, Jijie Shao
This patch set adds the support of Hisilicon BMC Gigabit Ethernet Driver. This patch set includes basic Rx/Tx functionality. It also includes the registration and interrupt codes. This work provides the initial support to the HIBMCGE and would incrementally add features or enhancements. --- ChangeLog: v1 -> v2: - fix build errors reported by kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202408192219.zrGff7n1-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202408200026.q20EuSHC-lkp@intel.com/ v1: https://lore.kernel.org/all/20240819071229.2489506-1-shaojijie@huawei.com/ RFC v2 -> v1: - Use FIELD_PREP/FIELD_GET instead of union, suggested by Andrew. - Delete unnecessary defensive code, suggested by Andrew. - A few other minor changes. RFC v2: https://lore.kernel.org/all/20240813135640.1694993-1-shaojijie@huawei.com/ RFC v1 -> RFC v2: - Replace linkmode_copy() with phy_remove_link_mode() to simplify the PHY configuration process, suggested by Andrew. - Delete hbg_get_link_status() from the scheduled task, suggested by Andrew. - Delete validation for mtu in hbg_net_change_mtu(), suggested by Andrew. - Delete validation for mac address in hbg_net_set_mac_address(), suggested by Andrew. - Use napi_complete_done() to simplify the process, suggested by Joe Damato. - Use ethtool_op_get_link(), phy_ethtool_get_link_ksettings(), and phy_ethtool_set_link_ksettings() to simplify the code, suggested by Andrew. - Add the null pointer check on the return value of pcim_iomap_table(), suggested by Jonathan. - Add the check on the return value of phy_connect_direct(), suggested by Jonathan. - Adjusted the layout to place the fields and register definitions in one place, suggested by Jonathan. - Replace request_irq with devm_request_irq, suggested by Jonathan. - Replace BIT_MASK() with BIT(), suggested by Jonathan. - Introduce irq_handle in struct hbg_irq_info in advance to reduce code changes, suggested by Jonathan. - Delete workqueue for this patch set, suggested by Jonathan. - Support to compile this driver on all arch in Kconfig, suggested by Andrew and Jonathan. - Add a patch to add is_valid_ether_addr check in dev_set_mac_address, suggested by Andrew. - Use macro instead of inline to fix the warning about compile-time constant in FIELD_PREP(), reported by Simon Horman. - A few other minor changes. RFC v1: https://lore.kernel.org/all/20240731094245.1967834-1-shaojijie@huawei.com/ --- Jijie Shao (11): net: hibmcge: Add pci table supported in this module net: hibmcge: Add read/write registers supported through the bar space net: hibmcge: Add mdio and hardware configuration supported in this module net: hibmcge: Add interrupt supported in this module net: hibmcge: Implement some .ndo functions net: hibmcge: Implement .ndo_start_xmit function net: hibmcge: Implement rx_poll function to receive packets net: hibmcge: Implement some ethtool_ops functions net: hibmcge: Add a Makefile and update Kconfig for hibmcge net: hibmcge: Add maintainer for hibmcge net: add is_valid_ether_addr check in dev_set_mac_address MAINTAINERS | 7 + drivers/net/ethernet/hisilicon/Kconfig | 16 +- drivers/net/ethernet/hisilicon/Makefile | 1 + .../net/ethernet/hisilicon/hibmcge/Makefile | 10 + .../ethernet/hisilicon/hibmcge/hbg_common.h | 138 ++++++ .../ethernet/hisilicon/hibmcge/hbg_ethtool.c | 17 + .../ethernet/hisilicon/hibmcge/hbg_ethtool.h | 11 + .../net/ethernet/hisilicon/hibmcge/hbg_hw.c | 285 ++++++++++++ .../net/ethernet/hisilicon/hibmcge/hbg_hw.h | 57 +++ .../net/ethernet/hisilicon/hibmcge/hbg_irq.c | 123 ++++++ .../net/ethernet/hisilicon/hibmcge/hbg_irq.h | 11 + .../net/ethernet/hisilicon/hibmcge/hbg_main.c | 232 ++++++++++ .../net/ethernet/hisilicon/hibmcge/hbg_mdio.c | 251 +++++++++++ .../net/ethernet/hisilicon/hibmcge/hbg_mdio.h | 13 + .../net/ethernet/hisilicon/hibmcge/hbg_reg.h | 143 ++++++ .../net/ethernet/hisilicon/hibmcge/hbg_txrx.c | 418 ++++++++++++++++++ .../net/ethernet/hisilicon/hibmcge/hbg_txrx.h | 37 ++ net/core/dev.c | 2 + 18 files changed, 1771 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/Makefile create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_common.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_mdio.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_mdio.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_reg.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.h