mbox series

[net-next,0/2] tcp: take better care of tw_substate and tw_rcv_nxt

Message ID 20240827015250.3509197-1-edumazet@google.com (mailing list archive)
Headers show
Series tcp: take better care of tw_substate and tw_rcv_nxt | expand

Message

Eric Dumazet Aug. 27, 2024, 1:52 a.m. UTC 
While reviewing Jason Xing recent commit (0d9e5df4a257 "tcp: avoid reusing
FIN_WAIT2 when trying to find port in connect() process") I saw
we could remove the volatile qualifier for tw_substate field,
and I also added missing data-race annotations around tcptw->tw_rcv_nxt.

Eric Dumazet (2):
  tcp: remove volatile qualifier on tw_substate
  tcp: annotate data-races around tcptw->tw_rcv_nxt

 include/net/inet_timewait_sock.h |  2 +-
 net/ipv4/inet_diag.c             |  4 ++--
 net/ipv4/tcp_ipv4.c              |  6 +++---
 net/ipv4/tcp_minisocks.c         | 31 +++++++++++++++++--------------
 net/ipv6/tcp_ipv6.c              |  5 +++--
 5 files changed, 26 insertions(+), 22 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 29, 2024, 12:20 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 27 Aug 2024 01:52:48 +0000 you wrote:
> While reviewing Jason Xing recent commit (0d9e5df4a257 "tcp: avoid reusing
> FIN_WAIT2 when trying to find port in connect() process") I saw
> we could remove the volatile qualifier for tw_substate field,
> and I also added missing data-race annotations around tcptw->tw_rcv_nxt.
> 
> Eric Dumazet (2):
>   tcp: remove volatile qualifier on tw_substate
>   tcp: annotate data-races around tcptw->tw_rcv_nxt
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] tcp: remove volatile qualifier on tw_substate
    https://git.kernel.org/netdev/net-next/c/3e5cbbb1fb9a
  - [net-next,2/2] tcp: annotate data-races around tcptw->tw_rcv_nxt
    https://git.kernel.org/netdev/net-next/c/c0a11493ee61

You are awesome, thank you!