[net,v7,0/3] ptp: ocp: fix serial port information export

Message

Vadim Fedorenko Aug. 29, 2024, 6:36 p.m. UTC

Starting v6.8 the serial port subsystem changed the hierarchy of devices
and symlinks are not working anymore. Previous discussion made it clear
that the idea of symlinks for tty devices was wrong by design [1].
This series implements additional attributes to expose the information
and removes symlinks for tty devices.

[1] https://lore.kernel.org/netdev/2024060503-subsonic-pupil-bbee@gregkh/

v6 -> v7:
- fix issues with applying patches
v5 -> v6:
- split conversion to array to separate patch per Jiri's feedback
- move changelog to cover letter
v4 -> v5:
- remove unused variable in ptp_ocp_tty_show
v3 -> v4:
- re-organize info printing to use ptp_ocp_tty_port_name()
- keep uintptr_t to be consistent with other code
v2 -> v3:
- replace serial ports definitions with array and enum for index
- replace pointer math with direct array access
- nit in documentation spelling
v1 -> v2:
- add Documentation/ABI changes

Vadim Fedorenko (3):
  ptp: ocp: convert serial ports to array
  ptp: ocp: adjust sysfs entries to expose tty information
  docs: ABI: update OCP TimeCard sysfs entries

 Documentation/ABI/testing/sysfs-timecard |  31 +++--
 drivers/ptp/ptp_ocp.c                    | 168 ++++++++++++++---------
 2 files changed, 119 insertions(+), 80 deletions(-)

Comments

Greg KH Sept. 3, 2024, 8:40 a.m. UTC | #1

On Thu, Aug 29, 2024 at 11:36:00AM -0700, Vadim Fedorenko wrote:
> Starting v6.8 the serial port subsystem changed the hierarchy of devices
> and symlinks are not working anymore. Previous discussion made it clear
> that the idea of symlinks for tty devices was wrong by design [1].
> This series implements additional attributes to expose the information
> and removes symlinks for tty devices.
> 
> [1] https://lore.kernel.org/netdev/2024060503-subsonic-pupil-bbee@gregkh/
> 
> v6 -> v7:
> - fix issues with applying patches
> v5 -> v6:
> - split conversion to array to separate patch per Jiri's feedback
> - move changelog to cover letter
> v4 -> v5:
> - remove unused variable in ptp_ocp_tty_show
> v3 -> v4:
> - re-organize info printing to use ptp_ocp_tty_port_name()
> - keep uintptr_t to be consistent with other code
> v2 -> v3:
> - replace serial ports definitions with array and enum for index
> - replace pointer math with direct array access
> - nit in documentation spelling
> v1 -> v2:
> - add Documentation/ABI changes
> 
> Vadim Fedorenko (3):
>   ptp: ocp: convert serial ports to array
>   ptp: ocp: adjust sysfs entries to expose tty information
>   docs: ABI: update OCP TimeCard sysfs entries
> 
>  Documentation/ABI/testing/sysfs-timecard |  31 +++--
>  drivers/ptp/ptp_ocp.c                    | 168 ++++++++++++++---------
>  2 files changed, 119 insertions(+), 80 deletions(-)

Thanks for doing this:

Reviewed-by: Greg Kroah-Hartman <[e-mail]>

[e-mail] Sept. 3, 2024, 1:50 p.m. UTC | #2

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <[e-mail]>:

On Thu, 29 Aug 2024 11:36:00 -0700 you wrote:
> Starting v6.8 the serial port subsystem changed the hierarchy of devices
> and symlinks are not working anymore. Previous discussion made it clear
> that the idea of symlinks for tty devices was wrong by design [1].
> This series implements additional attributes to expose the information
> and removes symlinks for tty devices.
> 
> [1] https://lore.kernel.org/netdev/2024060503-subsonic-pupil-bbee@gregkh/
> 
> [...]

Here is the summary with links:
  - [net,v7,1/3] ptp: ocp: convert serial ports to array
    https://git.kernel.org/netdev/net/c/d7875b4b078f
  - [net,v7,2/3] ptp: ocp: adjust sysfs entries to expose tty information
    https://git.kernel.org/netdev/net/c/82ace0c8fe9b
  - [net,v7,3/3] docs: ABI: update OCP TimeCard sysfs entries
    https://git.kernel.org/netdev/net/c/40bec579d4c7

You are awesome, thank you!