mbox series

[RFC,0/2] ptp: add control over HW timestamp latch point

Message ID 20241003213754.926691-1-arkadiusz.kubalewski@intel.com (mailing list archive)
Headers show
Series ptp: add control over HW timestamp latch point | expand

Message

Arkadiusz Kubalewski Oct. 3, 2024, 9:37 p.m. UTC 
HW support of PTP/timesync solutions in network PHY chips can be
achieved with two different approaches, the timestamp maybe latched
either in the beginning or after the Start of Frame Delimiter (SFD) [1].

Allow ptp device drivers to provide user with control over the timestamp
latch point.

Arkadiusz Kubalewski (2):
  ptp: add control over HW timestamp latch point
  ice: ptp: add control over HW timestamp latch point

 drivers/net/ethernet/intel/ice/ice_ptp.c    | 48 +++++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 52 +++++++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h |  3 +-
 drivers/ptp/ptp_sysfs.c                     | 44 +++++++++++++++++
 include/linux/ptp_clock_kernel.h            | 26 +++++++++++
 5 files changed, 172 insertions(+), 1 deletion(-)

Comments

Richard Cochran Oct. 7, 2024, 4:06 p.m. UTC | #1 
On Thu, Oct 03, 2024 at 11:37:52PM +0200, Arkadiusz Kubalewski wrote:
> HW support of PTP/timesync solutions in network PHY chips can be
> achieved with two different approaches, the timestamp maybe latched
> either in the beginning or after the Start of Frame Delimiter (SFD) [1].
> 
> Allow ptp device drivers to provide user with control over the timestamp
> latch point.

This looks okay to me.

Sorry for the late reply, but I'm travelling untill Oct 11 and may not
response to messages right away.

Thanks,
Richard
Arkadiusz Kubalewski Oct. 8, 2024, 7:06 p.m. UTC | #2 
>From: Richard Cochran <richardcochran@gmail.com>
>Sent: Monday, October 7, 2024 6:07 PM
>
>On Thu, Oct 03, 2024 at 11:37:52PM +0200, Arkadiusz Kubalewski wrote:
>> HW support of PTP/timesync solutions in network PHY chips can be
>> achieved with two different approaches, the timestamp maybe latched
>> either in the beginning or after the Start of Frame Delimiter (SFD) [1].
>>
>> Allow ptp device drivers to provide user with control over the
>> timestamp latch point.
>
>This looks okay to me.
>
>Sorry for the late reply, but I'm travelling untill Oct 11 and may not
>response to messages right away.
>
>Thanks,
>Richard

Hi Richard,

Not a problem.
Great to hear that it looks good for you, I will prepare proper patches soon.

Thank you!
Arkadiusz