From patchwork Tue Oct 8 02:23:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jijie Shao X-Patchwork-Id: 13825570 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3A8913AC1; Tue, 8 Oct 2024 02:30:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.255 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728354630; cv=none; b=j70qKFVXUzW9yBkyTd+z52A3991izKzgCsn+Gb1zQoD8mMUJFheGiLyHleggvxqzRjxeIUYNXrPcN5j4Kujv3cncKNyFH5flmshiMqG/c6cTyIHHrHkz0guVSKEgI7Nfob2mI5+0HM5sf7GQuZWkCyyGi7PLBdXhEnNJRBn7u/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728354630; c=relaxed/simple; bh=/OoaXPtlVv+/+BlMlytmhUjnwdJIbJv1LVKl8t6AJmI=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=AkbYgxKXf6govTu5oVwG0cGkm1IJU1iyU6F2pDVyGLLhN0r0AACO/bfNcJnxVVmlNMKw3JtWJzKW8vejHueZZvNZ2bQSRKdgyLDxE9lniBLzsHIf+L31AxrsTj3FyojeL6N+jDPC/OJ0IVUpq6TDL20LcWUTakbvyDPpz4GFPxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.255 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4XN0Lz2mhQz1T8Gv; Tue, 8 Oct 2024 10:28:43 +0800 (CST) Received: from kwepemm000007.china.huawei.com (unknown [7.193.23.189]) by mail.maildlp.com (Postfix) with ESMTPS id E4FEC1800CF; Tue, 8 Oct 2024 10:30:24 +0800 (CST) Received: from localhost.localdomain (10.90.30.45) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 8 Oct 2024 10:30:23 +0800 From: Jijie Shao To: , , , CC: , , , , , , , , , , , , , , , , , , Subject: [PATCH V11 net-next 00/10] Add support of HIBMCGE Ethernet Driver Date: Tue, 8 Oct 2024 10:23:48 +0800 Message-ID: <20241008022358.863393-1-shaojijie@huawei.com> X-Mailer: git-send-email 2.30.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm000007.china.huawei.com (7.193.23.189) X-Patchwork-Delegate: kuba@kernel.org This patch set adds the support of Hisilicon BMC Gigabit Ethernet Driver. This patch set includes basic Rx/Tx functionality. It also includes the registration and interrupt codes. This work provides the initial support to the HIBMCGE and would incrementally add features or enhancements. --- ChangeLog: v10 -> v11: - Delete devm_netdev_alloc_pcpu_stats to prevent memory leak, suggested by Jakub. - Use the same pattern for 'control' and 'ctrl', suggested by Christophe JAILLET. - hbg_mdio_init_hw() return void because no error patch, suggested by Christophe JAILLET. - Fix a syntax error in comment, suggested by Christophe JAILLET. - return -EBUSY in ndo.change_mtu if interface is running, suggested by Jakub. - Remove unnecessary declares for struct, suggested by Jakub. - fix budget to 128 in TX napi.poll(), suggested by Jakub. - Not call napi_complete_done() if packet_done >= budget in napi.poll(), suggested by Jakub. - Use devm_kmalloc() instead of devm_kzalloc() for tx_ring->tout_log_buf, suggested by Christophe JAILLET. - Not refill the buffers if budget is 0 in RX napi.poll(), suggested by Jakub. - Remove "ccflags-y += -I$(src)" from Makefile, suggested by Jakub. - Use napi_gro_receive() instead of netif_receive_skb(), suggested by Jakub. - Remove ndo.get_stats64() because dev_get_tstats64() do same thing. v10: https://lore.kernel.org/all/20240912025127.3912972-1-shaojijie@huawei.com/ v9 -> v10: - Drop patch "add ndo_validate_addr check in dev_set_mac_address" - Add validation for mac address in hbg_net_set_mac_address() - Add "select MOTORCOMM_PHY" and "select REALTEK_PHY" in Kconfig. - Use ETH_DATA_LEN instead of HBG_DEFAULT_MTU_SIZE, suggested by Andrew. - Delete error description about genphy in commit log, suggested by Andrew. v9: https://lore.kernel.org/all/20240910075942.1270054-1-shaojijie@huawei.com/ v8 -> v9: - Remove HBG_NIC_STATE_OPEN in ndo.open() and ndo.stop(), suggested by Kalesh and Andrew v8: https://lore.kernel.org/all/20240909023141.3234567-1-shaojijie@huawei.com/ v7 -> v8: - Set netdev->pcpu_stat_type to NETDEV_PCPU_STAT_TSTATS, suggested by Jakub v7: https://lore.kernel.org/all/20240905143120.1583460-1-shaojijie@huawei.com/ v6 -> v7: - Move the define inside the function body to the top of the .c file, suggested by Paolo and Andrew. - Respect the reverse x-mas tree order, suggested by Paolo. - Add check for netif_txq_maybe_stop(), suggested by Paolo. - Use dev_sw_netstats_tx_add() instead of dev->stats, suggested by Paolo. - Modify net_dev to netdev, suggested by Paolo. v6: https://lore.kernel.org/all/20240830121604.2250904-12-shaojijie@huawei.com/ v5 -> v6: - Delete netif_carrier_off() in .ndo_open() and .ndo_stop(), suggested by Jakub and Andrew. - Remove hbg_txrx_init() from probe path, alloc ring buffer in .ndo_open(), and release ring buffer in .ndo_stop(), suggested by Jakub and Andrew. v5: https://lore.kernel.org/all/20240827131455.2919051-1-shaojijie@huawei.com/ v4 -> v5: - Delete unnecessary semicolon, suggested by Jakub. v4: https://lore.kernel.org/all/20240826081258.1881385-1-shaojijie@huawei.com/ v3 -> v4: - Delete INITED_STATE in priv, suggested by Andrew. - Delete unnecessary defensive code in hbg_phy_start() and hbg_phy_stop(), suggested by Andrew. v3: https://lore.kernel.org/all/20240822093334.1687011-1-shaojijie@huawei.com/ v2 -> v3: - Add "select PHYLIB" in Kconfig, reported by Jakub. - Use ndo_validate_addr() instead of is_valid_ether_addr() in dev_set_mac_address(), suggested by Jakub and Andrew. v2: https://lore.kernel.org/all/20240820140154.137876-1-shaojijie@huawei.com/ v1 -> v2: - fix build errors reported by kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202408192219.zrGff7n1-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202408200026.q20EuSHC-lkp@intel.com/ v1: https://lore.kernel.org/all/20240819071229.2489506-1-shaojijie@huawei.com/ RFC v2 -> v1: - Use FIELD_PREP/FIELD_GET instead of union, suggested by Andrew. - Delete unnecessary defensive code, suggested by Andrew. - A few other minor changes. RFC v2: https://lore.kernel.org/all/20240813135640.1694993-1-shaojijie@huawei.com/ RFC v1 -> RFC v2: - Replace linkmode_copy() with phy_remove_link_mode() to simplify the PHY configuration process, suggested by Andrew. - Delete hbg_get_link_status() from the scheduled task, suggested by Andrew. - Delete validation for mtu in hbg_net_change_mtu(), suggested by Andrew. - Delete validation for mac address in hbg_net_set_mac_address(), suggested by Andrew. - Use napi_complete_done() to simplify the process, suggested by Joe Damato. - Use ethtool_op_get_link(), phy_ethtool_get_link_ksettings(), and phy_ethtool_set_link_ksettings() to simplify the code, suggested by Andrew. - Add the check on the return value of phy_connect_direct(), suggested by Jonathan. - Adjusted the layout to place the fields and register definitions in one place, suggested by Jonathan. - Replace request_irq with devm_request_irq, suggested by Jonathan. - Replace BIT_MASK() with BIT(), suggested by Jonathan. - Introduce irq_handle in struct hbg_irq_info in advance to reduce code changes, suggested by Jonathan. - Delete workqueue for this patch set, suggested by Jonathan. - Support to compile this driver on all arch in Kconfig, suggested by Andrew and Jonathan. - Add a patch to add is_valid_ether_addr check in dev_set_mac_address, suggested by Andrew. - A few other minor changes. RFC v1: https://lore.kernel.org/all/20240731094245.1967834-1-shaojijie@huawei.com/ --- Jijie Shao (10): net: hibmcge: Add pci table supported in this module net: hibmcge: Add read/write registers supported through the bar space net: hibmcge: Add mdio and hardware configuration supported in this module net: hibmcge: Add interrupt supported in this module net: hibmcge: Implement some .ndo functions net: hibmcge: Implement .ndo_start_xmit function net: hibmcge: Implement rx_poll function to receive packets net: hibmcge: Implement some ethtool_ops functions net: hibmcge: Add a Makefile and update Kconfig for hibmcge net: hibmcge: Add maintainer for hibmcge MAINTAINERS | 7 + drivers/net/ethernet/hisilicon/Kconfig | 18 +- drivers/net/ethernet/hisilicon/Makefile | 1 + .../net/ethernet/hisilicon/hibmcge/Makefile | 8 + .../ethernet/hisilicon/hibmcge/hbg_common.h | 131 ++++++ .../ethernet/hisilicon/hibmcge/hbg_ethtool.c | 17 + .../ethernet/hisilicon/hibmcge/hbg_ethtool.h | 11 + .../net/ethernet/hisilicon/hibmcge/hbg_hw.c | 265 ++++++++++++ .../net/ethernet/hisilicon/hibmcge/hbg_hw.h | 59 +++ .../net/ethernet/hisilicon/hibmcge/hbg_irq.c | 126 ++++++ .../net/ethernet/hisilicon/hibmcge/hbg_irq.h | 11 + .../net/ethernet/hisilicon/hibmcge/hbg_main.c | 253 +++++++++++ .../net/ethernet/hisilicon/hibmcge/hbg_mdio.c | 219 ++++++++++ .../net/ethernet/hisilicon/hibmcge/hbg_mdio.h | 12 + .../net/ethernet/hisilicon/hibmcge/hbg_reg.h | 143 +++++++ .../net/ethernet/hisilicon/hibmcge/hbg_txrx.c | 405 ++++++++++++++++++ .../net/ethernet/hisilicon/hibmcge/hbg_txrx.h | 37 ++ 17 files changed, 1722 insertions(+), 1 deletion(-) create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/Makefile create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_common.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_mdio.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_mdio.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_reg.h create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c create mode 100644 drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.h