mbox series

[v1,0/7] devlink: minor cleanup

Message ID 20241018102009.10124-1-przemyslaw.kitszel@intel.com (mailing list archive)
Headers show
Series devlink: minor cleanup | expand

Message

Przemek Kitszel Oct. 18, 2024, 10:18 a.m. UTC
(Patch 1, 2) Add one helper shortcut to put u64 values into skb.
(Patch 3, 4) Minor cleanup for error codes.
(Patch 5, 6, 7) Remove some devlink_resource_*() usage and functions
		itself via replacing devlink_* variants by devl_* ones.

Przemek Kitszel (7):
  devlink: introduce devlink_nl_put_u64()
  devlink: use devlink_nl_put_u64() helper
  devlink: devl_resource_register(): differentiate error codes
  devlink: region: snapshot IDs: consolidate error values
  net: dsa: replace devlink resource registration calls by devl_
    variants
  devlink: remove unused devlink_resource_occ_get_register() and
    _unregister()
  devlink: remove unused devlink_resource_register()

 include/net/devlink.h       |  13 -----
 net/devlink/devl_internal.h |   5 ++
 net/devlink/dev.c           |  12 ++---
 net/devlink/dpipe.c         |  18 +++----
 net/devlink/health.c        |  25 ++++-----
 net/devlink/rate.c          |   8 +--
 net/devlink/region.c        |  15 +++---
 net/devlink/resource.c      | 101 +++++-------------------------------
 net/devlink/trap.c          |  34 +++++-------
 net/dsa/devlink.c           |  23 +++++---
 10 files changed, 83 insertions(+), 171 deletions(-)


base-commit: f87a17ed3b51fba4dfdd8f8b643b5423a85fc551

Comments

Jiri Pirko Oct. 18, 2024, 11:58 a.m. UTC | #1
Fri, Oct 18, 2024 at 12:18:29PM CEST, przemyslaw.kitszel@intel.com wrote:
>(Patch 1, 2) Add one helper shortcut to put u64 values into skb.
>(Patch 3, 4) Minor cleanup for error codes.
>(Patch 5, 6, 7) Remove some devlink_resource_*() usage and functions
>		itself via replacing devlink_* variants by devl_* ones.

Use get_maintainers script to get the cclist.
put "net-next" into [patch] brackets to indicate what tree you aim at.

Code-wise, looks okay to me:
set-
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Joe Damato Oct. 21, 2024, 7:51 p.m. UTC | #2
On Fri, Oct 18, 2024 at 12:18:29PM +0200, Przemek Kitszel wrote:
> (Patch 1, 2) Add one helper shortcut to put u64 values into skb.
> (Patch 3, 4) Minor cleanup for error codes.
> (Patch 5, 6, 7) Remove some devlink_resource_*() usage and functions
> 		itself via replacing devlink_* variants by devl_* ones.
> 
> Przemek Kitszel (7):
>   devlink: introduce devlink_nl_put_u64()
>   devlink: use devlink_nl_put_u64() helper
>   devlink: devl_resource_register(): differentiate error codes
>   devlink: region: snapshot IDs: consolidate error values
>   net: dsa: replace devlink resource registration calls by devl_
>     variants
>   devlink: remove unused devlink_resource_occ_get_register() and
>     _unregister()
>   devlink: remove unused devlink_resource_register()
> 
>  include/net/devlink.h       |  13 -----
>  net/devlink/devl_internal.h |   5 ++
>  net/devlink/dev.c           |  12 ++---
>  net/devlink/dpipe.c         |  18 +++----
>  net/devlink/health.c        |  25 ++++-----
>  net/devlink/rate.c          |   8 +--
>  net/devlink/region.c        |  15 +++---
>  net/devlink/resource.c      | 101 +++++-------------------------------
>  net/devlink/trap.c          |  34 +++++-------
>  net/dsa/devlink.c           |  23 +++++---
>  10 files changed, 83 insertions(+), 171 deletions(-)

Reviewed-by: Joe Damato <jdamato@fastly.com>