mbox series

[bpf-next,v2,0/4] Retire test_sock.c

Message ID 20241022152913.574836-1-jrife@google.com (mailing list archive)
Headers show
Series Retire test_sock.c | expand

Message

Jordan Rife Oct. 22, 2024, 3:29 p.m. UTC
This patch series migrates test cases out of test_sock.c to
prog_tests-style tests. It moves all BPF_CGROUP_INET4_POST_BIND and
BPF_CGROUP_INET6_POST_BIND test cases into a new prog_test,
sock_post_bind.c, while reimplementing all LOAD_REJECT test cases as
verifier tests in progs/verifier_sock.c. Finally, it moves remaining
BPF_CGROUP_INET_SOCK_CREATE test coverage into prog_tests/sock_create.c
before retiring test_sock.c completely.

Changes
=======
v1->v2:
- Remove superfluous verbose bool from the top of sock_post_bind.c.
- Use ASSERT_OK_FD instead of ASSERT_GE to test cgroup_fd validity.
- Run sock_post_bind tests in their own namespace, "sock_post_bind".

Jordan Rife (4):
  selftests/bpf: Migrate *_POST_BIND test cases to prog_tests
  selftests/bpf: Migrate LOAD_REJECT test cases to prog_tests
  selftests/bpf: Migrate BPF_CGROUP_INET_SOCK_CREATE test cases to
    prog_tests
  selftests/bpf: Retire test_sock.c

 tools/testing/selftests/bpf/.gitignore        |   1 -
 tools/testing/selftests/bpf/Makefile          |   3 +-
 .../selftests/bpf/prog_tests/sock_create.c    |  35 ++-
 .../sock_post_bind.c}                         | 256 +++++-------------
 .../selftests/bpf/progs/verifier_sock.c       |  60 ++++
 5 files changed, 150 insertions(+), 205 deletions(-)
 rename tools/testing/selftests/bpf/{test_sock.c => prog_tests/sock_post_bind.c} (64%)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 22, 2024, 9 p.m. UTC | #1
Hello:

This series was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Tue, 22 Oct 2024 15:29:00 +0000 you wrote:
> This patch series migrates test cases out of test_sock.c to
> prog_tests-style tests. It moves all BPF_CGROUP_INET4_POST_BIND and
> BPF_CGROUP_INET6_POST_BIND test cases into a new prog_test,
> sock_post_bind.c, while reimplementing all LOAD_REJECT test cases as
> verifier tests in progs/verifier_sock.c. Finally, it moves remaining
> BPF_CGROUP_INET_SOCK_CREATE test coverage into prog_tests/sock_create.c
> before retiring test_sock.c completely.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2,1/4] selftests/bpf: Migrate *_POST_BIND test cases to prog_tests
    https://git.kernel.org/bpf/bpf-next/c/94682d6ad969
  - [bpf-next,v2,2/4] selftests/bpf: Migrate LOAD_REJECT test cases to prog_tests
    https://git.kernel.org/bpf/bpf-next/c/c17f9734e35b
  - [bpf-next,v2,3/4] selftests/bpf: Migrate BPF_CGROUP_INET_SOCK_CREATE test cases to prog_tests
    https://git.kernel.org/bpf/bpf-next/c/af522f13e917
  - [bpf-next,v2,4/4] selftests/bpf: Retire test_sock.c
    https://git.kernel.org/bpf/bpf-next/c/eea6c14c10ce

You are awesome, thank you!