From patchwork Mon Oct 28 17:38:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 13853767 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65C4C1DEFFE for ; Mon, 28 Oct 2024 17:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730137223; cv=none; b=kdE9L8ddM4XDOtslIy89XWekfW+NkxCHuOnpVG5bWq2IjNhoWj70ATAtv8aul32Z41PyZynvVyCx84rwcYID94+xBJhl9RQdWcWABKK/6VkVj3oXWW0bPr89hHq6FVm1kMfcvD05P3SZkmUx6WwFhpUdHNTrig6mmeEbncDnWfw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730137223; c=relaxed/simple; bh=PjmzZrky7c9XHiIloWKYccp5bYvY8EkYK6R8+nR4g8A=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=LcI6P494l2xchOGakMwwhoy7U21+irG2jZNct9BCU2vmXwnYzCpcDqh1Ed4toOyGCoPnwjETXE6eofYrAObvxnMnoYYais9pDFBFtc+lRJXp+8NStvBcPc+XPow5gdv2L9wCUBQisFIJxSDDd79hr4kvqqyIpdoN4aJXIZ4nU/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=iftEwOQP; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="iftEwOQP" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-37d5689eea8so3094708f8f.1 for ; Mon, 28 Oct 2024 10:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1730137219; x=1730742019; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=+24tbWmwYqjI0PixvLwCG5KaQzbdJT94obj/v2TLFYw=; b=iftEwOQPmfpp1sAIEhT51rV2Sfh1xe04uvb/ca//6tWKoAlssfSgXTcgdYPiPklstQ B+wbapJAY1/wX9urD2+Yfk+slITcezsZ5NmQirOH1YzInaIk3dHvNiWl4+feZAx9XteM Y5gVQWMXcl50PAcfUEQeOv65/FUixVTGCRsPdQdWTnHQ92ns0pEgTpEm5THG8rP7srIk O5hte5vvSuMjjsKVyCYsUc5GHtnWn6ibmeSUKCfk0ZqWkKEddwnd2NR0v5+xHtYaWydi jG3LfxJZnNfrC/6aTm6eHrLKDq9BTvoTbeUrgdqLGXqLxZNKS94Qi1VP+sTi0jm6ULHt B4aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730137219; x=1730742019; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+24tbWmwYqjI0PixvLwCG5KaQzbdJT94obj/v2TLFYw=; b=HCUVNomWFfjlBW/Ez/CZPAM+somKgc/+7bXob7cLBt0KTfG0HZ4cG9aimcZwBVHl+5 KaXvdui9jKfVdPZlDOsGBgO8DR7JTdTAZCnIFLIoJNboK1Wc4aVNXgDxY2yBVDtRD0Z2 jMwzVNvcemqPNkV+KrYqnm5fw1QU7zX0YDEEsuzvoFZxxUjbWn2H/rqyqeWjGTFgI8Zv BtPtIxlUn57yFBMKXwNw1WvbN3m4fd1pUu7s3izJLFIpOQHTFMlIlm3AEfrIqN40H62R 4AwpoapHqgW0F2fOIUXfMSN5IELW40Y72enl6b+ficpy5hiQRLd3sXN3FdGK+uTHSqjP aoIQ== X-Forwarded-Encrypted: i=1; AJvYcCXVhdXpcI7ziOJz3zC0U+1KPFeiO8yDi/wSQj7FFNPKVJ4so7Y3+bzIkfmrt/Y1muA0236c4EQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzPn+fisyVlyKOEQVZJcCXQPlaj4m2ATPI7hWNWJyhhEIx6dEwa fxrdtHxIbEJDKp4QyWNg5CTlkiaBIyGqG8q78JClT9gl8SYCWLtrZ6QdVawsFrE= X-Google-Smtp-Source: AGHT+IFE550FE2Nqygic/ljdueXDXIsWvxFQ/MLExhS5Kk1L7VSfa17/mmDjKm+s/AppiBgP1SXRCQ== X-Received: by 2002:adf:cc8f:0:b0:37d:52b5:451e with SMTP id ffacd0b85a97d-3806118aa34mr6936830f8f.33.1730137218641; Mon, 28 Oct 2024 10:40:18 -0700 (PDT) Received: from localhost ([2001:4091:a245:81f4:340d:1a9d:1fa6:531f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431935f744esm117408815e9.34.2024.10.28.10.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 10:40:18 -0700 (PDT) From: Markus Schneider-Pargmann Subject: [PATCH v5 0/9] can: m_can: Add am62 wakeup support Date: Mon, 28 Oct 2024 18:38:06 +0100 Message-Id: <20241028-topic-mcan-wakeup-source-v6-12-v5-0-33edc0aba629@baylibre.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAP7LH2cC/4XOTQ6CMBCG4auQrh3DlH9X3sO4KO0gjUpJC1VCu LuFuDBuWL6zeL6ZmSOrybFTNDNLXjttuhDZIWKyFd2NQKvQjMc8xTiuYDC9lvCUooOXuNPYgzO jlQQ+B+RQSlR5VSVYq5IFpLfU6Pc2cLmGbrUbjJ22PZ+s1y+NuEf7BGKoiozLAlOhkJ9rMT10b ekozZOtuk9/xWxXTIPYKBF+RiqEyP/EZVk+aKLTGSEBAAA= X-Change-ID: 20241009-topic-mcan-wakeup-source-v6-12-8c1d69931bd8 To: Chandrasekar Ramakrishnan , Marc Kleine-Budde , Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Matthias Schiffer , Vishal Mahaveer , Kevin Hilman , Dhruva Gole , Simon Horman , Vincent MAILHOL , Markus Schneider-Pargmann , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4574; i=msp@baylibre.com; h=from:subject:message-id; bh=PjmzZrky7c9XHiIloWKYccp5bYvY8EkYK6R8+nR4g8A=; b=owGbwMvMwCGm0rPl0RXRdfaMp9WSGNLlz3i1l97ltzN8+evMnOe3jCZNSGpdPbW6yWxf9o0tH rf657aadZSyMIhxMMiKKbLc/bDwXZ3c9QUR6x45wsxhZQIZwsDFKQATSc1h+O/LpDzV/p6y3/GN GW97zrY3nD+2aPPzKF+hJ4cjEnX4tDYzMnzpX3WNkzP8dNu9DdJ28rmFNzYE3VjNeatsHa/u3ZT aPgYA X-Developer-Key: i=msp@baylibre.com; a=openpgp; fpr=BADD88DB889FDC3E8A3D5FE612FA6A01E0A45B41 Hi, Series ------ am62, am62a and am62p support Partial-IO, a poweroff SoC state with a few pin groups being active for wakeup. To support mcu_mcan0 and mcu_mcan1 wakeup for the mentioned SoCs, the series introduces a notion of wake-on-lan for m_can. If the user decides to enable wake-on-lan for a m_can device, the device is set to wakeup enabled. A 'wakeup' pinctrl state is selected to enable wakeup flags for the relevant pins. If wake-on-lan is disabled the default pinctrl is selected. It is based on v6.12-rc1. Partial-IO ---------- This series is part of a bigger topic to support Partial-IO on am62, am62a and am62p. Partial-IO is a poweroff state in which some pins are able to wakeup the SoC. In detail MCU m_can and two serial port pins can trigger the wakeup. A documentation can also be found in section 6.2.4 in the TRM: https://www.ti.com/lit/pdf/spruiv7 This other series is relevant for the support of Partial-IO: - firmware: ti_sci: Partial-IO support https://gitlab.baylibre.com/msp8/linux/-/tree/topic/am62-partialio/v6.12?ref_type=heads Testing ------- A test branch is available here that includes all patches required to test Partial-IO: https://gitlab.baylibre.com/msp8/linux/-/tree/integration/am62/v6.12?ref_type=heads After enabling Wake-on-LAN the system can be powered off and will enter the Partial-IO state in which it can be woken up by activity on the specific pins: ethtool -s can0 wol p ethtool -s can1 wol p poweroff I tested these patches on am62-lp-sk. Best, Markus Previous versions: v1: https://lore.kernel.org/lkml/20240523075347.1282395-1-msp@baylibre.com/ v2: https://lore.kernel.org/lkml/20240729074135.3850634-1-msp@baylibre.com/ v3: https://lore.kernel.org/lkml/20241011-topic-mcan-wakeup-source-v6-12-v3-0-9752c714ad12@baylibre.com v4: https://lore.kernel.org/r/20241015-topic-mcan-wakeup-source-v6-12-v4-0-fdac1d1e7aa6@baylibre.com Changes in v5: - Make the check of wol options nicer to read Changes in v4: - Remove leftover testing code that always returned -EIO in a specific - Redesign pincontrol setup to be easier understandable and less nested - Fix missing parantheses around wol_enable expression - Remove | from binding description Changes in v3: - Rebase to v6.12-rc1 - Change 'wakeup-source' to only 'true' - Simplify m_can_set_wol by returning early on error - Add vio-suuply binding and handling of this optional property. vio-supply is used to reflect the SoC architecture and which power line powers the m_can unit. This is important as some units are powered in special low power modes. Changes in v2: - Rebase to v6.11-rc1 - Squash these two patches for the binding into one: dt-bindings: can: m_can: Add wakeup-source property dt-bindings: can: m_can: Add wakeup pinctrl state - Add error handling to multiple patches of the m_can driver - Add error handling in m_can_class_allocate_dev(). This also required to add a new patch to return error pointers from m_can_class_allocate_dev(). Signed-off-by: Markus Schneider-Pargmann --- Markus Schneider-Pargmann (8): dt-bindings: can: m_can: Add wakeup properties dt-bindings: can: m_can: Add vio-supply can: m_can: Map WoL to device_set_wakeup_enable can: m_can: Return ERR_PTR on error in allocation can: m_can: Support pinctrl wakeup state can: m_can: Add use of optional regulator arm64: dts: ti: k3-am62: Mark mcu_mcan0/1 as wakeup-source arm64: dts: ti: k3-am62a-mcu: Mark mcu_mcan0/1 as wakeup-source Vibhore Vardhan (1): arm64: dts: ti: k3-am62p-mcu: Mark mcu_mcan0/1 as wakeup-source .../devicetree/bindings/net/can/bosch,m_can.yaml | 22 ++++ arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 2 + arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi | 2 + .../boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 2 + drivers/net/can/m_can/m_can.c | 117 ++++++++++++++++++++- drivers/net/can/m_can/m_can.h | 4 + drivers/net/can/m_can/m_can_pci.c | 4 +- drivers/net/can/m_can/m_can_platform.c | 4 +- drivers/net/can/m_can/tcan4x5x-core.c | 4 +- 9 files changed, 152 insertions(+), 9 deletions(-) --- base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc change-id: 20241009-topic-mcan-wakeup-source-v6-12-8c1d69931bd8 Best regards,