From patchwork Tue Oct 29 16:43:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 13855157 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2066.outbound.protection.outlook.com [40.107.249.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ABBB1946C3; Tue, 29 Oct 2024 16:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.249.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730220214; cv=fail; b=FeJsAiOH6OfhstWaJXpXrn18CHocB6BrbbWRozt9N3TbcpF5Wz/3JGIlojGhoXC86ZSJ7BdGkGbQGyi1yQSZEun8jW9/URa0tuxdX/aw35ljhNILtAJjA5+jXw2r/0fv04xVwpfrgP8Xc6qO/6s/3GwE9efHYYkXWLVVgpVQKUg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730220214; c=relaxed/simple; bh=uXWPLJSMo4pWtS+Mgk3wTj7ILrZmAu/ganPYfTy3sXQ=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=oMLqsS1cfJ2OPIc7O1jD4g7QFTdi4I2uwvYH4aTNYdKZlj5rESueX7gslWAnuVVOwoIDiCGsII8sNbuHiFaYU0Q7Oiibk2lMR5KJ1MecU+qi8arOJ8DD/mK4QA8LrMkyaqW1wgL6WhKoQAD8OFCDSTE40PgGXkSRFyZ1IQLgT7E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=cBliRqaM; arc=fail smtp.client-ip=40.107.249.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="cBliRqaM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QHrVQXfAPzIFPknqhClatYrR7cJVIe58fo5eKnQSLoqNd7X2gLCfLNlIy6VODLZDBzN7Z0g9aecZj6uEbVqRigznInmlIObs0lxV2z5IIE6X2ZXYAuKxMFiy8GFv/LGbOLIo9pSSwS3Kwy9GPrylOcD6xr9QMRoDrvNoMGNGH5m9jrC3mBAgNarbeUs+cz5nGk4Snw10GlG2YyZnReOpbHE+y82tOz/cFTb/l49k5+XpwiCFNCJYDmeH/xpOPLIAH12KpDz5cNvQvtHSjJb+SKaX6jTKZokSj3XDi2fvMU7zZBpm8SjDjaCvmqDNILF+WOQc3N5flEJMMSuOK/JKjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fSSkmTixLl3/1Fh7+SC+f8nV2tdqZiSqUtEUT7pDEEI=; b=ykLF35NvcChjKB8KB7K8oGmEZDmsgRWOlxvMXj50IMPs5ResC4A5p2X/BVZea0L0yTqGWqx/QazDyXclWX+EAkeRwQwEMmC+xDreiNv+qf/0tZpUwvGm5Rv+Ok1KQ/4t3a2wyCjyNdyVUdnBOIUYfnqK6LDdnOsR7ScahmM2PxYtWOL4FxljIdGlB68V0tSn7NCVRVj7sbCImVjZCMEPbLHkJxjvEzpN0Ovt+6F/bb65AJkG8STWZ1WwvMfcxo0wjVv10m6/XNwBRAbmh49V2Q5F5owSZliYY0x09nwtCZp4gTAIGRF01FfxpUasM9B71o5xWFoWb4Bwg3YZ99WM8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fSSkmTixLl3/1Fh7+SC+f8nV2tdqZiSqUtEUT7pDEEI=; b=cBliRqaMvci24455Vk3MsKdd2Z1ZMFQd2O++E+0l6rOEBM+JOV8fKOb8BuNM9S9iPeOlYCaUilMKiN4/5+P9Bs2BL9jczvr58kz2G0ONh5Bh9tIB0uh9pst7zrCAGIM/+T5V4d7YsnvXrRr7ESvCsA2vPOBGXvRBAE74esVlNWY6gg6rtOnHa2GEzBkkFUhjdhsgGjTHZdJA21koSiM9AmJ+6HgJRC0sCiOqJwwUfHSeuIRcTz80D44d9p49jxKseRkkx2fP+wxpazZSwqjbaFVjkuTQoj+R2AoQPWm3jlP+ozUe0sM4Oalr6Z6/6ymlzdK0HzVSKbn+dpyvx4QLJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM8PR04MB7779.eurprd04.prod.outlook.com (2603:10a6:20b:24b::14) by DUZPR04MB9871.eurprd04.prod.outlook.com (2603:10a6:10:4b1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.24; Tue, 29 Oct 2024 16:43:29 +0000 Received: from AM8PR04MB7779.eurprd04.prod.outlook.com ([fe80::7417:d17f:8d97:44d2]) by AM8PR04MB7779.eurprd04.prod.outlook.com ([fe80::7417:d17f:8d97:44d2%3]) with mapi id 15.20.8093.027; Tue, 29 Oct 2024 16:43:28 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Breno Leitao , Madalin Bucur , Ioana Ciornei , Radu Bulie , Christophe Leroy , Sean Anderson , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next 0/3] Fix sparse warnings in dpaa_eth driver Date: Tue, 29 Oct 2024 18:43:14 +0200 Message-Id: <20241029164317.50182-1-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: AS4PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::14) To AM8PR04MB7779.eurprd04.prod.outlook.com (2603:10a6:20b:24b::14) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM8PR04MB7779:EE_|DUZPR04MB9871:EE_ X-MS-Office365-Filtering-Correlation-Id: 02a66453-f870-4bbe-f97d-08dcf838d0ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|52116014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: byFZ4bowTiYNIp/VwOuNgJThE7n2swgG4AgsMrOVwaRLc3Bo6yCmGgT2ag3AwTxDsh9Iyirv94jiC+ab4zgwcwuLr7XGehYMTvpMKyAun9vgh2WINLQNjB5nFyAUvtAoh2mN58a8R/Z2NAgE50Os97oshC9XpVj/hV9d1aoPGBEyGxvyH1LWPEQGpk8c7ntMsGpZRRSkolYF+Vu0tVvXGnSotWLoIIzcLQOnINM0LHQC2vLhA/B53XfNxqnnz3ZqlQe+LofawMviU7+SLGeTaVlLHTJacKZM06jfUl9+rTtzgXX5PjBdq8erXUgp0v7r6RpdSDCuhiGYvyRukzergqGmx3HjwDGg3yuzlsbnyQ5C7inRCav/UHa0J4An/dI55mexFHjvNw2DmY66sumeqQFOLopGV+9k88uufHqFFgWTFKqChFMWGg8WZuPj4MGT9kpNMJ2GOHC9waVjSaw3qysS9yhCdCZYACsToSLaEZp4ktfpHTFgah8EFmc+EKEG+Cln1HsxkfKiXlaS4mBTo5K+z62UMKyMnImCG9xUCnQ+EageRIgbsSk2BjEF5vStkDBvZ5dQFCjopHRGLjdvR/CHiwULvV+3Hr29Mfcw6FqruEFS+7R9p51a2DoeDYSY9eEahxpcaOcnOLArZ5yQac7zI6q7y6T49qqbqB5IkRDjJpAUit/OrFM9406MrDhAQxwKWzSFtXF29r2+HHHISDWkGEBArX9+qST8i1aTtS4Cmn+c9LJXPhTxRHkvaFDSJN2t2pwT+KpKjlX2rylkZttcpjvnnI5vN9djWGZbQOcot8OWCT6UsKyRPDTGIA2Ro0V1L/JVqGfvorepuSerPIn+SyM6c/QVMDHFccKwoz6C4JPXzSXRkqBBA5l4CalnUX4Wh5ITFkPlkL0N81/fsBUJOkppONcpRU5taIsWCAddkwhDLM7OXO1bYdhNRnY3530eiw/Xli50VT84r+QkbJv6sqwu29o3qHoLdsS5AwkVgmFk+86AqL71azAzhtFMX1zbA87wQFDf4s86wTHsTStAetOmkXqjsXk6u1wCVieMEHoaPt7Xcy55e3/0FIIl8RL+SMOO9NF26c8mV+sZgxyd2sQZpyhzY0GQxr6ghuXTYUKCfb4MnoraAQY6iJwm2K0yHRqCJgooa2xGdsM27TFQtPhIhqSUBDfcOfXv6E1XRf/L0nZnl+pHTp2FK4yIjrtWe6CZR8wV8Z1aPMnoU3EcQR4NaKkaIEvBSv3LeJ/rU/HYFSpeA4zxMn9vBbrTWuedKAlLx1MCNHQY1l6I4KPFteNoBF40y5EZ/xUOkDUTAyDBiWv6ITQDEWhF4k+fPM6V52ZYDyWJF/47n9PJFUofxeZIFNHFrKTGW+PiDtToOv+QhAotRmZhA6mFkTpF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM8PR04MB7779.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(52116014)(376014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CaSBwqtzLonywbCn3zTWyqZkQBh5hFv5AHb9pPRWFYzIeSO3JJw+2tbpS2RmDfOL/oQE1c7dq0TOkc1QWI+PPgF2XXCfi7neLNnCqz8jZSo0XQTya7be8zzeArkis+0u7NFg1YHUgW9R19zpUfTXKI1PC4ZGwFmWGrqKA3Y8SbBY15LZG68krZ2NcT8bjQM3YHk8Ug4vPpL+4l4gdxhJdjggbO/VKb2/piQjIcPjCtKa96gpH8yzaBR1vGDW9o4IIb7ThI5n7XkkIY2wpVdKjpfSOf7095OGKRqbS4F3N/bnNeWvUuB6Uq4F/XtCzlg33jdvCgq3JqiD/ONwrOb3NzscAk5GeKh+ZLV9Q6msQVeU8ziIdHq1DFKaAaxM8W9VPYcyVWa2Fq0B9yv2/W5eDb880Xr2IqAtw7qSueBN5jTMR6hTc9v21IKB5Jb6XArbeslTIIreXfn5XV3gyOkLA6YYwH9p1ppb7vMVVpH3vY2y7+N5LFAauitnauzcAYbVmJ9o41lBSI66YdcPMMmCMSEeVvVz9M+6cUUaODAB0ZO4MOSY8qp5zYlOdhXsdFad/+EU6+KOfeKZ6F/8VcUOsCwq9vhdai1KZcbi4NVStzk5Pt7Y+AFwVqiCXd5FioY94lS83kZwjTJtlniYm3x9Kaz6W7jK0N8AknyVvIFOVC/8YGr6nx/lPrJ+ljrQxzx5jHa834kqQdlpaqTVT8VOm3JIC3ooh0JbKn3S3LVvifU+qMJeL4RLe5WMgRiKyvLv05Bs7hk1CGMvk/QWoQyWo4n/cbUreyYBW7rtH+ee2AWetBTyYxMi5S4E6P7TXneWHEbMkDsVGq3sPVpp1Cwi33dQENKgOAH6Oj0OJqFifnKyEvpE2ninGX+d7abnfnykgoGMA6qET2kWmbh9fMOy/NhD048QLjVFGsQzdhLigRMTVlP5bIHElBaMpwbyepV1M6srHQL4TR+tWwu71GO6wEiaC9SsiiM3C3MJxvqE1ZM+3QNHVxLzsi6hhpRyGNvls+o24cfJz+it08B4sx4Uy0nXNCo0A+WJ6YrrTmH1aK4MPyLeM870rKhAUIDpZ+OXFpe0GPXykbayWt28d0vbBDm3ANIfMAmxCMOivGSvaME8VAPQZzQ0x7UiF3oJlD9XIITFu9muZjPutfLPRESvU7U0ck/4h56e7AwvsoPw5C1I0M92r4FzF9kn1/NYI9K4rd/OQn/03zHlOlWqBFanM9jDuEDUfBqC8m1Cqb8EVf1hYgMCJ8P4HDRTvrCGlG5A5OLldyO/QPc2L7KjgBP8DF9cMXUbP8JZoKKDsV7vEl8UI+gWjeuVq36vFi07PybMszZGzceHGaBjvBUu4cgShESdqtkD8AYLRcsGgk2Hndd88jxYLt/gIW0YKm3TLHgZcHWzg5embTFjcDjUoVh9UNmwqZklvb9Ze3u2mr4WZMWPrvooaVIYzjH8YqoiphC0xRfzNt9egX6wryB1F2YtR4gPpB3DM7QsDMbn++XfuE85BpdyVMorYRERl0MULSXXuvwoPEdZnO6EVfDfWMiNNSiH3jgBFySloOyT4/1sWKyYbWyhIlFNLwsx+ZUs+mPq76td9G+aQ3M/dKA70Fa1mQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02a66453-f870-4bbe-f97d-08dcf838d0ed X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7779.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2024 16:43:28.8973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TLcAJ0tdR05NNLeH/O4Y773M9sCBHH5F4Dp7+PKMxN+Q3pppVgEr9nTTXOI+i9TRJ3ffbnBwKJsQU/x+T3b4ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB9871 X-Patchwork-Delegate: kuba@kernel.org This is a follow-up of the discussion at: https://lore.kernel.org/oe-kbuild-all/20241028-sticky-refined-lionfish-b06c0c@leitao/ where I said I would take care of the sparse warnings uncovered by Breno's COMPILE_TEST change for the dpaa_eth driver. There was one warning that I decided to treat as an actual bug: https://lore.kernel.org/netdev/20241029163105.44135-1-vladimir.oltean@nxp.com/ and what remains here are those warnings which I consider harmless. I would like Christophe to ack the entire series to be taken through netdev. I find it weird that the qbman driver, whose major API consumer is netdev, is maintained by a different group. In this case, the buggy qm_sg_entry_get_off() function is defined in qbman but exclusively called in netdev. Vladimir Oltean (3): soc: fsl_qbman: use be16_to_cpu() in qm_sg_entry_get_off() net: dpaa_eth: add assertions about SGT entry offsets in sg_fd_to_skb() net: dpaa_eth: extract hash using __be32 pointer in rx_default_dqrr() .../net/ethernet/freescale/dpaa/dpaa_eth.c | 26 ++++++++++++------- include/soc/fsl/qman.h | 2 +- 2 files changed, 17 insertions(+), 11 deletions(-) Acked-by: Madalin Bucur