mbox series

[net,v2,0/3] virtio/vsock: Fix memory leaks

Message ID 20241107-vsock-mem-leaks-v2-0-4e21bfcfc818@rbox.co (mailing list archive)
Headers show
Series virtio/vsock: Fix memory leaks | expand

Message

Michal Luczaj Nov. 7, 2024, 8:46 p.m. UTC
Short series fixing some memory leaks that I've stumbled upon while toying
with the selftests.

Signed-off-by: Michal Luczaj <mhal@rbox.co>
---
Changes in v2:
- Remove the refactoring patch from the series [Stefano]
- PATCH 2: Drop "virtio" from the commit title [Stefano]
- Collect Reviewed-by [Stefano]
- Link to v1: https://lore.kernel.org/r/20241106-vsock-mem-leaks-v1-0-8f4ffc3099e6@rbox.co

---
Michal Luczaj (3):
      virtio/vsock: Fix accept_queue memory leak
      vsock: Fix sk_error_queue memory leak
      virtio/vsock: Improve MSG_ZEROCOPY error handling

 net/vmw_vsock/af_vsock.c                | 3 +++
 net/vmw_vsock/virtio_transport_common.c | 9 +++++++++
 2 files changed, 12 insertions(+)
---
base-commit: 71712cf519faeed529549a79559c06c7fc250a15
change-id: 20241106-vsock-mem-leaks-9b63e912560a

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 12, 2024, 11:40 a.m. UTC | #1
Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu, 07 Nov 2024 21:46:11 +0100 you wrote:
> Short series fixing some memory leaks that I've stumbled upon while toying
> with the selftests.
> 
> Signed-off-by: Michal Luczaj <mhal@rbox.co>
> ---
> Changes in v2:
> - Remove the refactoring patch from the series [Stefano]
> - PATCH 2: Drop "virtio" from the commit title [Stefano]
> - Collect Reviewed-by [Stefano]
> - Link to v1: https://lore.kernel.org/r/20241106-vsock-mem-leaks-v1-0-8f4ffc3099e6@rbox.co
> 
> [...]

Here is the summary with links:
  - [net,v2,1/3] virtio/vsock: Fix accept_queue memory leak
    https://git.kernel.org/netdev/net/c/d7b0ff5a8667
  - [net,v2,2/3] vsock: Fix sk_error_queue memory leak
    https://git.kernel.org/netdev/net/c/fbf7085b3ad1
  - [net,v2,3/3] virtio/vsock: Improve MSG_ZEROCOPY error handling
    https://git.kernel.org/netdev/net/c/60cf6206a1f5

You are awesome, thank you!
Stefano Garzarella Nov. 19, 2024, 10:31 a.m. UTC | #2
Hi Michal,

On Thu, Nov 07, 2024 at 09:46:11PM +0100, Michal Luczaj wrote:
>Short series fixing some memory leaks that I've stumbled upon while 
>toying
>with the selftests.

Are these tests already upstream?
I would like to add them to my suite, can you tell me how to run them?

Thanks,
Stefano

>
>Signed-off-by: Michal Luczaj <mhal@rbox.co>
>---
>Changes in v2:
>- Remove the refactoring patch from the series [Stefano]
>- PATCH 2: Drop "virtio" from the commit title [Stefano]
>- Collect Reviewed-by [Stefano]
>- Link to v1: https://lore.kernel.org/r/20241106-vsock-mem-leaks-v1-0-8f4ffc3099e6@rbox.co
>
>---
>Michal Luczaj (3):
>      virtio/vsock: Fix accept_queue memory leak
>      vsock: Fix sk_error_queue memory leak
>      virtio/vsock: Improve MSG_ZEROCOPY error handling
>
> net/vmw_vsock/af_vsock.c                | 3 +++
> net/vmw_vsock/virtio_transport_common.c | 9 +++++++++
> 2 files changed, 12 insertions(+)
>---
>base-commit: 71712cf519faeed529549a79559c06c7fc250a15
>change-id: 20241106-vsock-mem-leaks-9b63e912560a
>
>Best regards,
>-- 
>Michal Luczaj <mhal@rbox.co>
>
Michal Luczaj Dec. 6, 2024, 6:39 p.m. UTC | #3
On 11/19/24 11:31, Stefano Garzarella wrote:
> Hi Michal,
> 
> On Thu, Nov 07, 2024 at 09:46:11PM +0100, Michal Luczaj wrote:
>> Short series fixing some memory leaks that I've stumbled upon while 
>> toying
>> with the selftests.
> 
> Are these tests already upstream?
> I would like to add them to my suite, can you tell me how to run them?

CC got accidentally stripped, sorry.
Long story short: https://lore.kernel.org/netdev/20241206-test-vsock-leaks-v1-0-c31e8c875797@rbox.co/

Thanks,
Michal